From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 2076B29C7 for ; Tue, 21 Nov 2017 15:27:43 +0100 (CET) Received: by mail-wm0-f68.google.com with SMTP id y80so3769377wmd.0 for ; Tue, 21 Nov 2017 06:27:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=eIiMJ9XQqriI0NA3iK3ChMICh6pEcA0HLL6NcmkYncs=; b=2Bgf7DMV0l55prf4vFI65+w69DN4oXkgXtZdc4zcynQ2Q6psVgabT8OtKsF1p/sJJ9 kkhTWxjaUvKkhyXn2NQ6bK8T5QH3sCCx8S5vtlCx2C4BvRdV24YHroqU6rQjBxzA5uHr lrJD7dGg/RPi9b9hqA2eMmSuxpM9eB3sJKlShH+QDA9UmToKGruQWkmRQ/vdCw3KoLVp Mf1O0Q9HJo2C+ZFGX29L7eAdH+mtBENJ+I8llUaAJ+vOkg21tpq8FILBspxPndDAOzW4 zKuKPsGv3ScU2ScdOsk/ZeFyJyYchVO37elH0oJDuF8T+BaE0swv0Q8DwzjPZ8v6jZXC Kb5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eIiMJ9XQqriI0NA3iK3ChMICh6pEcA0HLL6NcmkYncs=; b=LJt3c+kBXh+iFOn3d+C4HySGOHSEtnObAffzrTk2cubcpU3LPa49h5FFBRgbxEfUcf lsdTljitbJ5lTn4ELIn/DeUKTsZllt3bWkkBumXDzaHvNV41DGqooZGt7vO3Uynl/3Ds dLi1v2/u0ClMFyTxATf1NAk35blMFYkPSHsThL3BdmY22kLWBiNU5X5WopM1ZMiXwn0o R8mKQOk3lcCz6FAdilzgqJtFMlrnRpBpp/+jwV8XS79eOU6bWCv2Dg5UI+XCYk5x9p8p eF2KQMTzep7oGyByBwth8hRLiPXZzh1VTjQuTJ7Rlh1OdSPVjd1BLX+yKg0df3yQgMb6 bDFg== X-Gm-Message-State: AJaThX57o5lU6iAyq9gRhdLPr/JGqAY+bntE3fpk+18ggj2yBU35dfnq ujSU/IcDJFJuBRC1sYxcMHOfxg== X-Google-Smtp-Source: AGs4zMbZFoGXNuG/NY1QoHRovDU42tZv6jNhbPfLLdrSiOV46+RY4GAnJxTW7vo6CI90uh7A6qCzPA== X-Received: by 10.28.67.68 with SMTP id q65mr1371081wma.26.1511274462863; Tue, 21 Nov 2017 06:27:42 -0800 (PST) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id m64sm1149133wmb.10.2017.11.21.06.27.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Nov 2017 06:27:41 -0800 (PST) Date: Tue, 21 Nov 2017 15:27:30 +0100 From: Adrien Mazarguil To: Ferruh Yigit Cc: dev@dpdk.org, stable@dpdk.org Message-ID: <1511272929-17955-4-git-send-email-adrien.mazarguil@6wind.com> References: <1511272929-17955-1-git-send-email-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1511272929-17955-1-git-send-email-adrien.mazarguil@6wind.com> X-Mailer: git-send-email 2.1.4 Subject: [dpdk-dev] [PATCH v1 3/5] net/mlx4: use function to get default RSS fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 14:27:43 -0000 Supported RSS hash fields are listed in function mlx4_conv_rss_hf() and duplicated in mlx4_flow_prepare(); the latter are used when RSS is requested without specifying any parameters. This commit standardizes on mlx4_conv_rss_hf(). Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4_flow.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c index 8b87b29..7397dde 100644 --- a/drivers/net/mlx4/mlx4_flow.c +++ b/drivers/net/mlx4/mlx4_flow.c @@ -105,6 +105,9 @@ struct mlx4_drop { /** * Convert DPDK RSS hash fields to their Verbs equivalent. * + * This function returns the supported (default) set when @p rss_hf has + * special value (uint64_t)-1. + * * @param rss_hf * Hash fields in DPDK format (see struct rte_eth_rss_conf). * @@ -154,6 +157,8 @@ mlx4_conv_rss_hf(uint64_t rss_hf) seen |= rss_hf & in[i]; conv |= out[i]; } + if (rss_hf == (uint64_t)-1) + return conv; if (!(rss_hf & ~seen)) return conv; rte_errno = ENOTSUP; @@ -759,10 +764,7 @@ mlx4_flow_prepare(struct priv *priv, &(struct rte_eth_rss_conf){ .rss_key = mlx4_rss_hash_key_default, .rss_key_len = MLX4_RSS_HASH_KEY_SIZE, - .rss_hf = (ETH_RSS_IPV4 | - ETH_RSS_NONFRAG_IPV4_TCP | - ETH_RSS_IPV6 | - ETH_RSS_NONFRAG_IPV6_TCP), + .rss_hf = -1, }; /* Sanity checks. */ for (i = 0; i < rss->num; ++i) -- 2.1.4