From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tdu@semihalf.com>
Received: from mail-lf0-f66.google.com (mail-lf0-f66.google.com
 [209.85.215.66]) by dpdk.org (Postfix) with ESMTP id BDBA6374C
 for <dev@dpdk.org>; Thu, 30 Nov 2017 14:32:43 +0100 (CET)
Received: by mail-lf0-f66.google.com with SMTP id f20so7917686lfe.3
 for <dev@dpdk.org>; Thu, 30 Nov 2017 05:32:43 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=semihalf-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:in-reply-to:references;
 bh=isEf6QMIcfbe4/UbGntpsmM4mJcyqiMztdefPi5AAYI=;
 b=pyhVFFrTS+z8I4XiO8XvEK355qgw8bTu0yWU/58+xLZRIP7KBx/yL9Pn+KbHtV7gOS
 A0LsvGsneCcO8wt0COl/PsxAKOC1TU3HlBeSnBpFNtjoUmy5zqKh3cVY1YW8D+QKzQT2
 jFj0AayktLE+cH7wBT/oBAkc4mQAY7FyKAKLc3FSKxuMzVp51/k/1bpLNfSCWbQZAOXt
 DNPj7JYD8g3eYqjFoza+OXdvVYsDfweOqGQVr3s+JyjsVlDCTqYDYwqGDkozBnx0GGOl
 0ETeITqNumKEt0mYNSP69pOilYl3deW5V4KGmBucG2C2uzlymSeEy8P+1ofjkVkxljlT
 FLXQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references;
 bh=isEf6QMIcfbe4/UbGntpsmM4mJcyqiMztdefPi5AAYI=;
 b=Hh/sA8BJxU0S9d17nsXOfipcxTdsxHKbzS12kXBvukBkzTMYFuY8M5qfUBr636Sdme
 YCaoiprn1tvH0IoM4TImVWayQD9F8RR25L/vrXTc9tBdlEA/P3yVoGSapdH2tyTy0c7b
 GYHZNBmPJk4bBJsYPSNDVYfFZaaBhfzPD3dFPZgvqMnMxWROaWfdhskbODQ6x8gUIZpm
 pWf+OgoSkz2ryJrlQYFx+jpUj1LLzKNzRzVU0Ae0DWYPvS7hDYj8WqAQZFmKZSSLcIOk
 4SFpXiJm9KDSG4Aswfut//3y5R6xeTPFsJTTwWv/+mKR1VsU6WR1JYUcMxjQOj3w4SyK
 HoZg==
X-Gm-Message-State: AJaThX7RQRidOwwT7/F4vwf40mpKBIpOmQJFVg88ssITMvoIOBS+hOeL
 wNiw8XyofCFCHw/4s5x1NYzh7kY2Ai4=
X-Google-Smtp-Source: AGs4zMbLrNtI8FuatbUwAvkcvyEhZpp6i3KejhFFW0ZJoUarn9XXbZrAFzjuuBN3/CXHywcdeFEpLw==
X-Received: by 10.46.127.9 with SMTP id a9mr3304423ljd.44.1512048762950;
 Thu, 30 Nov 2017 05:32:42 -0800 (PST)
Received: from tdu.semihalf.local (31-172-191-173.noc.fibertech.net.pl.
 [31.172.191.173])
 by smtp.gmail.com with ESMTPSA id x27sm717277lfb.23.2017.11.30.05.32.41
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
 Thu, 30 Nov 2017 05:32:42 -0800 (PST)
From: Tomasz Duszynski <tdu@semihalf.com>
To: dev@dpdk.org
Cc: mw@semihalf.com, jck@semihalf.com, dima@marvell.com, nsamsono@marvell.com,
 jianbo.liu@arm.com, Tomasz Duszynski <tdu@semihalf.com>
Date: Thu, 30 Nov 2017 14:32:21 +0100
Message-Id: <1512048743-23749-6-git-send-email-tdu@semihalf.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1512048743-23749-1-git-send-email-tdu@semihalf.com>
References: <1512048743-23749-1-git-send-email-tdu@semihalf.com>
Subject: [dpdk-dev] [PATCH 5/7] net/mrvl: add extra error logs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Nov 2017 13:32:44 -0000

Add extra error logs in a few places.

Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
---
 drivers/net/mrvl/mrvl_ethdev.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/net/mrvl/mrvl_ethdev.c b/drivers/net/mrvl/mrvl_ethdev.c
index 92cc283..ed97831 100644
--- a/drivers/net/mrvl/mrvl_ethdev.c
+++ b/drivers/net/mrvl/mrvl_ethdev.c
@@ -431,8 +431,10 @@ mrvl_dev_start(struct rte_eth_dev *dev)
 	priv->bpool_min_size = priv->nb_rx_queues * MRVL_BURST_SIZE * 2;
 
 	ret = pp2_ppio_init(&priv->ppio_params, &priv->ppio);
-	if (ret)
+	if (ret) {
+		RTE_LOG(ERR, PMD, "Failed to init ppio\n");
 		return ret;
+	}
 
 	/*
 	 * In case there are some some stale uc/mc mac addresses flush them
@@ -467,8 +469,8 @@ mrvl_dev_start(struct rte_eth_dev *dev)
 	if (mrvl_qos_cfg) {
 		ret = mrvl_start_qos_mapping(priv);
 		if (ret) {
-			pp2_ppio_deinit(priv->ppio);
-			return ret;
+			RTE_LOG(ERR, PMD, "Failed to setup QoS mapping\n");
+			goto out;
 		}
 	}
 
@@ -478,6 +480,7 @@ mrvl_dev_start(struct rte_eth_dev *dev)
 
 	return 0;
 out:
+	RTE_LOG(ERR, PMD, "Failed to start device\n");
 	pp2_ppio_deinit(priv->ppio);
 	return ret;
 }
-- 
2.7.4