DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v1] [net/pcap] fix the NUMA id display in logs.
@ 2017-12-22  4:38 Vipin Varghese
  2018-01-11 18:06 ` Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: Vipin Varghese @ 2017-12-22  4:38 UTC (permalink / raw)
  To: dev; +Cc: david.hunt, deepak.k.jain, Vipin Varghese

On single NUMA device the log information shows as boundary value
instead of -1. The change brings in unsinged to signed.

Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
---
 drivers/net/pcap/rte_eth_pcap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c
index 5a86752..f2f1e44 100644
--- a/drivers/net/pcap/rte_eth_pcap.c
+++ b/drivers/net/pcap/rte_eth_pcap.c
@@ -806,7 +806,7 @@ struct pmd_devargs {
 	const char *name;
 
 	name = rte_vdev_device_name(vdev);
-	RTE_LOG(INFO, PMD, "Creating pcap-backed ethdev on numa socket %u\n",
+	RTE_LOG(INFO, PMD, "Creating pcap-backed ethdev on numa socket %d\n",
 		numa_node);
 
 	/* now do all data allocation - for eth_dev structure
@@ -1036,7 +1036,7 @@ struct pmd_devargs {
 {
 	struct rte_eth_dev *eth_dev = NULL;
 
-	RTE_LOG(INFO, PMD, "Closing pcap ethdev on numa socket %u\n",
+	RTE_LOG(INFO, PMD, "Closing pcap ethdev on numa socket %d\n",
 			rte_socket_id());
 
 	if (!dev)
-- 
1.9.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH v1] [net/pcap] fix the NUMA id display in logs.
  2017-12-22  4:38 [dpdk-dev] [PATCH v1] [net/pcap] fix the NUMA id display in logs Vipin Varghese
@ 2018-01-11 18:06 ` Ferruh Yigit
  2018-01-11 18:10   ` Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2018-01-11 18:06 UTC (permalink / raw)
  To: Vipin Varghese, dev; +Cc: david.hunt, deepak.k.jain

On 12/22/2017 4:38 AM, Vipin Varghese wrote:
> On single NUMA device the log information shows as boundary value
> instead of -1. The change brings in unsinged to signed.
> 
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH v1] [net/pcap] fix the NUMA id display in logs.
  2018-01-11 18:06 ` Ferruh Yigit
@ 2018-01-11 18:10   ` Ferruh Yigit
  0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-01-11 18:10 UTC (permalink / raw)
  To: Vipin Varghese, dev; +Cc: david.hunt, deepak.k.jain

On 1/11/2018 6:06 PM, Ferruh Yigit wrote:
> On 12/22/2017 4:38 AM, Vipin Varghese wrote:
>> On single NUMA device the log information shows as boundary value
>> instead of -1. The change brings in unsinged to signed.
>>
>> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-01-11 18:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-22  4:38 [dpdk-dev] [PATCH v1] [net/pcap] fix the NUMA id display in logs Vipin Varghese
2018-01-11 18:06 ` Ferruh Yigit
2018-01-11 18:10   ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).