* [dpdk-dev] [PATCH] examples/vhost: fix sending arp packet to self
@ 2017-12-29 10:14 Junjie Chen
2017-12-29 6:27 ` Yang, Zhiyong
2017-12-29 14:33 ` [dpdk-dev] [PATCH v2] " Junjie Chen
0 siblings, 2 replies; 5+ messages in thread
From: Junjie Chen @ 2017-12-29 10:14 UTC (permalink / raw)
To: yliu, maxime.coquelin; +Cc: dev, Junjie Chen
ARP packets are not dropped when dest vdev is itself, which breaks
RX ring inconspicuously.
Signed-off-by: Junjie Chen <junjie.j.chen@intel.com>
---
examples/vhost/main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index 89a61f0..10a7f5d 100644
--- a/examples/vhost/main.c
+++ b/examples/vhost/main.c
@@ -964,7 +964,8 @@ virtio_tx_route(struct vhost_dev *vdev, struct rte_mbuf *m, uint16_t vlan_tag)
struct vhost_dev *vdev2;
TAILQ_FOREACH(vdev2, &vhost_dev_list, global_vdev_entry) {
- virtio_xmit(vdev2, vdev, m);
+ if (vdev2 != vdev)
+ virtio_xmit(vdev2, vdev, m);
}
goto queue2nic;
}
--
2.0.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] examples/vhost: fix sending arp packet to self
2017-12-29 10:14 [dpdk-dev] [PATCH] examples/vhost: fix sending arp packet to self Junjie Chen
@ 2017-12-29 6:27 ` Yang, Zhiyong
2017-12-29 6:52 ` Chen, Junjie J
2017-12-29 14:33 ` [dpdk-dev] [PATCH v2] " Junjie Chen
1 sibling, 1 reply; 5+ messages in thread
From: Yang, Zhiyong @ 2017-12-29 6:27 UTC (permalink / raw)
To: Chen, Junjie J, yliu, maxime.coquelin; +Cc: dev, Chen, Junjie J
Hi Junjie,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Junjie Chen
> Sent: Friday, December 29, 2017 6:14 PM
> To: yliu@fridaylinux.org; maxime.coquelin@redhat.com
> Cc: dev@dpdk.org; Chen, Junjie J <junjie.j.chen@intel.com>
> Subject: [dpdk-dev] [PATCH] examples/vhost: fix sending arp packet to self
>
> ARP packets are not dropped when dest vdev is itself, which breaks RX ring
> inconspicuously.
>
If you are fixing a bug, it's better to write one fixline before SOB that can describe which commit caused the issue.
For example,
Fixes: 756ce64b1ecd ("eal: introduce PCI ioport API")
Thanks
Zhiyong
> Signed-off-by: Junjie Chen <junjie.j.chen@intel.com>
> ---
...
<snip>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] examples/vhost: fix sending arp packet to self
2017-12-29 6:27 ` Yang, Zhiyong
@ 2017-12-29 6:52 ` Chen, Junjie J
0 siblings, 0 replies; 5+ messages in thread
From: Chen, Junjie J @ 2017-12-29 6:52 UTC (permalink / raw)
To: Yang, Zhiyong, yliu, maxime.coquelin; +Cc: dev
Thanks Zhiyong
Updated in v2.
> -----Original Message-----
> From: Yang, Zhiyong
> Sent: Friday, December 29, 2017 2:27 PM
> To: Chen, Junjie J <junjie.j.chen@intel.com>; yliu@fridaylinux.org;
> maxime.coquelin@redhat.com
> Cc: dev@dpdk.org; Chen, Junjie J <junjie.j.chen@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] examples/vhost: fix sending arp packet to self
>
> Hi Junjie,
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Junjie Chen
> > Sent: Friday, December 29, 2017 6:14 PM
> > To: yliu@fridaylinux.org; maxime.coquelin@redhat.com
> > Cc: dev@dpdk.org; Chen, Junjie J <junjie.j.chen@intel.com>
> > Subject: [dpdk-dev] [PATCH] examples/vhost: fix sending arp packet to
> > self
> >
> > ARP packets are not dropped when dest vdev is itself, which breaks RX
> > ring inconspicuously.
> >
> If you are fixing a bug, it's better to write one fixline before SOB that can
> describe which commit caused the issue.
> For example,
> Fixes: 756ce64b1ecd ("eal: introduce PCI ioport API")
>
> Thanks
> Zhiyong
>
> > Signed-off-by: Junjie Chen <junjie.j.chen@intel.com>
> > ---
> ...
> <snip>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH v2] examples/vhost: fix sending arp packet to self
2017-12-29 10:14 [dpdk-dev] [PATCH] examples/vhost: fix sending arp packet to self Junjie Chen
2017-12-29 6:27 ` Yang, Zhiyong
@ 2017-12-29 14:33 ` Junjie Chen
2018-01-08 14:14 ` Yuanhan Liu
1 sibling, 1 reply; 5+ messages in thread
From: Junjie Chen @ 2017-12-29 14:33 UTC (permalink / raw)
To: zhiyong.yang, yliu, maxime.coquelin; +Cc: dev, Junjie Chen
ARP packets are not dropped when dest vdev is itself, which breaks
RX ring inconspicuously.
Fixes: 9c5ef51207c6 ("examples/vhost: handle broadcast packet")
Signed-off-by: Junjie Chen <junjie.j.chen@intel.com>
---
v2:
- Add fixline in commit message.
examples/vhost/main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index 89a61f0..10a7f5d 100644
--- a/examples/vhost/main.c
+++ b/examples/vhost/main.c
@@ -964,7 +964,8 @@ virtio_tx_route(struct vhost_dev *vdev, struct rte_mbuf *m, uint16_t vlan_tag)
struct vhost_dev *vdev2;
TAILQ_FOREACH(vdev2, &vhost_dev_list, global_vdev_entry) {
- virtio_xmit(vdev2, vdev, m);
+ if (vdev2 != vdev)
+ virtio_xmit(vdev2, vdev, m);
}
goto queue2nic;
}
--
2.0.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH v2] examples/vhost: fix sending arp packet to self
2017-12-29 14:33 ` [dpdk-dev] [PATCH v2] " Junjie Chen
@ 2018-01-08 14:14 ` Yuanhan Liu
0 siblings, 0 replies; 5+ messages in thread
From: Yuanhan Liu @ 2018-01-08 14:14 UTC (permalink / raw)
To: Junjie Chen; +Cc: zhiyong.yang, maxime.coquelin, dev
On Fri, Dec 29, 2017 at 09:33:19AM -0500, Junjie Chen wrote:
> ARP packets are not dropped when dest vdev is itself, which breaks
> RX ring inconspicuously.
>
> Fixes: 9c5ef51207c6 ("examples/vhost: handle broadcast packet")
>
> Signed-off-by: Junjie Chen <junjie.j.chen@intel.com>
> ---
Applied to dpdk-next-virtio.
Thanks.
--yliu
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-01-08 14:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-29 10:14 [dpdk-dev] [PATCH] examples/vhost: fix sending arp packet to self Junjie Chen
2017-12-29 6:27 ` Yang, Zhiyong
2017-12-29 6:52 ` Chen, Junjie J
2017-12-29 14:33 ` [dpdk-dev] [PATCH v2] " Junjie Chen
2018-01-08 14:14 ` Yuanhan Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).