From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f175.google.com (mail-wj0-f175.google.com [209.85.210.175]) by dpdk.org (Postfix) with ESMTP id 015CF2BAF for ; Tue, 6 Dec 2016 12:01:33 +0100 (CET) Received: by mail-wj0-f175.google.com with SMTP id tk12so20814044wjb.3 for ; Tue, 06 Dec 2016 03:01:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=iGfRh1+lBM09YKn9i7nuGKBAJ1ZMOGsu75gwRG7GB5Y=; b=E861GMahrXAGsDCo9stVDj+fPcga6EsDSHE4vnAVRdaiOMKAcuHv6DQIQDstmMpp+s QaLISmwkK5/x+uqTqum1lLugp/c77AT3+iOvGQQprAjDKHNcFs0g9omj7PZVGRgxwXK8 7rUPdNDz3u+gdpXhSXU6tqVlvE5lg1yEGm/df8lynuz+zvWP+NgtX3/50VHsvWMNY0zZ Sn/wcYOxtTthwvMEWI56qWK9fiwPtVFbYeTlPWcnf1J2tcd3EPcyZ2lTZGWGrIBLMG5g gsrUUSUPwZOjdRqNQIFAr69EOMZPIhzuIYetwnZ+a6J9w2J9ktS7qe2IihrdMI/PxTsW M9zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=iGfRh1+lBM09YKn9i7nuGKBAJ1ZMOGsu75gwRG7GB5Y=; b=hQ5SEr4JHwINLdX7ix0/hv0QYq6Jwyf35GFaQwj+CnavASIfL+5Ewev0EIqSwf3PCN wWFJ+g2rXdGVVU+iiiV1667nvhxKR3f1K71VHHzvsncwNyVB4eztfFGdFpHVNgbWd1qV BU+lPiEH52DAsG+5bRJafjfcOpNAhM+O0R2sCxlRBFi0hE3pmDOj2oQ9aqDJQGRuWLXJ /nqZ5m07nVEe0Z4mwDn5N2S28MqXIP3ccICXw5AZ/TbE0UUeD8dY9xA9pqKRVBLg8XwH EfhR30AsG3KX4JveAPmkyRHnGRMp1cM7oEMXLyY9ifQ6CFQdGC9BBj8DUrVw+YGnJYS6 wIyQ== X-Gm-Message-State: AKaTC03yz284vZJS6nlOv8q2ipdhI7l+A66NFCty028c4GGBOxc5NHvGDUvEi7ul+gcvPgC3 X-Received: by 10.194.177.197 with SMTP id cs5mr62673557wjc.6.1481022093468; Tue, 06 Dec 2016 03:01:33 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id dj5sm25107733wjb.34.2016.12.06.03.01.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Dec 2016 03:01:32 -0800 (PST) From: Thomas Monjalon To: Wei Dai Cc: dev@dpdk.org, Olivier Matz , david.marchand@6wind.com, stable@dpdk.org Date: Tue, 06 Dec 2016 12:01:31 +0100 Message-ID: <1514903.KFypzPenqL@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20161206114459.0a05cbe0@platinum> References: <1479264047-67966-1-git-send-email-wei.dai@intel.com> <1479365235-134903-1-git-send-email-wei.dai@intel.com> <20161206114459.0a05cbe0@platinum> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] eal/linuxapp: fix return value check of mknod() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Dec 2016 11:01:34 -0000 2016-12-06 11:44, Olivier Matz: > Hi Wei, > > On Thu, 17 Nov 2016 14:47:15 +0800, Wei Dai wrote: > > In function pci_mknod_uio_dev() in lib/librte_eal/eal/eal_pci_uio.c, > > The return value of mknod() is ret, not f got by fopen(). > > So the value of ret should be checked for mknod(). > > > > Fixes: f7f97c16048e ("pci: add option --create-uio-dev to run without > > hotplug") CC: stable@dpdk.org > > Signed-off-by: Wei Dai > > Acked-by: Olivier Matz > > Thanks Applied, thanks