From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0067.outbound.protection.outlook.com [104.47.1.67]) by dpdk.org (Postfix) with ESMTP id EB4391D7; Sun, 7 Jan 2018 12:05:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Ne4vijJQD7SHrJlphQdCoV6oGgQR56qHY7ttu4Uncgo=; b=hPttDRb0oeeFVu6za3h/DwZ9RA3NxIqNfmfOCBCMe7y23Kfrb7mJUJ9xiraHbeLZoyYU4N715fX4NVm8CkYeofQDddr5G9c/pg/gOrLRvWstOh4EkfMJ5OBQgpDtR0+uuD0cDIPAqpOzhiTKp+e9ARoj8/E/0rmehi0JdVKxqP4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=motih@mellanox.com; Received: from mellanox.com (37.142.13.130) by HE1PR05MB3212.eurprd05.prod.outlook.com (2603:10a6:7:35::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.386.5; Sun, 7 Jan 2018 11:05:04 +0000 From: Moti Haimovsky To: adrienm@mellanox.com Cc: dev@dpdk.org, Moti Haimovsky , stable@dpdk.org Date: Sun, 7 Jan 2018 13:04:46 +0200 Message-Id: <1515323086-100332-1-git-send-email-motih@mellanox.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1PR0801CA0082.eurprd08.prod.outlook.com (2603:10a6:800:7d::26) To HE1PR05MB3212.eurprd05.prod.outlook.com (2603:10a6:7:35::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 86002f40-8d53-4383-da7f-08d555be81de X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:HE1PR05MB3212; X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB3212; 3:g5oEdQECg6Dc1+Yckw255xBmR8JXnODz6M9K9JjeCA151fV078oR8DfLNmul7EJW29I//rFh3Xq0A3Wdi5vImibU+P6JzDV3JYiSbiRx2JvmQEeXagowqejX2IAYpYIizQAG1eFGeXD2nNbkuB/wmSZe/HqqWBFlLejP8zR9yQ5vNmWvQp84CUg5knklme2dMDnSGtivslWqTDylypR0GvtkD7xFYckbI4jtpUCYzRGRWcEgu7nhU7Wj/yAbZWSc; 25:NHKn63gcmeoqslTT65Ik0QfGXkTu115bPArRom37WP2uxFR5WEinkTNMHmQx0W8VEDPOBlcg7KGyiI9eRY5RRZrgapaoa8Cq4V//OsqH0p7XPs1jb5tP3yHT59J0dPgJX7QCN1C41TaoRQC06NMMA8yl+JtRHEYHsUbfhHtx0j1oCaKP/2KgJeJChi+beBo851x1BIR/cK9KCRzwl2YKiw6+NF6f7c856h6Dl5kvIKuEqKFQQUAG0rEuGUR1X4VGh2z20XtSmgw2EIQk2B24PktJQ4UVTo1Omdtc+UkQhLKxrVD5KFVOrzZiWZkXF4Yz/5ky2kICTERyQsE9zhNdFg==; 31:Z5PnnyMY/zX+66SwYJODTuoJtRnXDkDdfCiDpui65An8ewJKC52Xpa4eat5FPA7FpLOGeosek7AS3eKoOscgbmsXnmJpFZSbSDWp5Ev04wv7kyFwL9ZYCV513dQbwkUQMpVURd3yvjQxyugodOZROU2his/HsS544kqFfNnE+VIUt/Pkg9hVx7cjwPulUd2Wzmkx9qwwarkktyCQ9twjZzhAfl2tp+/iwVWqDnZ5KAQ= X-MS-TrafficTypeDiagnostic: HE1PR05MB3212: X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB3212; 20:uU8UMJB1vnqb9TdRG/NCE+2qBIeNbfUcnhqkSMPsdeq+UAxIJmKekpNpC7HIpFUrJoVOYGvhs9Ufj6CCCTislBxWdV1sBn3YsozSMfk0SefhqSKosPrSjsDn7A56iWgcZZHdLk8T8CZYclVUyhCTZyltS4Zci/kEthtQp3VlzVtUW14oS+9kwahhNKOB9ZbeZ6eQpd0poBQRRdIHHUzfk5rjegQt4lqbz8ujaWzkhgGYcZQFVUaUJxGrsU1EIVJDVqHqxyuCmkdxIYpZvF4zYWVqYGAvLIiCHx33scIs2hqE6wg2ijrPYEl1lEqQX+5e/0UZbxIsCti1bKCqcj3/0P9+GbS/r8tR8SHw4JE1EniyPLIGjD9h5GKWrl4ir1wH/iBSu8q98J+j2TuysLtUMwcF2dZ/c5/b4QpRc/+5tf2rB1drqmBLb/37oXTssYj2qZvpLN6XdmWIw5ZWmXSsNv6T78RXJsNWau7rEKB45F5qwm98PKlxsj5F/aYq2r6a; 4:Yw5jrnBNGaLDIW6bnqWSJeTEjhwzXzOxCvYQJ9DKzMBAJi+YewEOA9DpWDnYoo7dKmM6fSYXeHhNGQqfKAeXuxP7KBRmQNKEh06recrXNRqZ3l1R7AXQCzevu95/e3k0a6m7nPCa8rfjuspzOUFqPia7wcH4Peav5MZS5C29DuvAbUlGw4i9JtlEcREs9o7BPR6obpMiXMW4hsh45NdZLKZ5CdcVdWAeetyTkPslGapq7PMmoWZ6ejeLvSnoscE4T7Arh2IpG6yve5OpQpO9ew== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231023)(944501075)(6055026)(6041268)(20161123564045)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011); SRVR:HE1PR05MB3212; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:HE1PR05MB3212; X-Forefront-PRVS: 0545EFAC9A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(346002)(396003)(376002)(39380400002)(199004)(189003)(43544003)(34206002)(478600001)(36756003)(5660300001)(2906002)(52116002)(305945005)(25786009)(50466002)(386003)(48376002)(7736002)(3846002)(21086003)(4326008)(6116002)(4720700003)(6666003)(450100002)(86362001)(97736004)(6636002)(7696005)(51416003)(316002)(106356001)(105586002)(2351001)(59450400001)(66066001)(2361001)(33026002)(53936002)(55016002)(69596002)(47776003)(68736007)(37006003)(16526018)(16586007)(8936002)(8676002)(50226002)(81166006)(81156014); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR05MB3212; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR05MB3212; 23:fHeugkCtqq/mmYkRzqAM/8kL4CCYV5u3ewg90HIy4?= =?us-ascii?Q?kLHEvaYQDrEGLawnx9ZoM8rHkHp+pqIxfjWTyRGQCMEL0oxBLYC9P92YCC59?= =?us-ascii?Q?ZW9/+ick0cMoOegY1yvnJlwT5fEnLkfOToHCdHiHe8SAqJAj4K+C2ty1Hy6T?= =?us-ascii?Q?a9CKb8EVDqROSD/gHdJ6DsvCH1wjgDnC5pLxyul5Egd+RXVT2SI55ALxLENm?= =?us-ascii?Q?etlf2G+X+QvXrWAxsoCboyprDNou23b4/Z+cp6nP79ogQis/SoCmsR16tHBV?= =?us-ascii?Q?mv3sZJVRpyjCPqiPmYlRG+dgp83SCu4n1iCiKzncvo1HB/UE+5WFEuCoRoSe?= =?us-ascii?Q?O+RzgbeO9qf+ok8VpEFrYhR6EIxQhprd9fh4ZlXjKIm+wNpp+iJ2RzOQ0pYA?= =?us-ascii?Q?wAJcNzhl+yjfnaabJdDWR08VGHIWC9dELfrKp9QVpLKX6p7gs43VGhOwRLAr?= =?us-ascii?Q?rVyQMjT+QgSzS9bTWXAGRnFq5menULROqViJ5dfwsetbL910uWtspoqmz9SM?= =?us-ascii?Q?djWODltSagM5bYXOELgqmsHMBBKJsT57UfLh5e6dPG4nN+ioRUbIRtv9TjNN?= =?us-ascii?Q?yh2PYy4FAyEJGRRnyrYm1BLG6YELgUCAgVDZUWe95yB6ZVeyDdzwd9e5/D4E?= =?us-ascii?Q?wJqaLRLTlDtY8+MV6ReMnRVonmpyeKBhYEeEiS33d3XrfgmzcPg7lp8ZjBRl?= =?us-ascii?Q?8luUT48plPKrl1ZMuHxbSgYiouusk5RQpg+Xu2EO2+sBldffke0Dm+6xTrO6?= =?us-ascii?Q?jukwyeOgQXKgi1tvYxwWkMsrHP7UzudXi3DUg0XbsXaJmir+FJAMd26+bg8T?= =?us-ascii?Q?IT6CujFx+Dos0dZ2z8ez7OtpU1B+hwKBdPrzauywfamqJfphFCzgysAQeoXm?= =?us-ascii?Q?ZvtI925pD8FkJ5VhA6Lc7zSr9uM73pvZFb9zdJzUrgf/Ju/3ijmW2MIt55Jt?= =?us-ascii?Q?JVFZBhmr8iPzVkrM1P37vPpwAaPgqfCTg1sCVsLrpuprNEtL1Qxan2sMKdxi?= =?us-ascii?Q?halcpHprt1xgFolZUhK5+jk4nx+J8wU+fCb2FmiZqm7ImY7ZPhwHFZId8YWa?= =?us-ascii?Q?dqnfj/nQZfr2Ar6Xqd/nFuuDnEnjAMtveY/XMI8RaXwcDKi2xPcpg63+NsDb?= =?us-ascii?Q?AcEULieVlEutk8iebRUBeGuPjxZrvLbIhMXYxwkUzQu6mh2jkU4V4ZhUOWR7?= =?us-ascii?Q?emnzildp6SypwtYU36ofzn0dGgMAFYxnfohn0wkScSefWdfponaZ1Jzes1ad?= =?us-ascii?Q?20j0cwlaoOwPRXlvAU=3D?= X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB3212; 6:hCk9m62ce/xbG9ibD4FYfVkeJ7kSBt88rXxEJQzZy/aHjKiyyq6e/iQ+JVNeJZTIQWx5vKC0vzcoCdtGvVCr/bTFMw442S88k/yUnh2hT7qKQLinr5hdkW4+WU36f6331kL/Wk7WIylav7vU+teqSm68ghWXmmnk8glraG5wKJNukUJlGgnLhx+wiK/ZbN/iERWZDvO+5TWEY2px08jDhvNr2gg2FBh87MKzCTwR1jpQ6RK5sGFio90ViwTBQc4b1kfkgphZkFWlzMsYRfTmYS79ennjNVi3s2n7MLtn1SFUOkd//LE7u/8/VD+gArofiMFEvdkddr3TvAqlg1sQYkBY5lhkl2QU7nLKZwCY5Ps=; 5:RA+Vunh9juagRvRp8LNYNeq37zUwKyB7CZ9+xL3nOg6TVTvd2EuqR3DlOfxz5IX5mFSUHXlgVRpIAs2PO0VK04HsoJ+VNwiq+0Lfm3OHKC8FyY91el7HRAjL/XuW7TvQwO0QNbXZ3T4l3SIt5lwxLUTzZGAfHkXG1qmgKgfUs+M=; 24:+/n+brRSP1g8kdKT3H7i35IhQarBKOJN1ZXH3jUh7fhWUf6bQMfYENfPgOlNm8lLydJgxkAJiW8HCPTZjJ9IqINHauZi/jGKNS/5xBIg0ac=; 7:AAm3A9vuQn0JX6M3+sIvNG2u8VK0dTZfLcS8dkxzMBEoOmkhRZ5zq7mamy+NqRtXGn355kTmuEu4shOAsYinUs2IVtRHA6N4TYdOXJOOBJlhOTbbz+ocNjTq+gdzRhbwBIDPKO+VCzZ6y/5lw1G5S2r0qlNFsj2DENay1XaCvUn8zAshmQw2gAwsUBntonoDei/n97ogf8/hPPH29dF6h4BQbTAYtEGBjpsuQgbQxAAdptT7juaKHkHwOu8uAKS0 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jan 2018 11:05:04.6462 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 86002f40-8d53-4383-da7f-08d555be81de X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB3212 Subject: [dpdk-dev] [PATCH] net/mlx4: fix no broadcasts reception in promisc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Jan 2018 11:05:09 -0000 This patch fixes the issue of mlx4 not receiving broadcast packets when configured to work promiscuous mode. Fixes: eacaac7bae36 ("net/mlx4: restore promisc and allmulti support") Cc: stable@dpdk.org Signed-off-by: Moti Haimovsky --- drivers/net/mlx4/mlx4_flow.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c index 69025da..ec13f5a 100644 --- a/drivers/net/mlx4/mlx4_flow.c +++ b/drivers/net/mlx4/mlx4_flow.c @@ -1223,9 +1223,12 @@ struct mlx4_drop { * * Various flow rules are created depending on the mode the device is in: * - * 1. Promiscuous: port MAC + catch-all (VLAN filtering is ignored). - * 2. All multicast: port MAC/VLAN + catch-all multicast. - * 3. Otherwise: port MAC/VLAN + broadcast MAC/VLAN. + * 1. Promiscuous: + * port MAC + broadcast + catch-all (VLAN filtering is ignored). + * 2. All multicast: + * port MAC/VLAN + broadcast + catch-all multicast. + * 3. Otherwise: + * port MAC/VLAN + broadcast MAC/VLAN. * * About MAC flow rules: * @@ -1304,9 +1307,6 @@ struct mlx4_drop { !priv->dev->data->promiscuous ? &vlan_spec.tci : NULL; - int broadcast = - !priv->dev->data->promiscuous && - !priv->dev->data->all_multicast; uint16_t vlan = 0; struct rte_flow *flow; unsigned int i; @@ -1340,7 +1340,7 @@ struct mlx4_drop { rule_vlan = NULL; } } - for (i = 0; i != RTE_DIM(priv->mac) + broadcast; ++i) { + for (i = 0; i != RTE_DIM(priv->mac) + 1; ++i) { const struct ether_addr *mac; /* Broadcasts are handled by an extra iteration. */ @@ -1404,7 +1404,7 @@ struct mlx4_drop { goto next_vlan; } /* Take care of promiscuous and all multicast flow rules. */ - if (!broadcast) { + if (priv->dev->data->promiscuous || priv->dev->data->all_multicast) { for (flow = LIST_FIRST(&priv->flows); flow && flow->internal; flow = LIST_NEXT(flow, next)) { -- 1.8.3.1