[dpdk-dev] [PATCH 0/2] Sync compilation with MUSDK-17.10

[dpdk-dev] [PATCH 0/2] Sync compilation with MUSDK-17.10

[Tomasz Duszynski]

This patchset comes with the following changes:

o MUSDK-17.10 is the latest version of the library. Since it brings
  improvements and fixes switch is necessary.

o Some minor updates to the documentation.

Tomasz Duszynski (2):
  crypto/mrvl: sync compilation with musdk-17.10
  crypto/mrvl: update MRVL CRYPTO PMD documentation

 doc/guides/cryptodevs/mrvl.rst        | 28 ++++------------------------
 doc/guides/nics/mrvl.rst              |  2 ++
 drivers/crypto/mrvl/Makefile          |  3 ++-
 drivers/crypto/mrvl/rte_mrvl_compat.h |  1 +
 4 files changed, 9 insertions(+), 25 deletions(-)

--
2.7.4

[dpdk-dev] [PATCH 1/2] crypto/mrvl: sync compilation with musdk-17.10

[Tomasz Duszynski]

With a new version of the musdk library it's no longer necessary to
explicitly define MVCONF_ARCH_DMA_ADDR_T_64BIT.

Proper defines are autogenerated by ./configure script based on
passed options and available after mv_autogen_comp_flags.h inclusion.

Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
---
 drivers/crypto/mrvl/Makefile          | 3 ++-
 drivers/crypto/mrvl/rte_mrvl_compat.h | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/crypto/mrvl/Makefile b/drivers/crypto/mrvl/Makefile
index 3532f7c..5515b40 100644
--- a/drivers/crypto/mrvl/Makefile
+++ b/drivers/crypto/mrvl/Makefile
@@ -47,7 +47,8 @@ LIB = librte_pmd_mrvl_crypto.a
 CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
 CFLAGS += -I$(LIBMUSDK_PATH)/include
-CFLAGS += -DMVCONF_ARCH_DMA_ADDR_T_64BIT
+CFLAGS += -DMVCONF_TYPES_PUBLIC
+CFLAGS += -DMVCONF_DMA_PHYS_ADDR_T_PUBLIC
 
 # library version
 LIBABIVER := 1
diff --git a/drivers/crypto/mrvl/rte_mrvl_compat.h b/drivers/crypto/mrvl/rte_mrvl_compat.h
index c29fa10..22cd184 100644
--- a/drivers/crypto/mrvl/rte_mrvl_compat.h
+++ b/drivers/crypto/mrvl/rte_mrvl_compat.h
@@ -43,6 +43,7 @@
 #ifdef container_of
 #undef container_of
 #endif
+#include "env/mv_autogen_comp_flags.h"
 #include "drivers/mv_sam.h"
 #include "drivers/mv_sam_cio.h"
 #include "drivers/mv_sam_session.h"
-- 
2.7.4

[dpdk-dev] [PATCH 2/2] crypto/mrvl: update MRVL CRYPTO PMD documentation

[Tomasz Duszynski]

Update MRVL CRYPTO PMD documentation.

Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
---
 doc/guides/cryptodevs/mrvl.rst | 28 ++++------------------------
 doc/guides/nics/mrvl.rst       |  2 ++
 2 files changed, 6 insertions(+), 24 deletions(-)

diff --git a/doc/guides/cryptodevs/mrvl.rst b/doc/guides/cryptodevs/mrvl.rst
index 4e992fb..4024801 100644
--- a/doc/guides/cryptodevs/mrvl.rst
+++ b/doc/guides/cryptodevs/mrvl.rst
@@ -70,13 +70,6 @@ Limitations
 * Hardware only supports scenarios where ICV (digest buffer) is placed just
   after the authenticated data. Other placement will result in error.
 
-* Before running crypto test suite it is advised to increase limit of
-  opened files:
-
-  .. code-block:: console
-
-     ulimit -n 20000
-
 Installation
 ------------
 
@@ -92,20 +85,11 @@ Currently there are two driver specific compilation options in
 
     Toggle display of debugging messages.
 
-During compilation external MUSDK library, which provides direct access
-to Marvell's EIP197 cryptographic engine, is necessary. Library sources are
-available `here <https://github.com/MarvellEmbeddedProcessors/musdk-marvell/tree/musdk-armada-17.08>`__.
+For a list of prerequisites please refer to `Prerequisites` section in
+:ref:`MRVL Poll Mode Driver <mrvl_poll_mode_driver>` guide.
 
-Alternatively, prebuilt library can be downloaded from
-`Marvell Extranet <https://extranet.marvell.com>`_. Once approval has been
-granted, library can be found by typing ``musdk`` in the search box.
-
-For MUSDK library build instructions please refer to ``doc/musdk_get_started.txt``
-in library sources directory.
-
-MUSDK requires out of tree kernel modules to work. Kernel tree needed to build
-them is available
-`here <https://github.com/MarvellEmbeddedProcessors/linux-marvell/tree/linux-4.4.52-armada-17.08>`__.
+For `crypto_safexcel.ko` module build instructions please refer
+to `doc/musdk_get_started.txt`.
 
 Initialization
 --------------
@@ -121,10 +105,6 @@ loaded:
    insmod mv_sam_uio.ko
    insmod crypto_safexcel.ko
 
-- `musdk_uio.ko`, `mv_pp2_uio.ko` and `mv_sam_uio.ko` are distributed together with MUSDK library.
-- `crypto_safexcel.ko` is an in-kernel module.
-- `mvpp2x_sysfs.ko` can be build from sources available `here <https://github.com/MarvellEmbeddedProcessors/mvpp2x-marvell/tree/mvpp2x-armada-17.08>`__.
-
 The following parameters (all optional) are exported by the driver:
 
 * max_nb_queue_pairs: maximum number of queue pairs in the device (8 by default).
diff --git a/doc/guides/nics/mrvl.rst b/doc/guides/nics/mrvl.rst
index 67b254c..892097d 100644
--- a/doc/guides/nics/mrvl.rst
+++ b/doc/guides/nics/mrvl.rst
@@ -29,6 +29,8 @@
     (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
     OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
+.. _mrvl_poll_mode_driver:
+
 MRVL Poll Mode Driver
 ======================
 
-- 
2.7.4

Re: [dpdk-dev] [PATCH 0/2] Sync compilation with MUSDK-17.10

[Jianbo Liu]

The 11/30/2017 14:32, Tomasz Duszynski wrote:
> This patchset comes with the following changes:
>
> o MUSDK-17.10 is the latest version of the library. Since it brings
>   improvements and fixes switch is necessary.
>
> o Some minor updates to the documentation.
>
> Tomasz Duszynski (2):
>   crypto/mrvl: sync compilation with musdk-17.10
>   crypto/mrvl: update MRVL CRYPTO PMD documentation
>
>  doc/guides/cryptodevs/mrvl.rst        | 28 ++++------------------------
>  doc/guides/nics/mrvl.rst              |  2 ++
>  drivers/crypto/mrvl/Makefile          |  3 ++-
>  drivers/crypto/mrvl/rte_mrvl_compat.h |  1 +
>  4 files changed, 9 insertions(+), 25 deletions(-)
>
> --
> 2.7.4
>

Acked-by: Jianbo Liu <jianbo.liu@arm.com>


--
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Re: [dpdk-dev] [PATCH 2/2] crypto/mrvl: update MRVL CRYPTO PMD documentation

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Duszynski
> Sent: Thursday, November 30, 2017 1:33 PM
> To: dev@dpdk.org
> Cc: mw@semihalf.com; jck@semihalf.com; dima@marvell.com;
> nsamsono@marvell.com; jianbo.liu@arm.com; Tomasz Duszynski
> <tdu@semihalf.com>
> Subject: [dpdk-dev] [PATCH 2/2] crypto/mrvl: update MRVL CRYPTO PMD
> documentation
> 
> Update MRVL CRYPTO PMD documentation.
> 
> Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>


This is depending on the network driver update, right?
You should say it in the cover letter. I will wait until it is applied then.

...

> -
>  Installation
>  ------------
> 
> @@ -92,20 +85,11 @@ Currently there are two driver specific compilation
> options in
> 
>      Toggle display of debugging messages.
> 
> -During compilation external MUSDK library, which provides direct access -
> to Marvell's EIP197 cryptographic engine, is necessary. Library sources are -
> available `here <https://github.com/MarvellEmbeddedProcessors/musdk-
> marvell/tree/musdk-armada-17.08>`__.
> +For a list of prerequisites please refer to `Prerequisites` section in
> +:ref:`MRVL Poll Mode Driver <mrvl_poll_mode_driver>` guide.

Maybe say that it is the network PMD?

Thanks,
Pablo

Re: [dpdk-dev] [PATCH 2/2] crypto/mrvl: update MRVL CRYPTO PMD documentation

[Tomasz Duszynski]

On Mon, Dec 11, 2017 at 12:44:43PM +0000, De Lara Guarch, Pablo wrote:
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Duszynski
> > Sent: Thursday, November 30, 2017 1:33 PM
> > To: dev@dpdk.org
> > Cc: mw@semihalf.com; jck@semihalf.com; dima@marvell.com;
> > nsamsono@marvell.com; jianbo.liu@arm.com; Tomasz Duszynski
> > <tdu@semihalf.com>
> > Subject: [dpdk-dev] [PATCH 2/2] crypto/mrvl: update MRVL CRYPTO PMD
> > documentation
> >
> > Update MRVL CRYPTO PMD documentation.
> >
> > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
>
>
> This is depending on the network driver update, right?
> You should say it in the cover letter. I will wait until it is applied then.

Right, I've missed that. Anyway, from what I see network driver
patches have been already applied.

>
> ...
>
> > -
> >  Installation
> >  ------------
> >
> > @@ -92,20 +85,11 @@ Currently there are two driver specific compilation
> > options in
> >
> >      Toggle display of debugging messages.
> >
> > -During compilation external MUSDK library, which provides direct access -
> > to Marvell's EIP197 cryptographic engine, is necessary. Library sources are -
> > available `here <https://github.com/MarvellEmbeddedProcessors/musdk-
> > marvell/tree/musdk-armada-17.08>`__.
> > +For a list of prerequisites please refer to `Prerequisites` section in
> > +:ref:`MRVL Poll Mode Driver <mrvl_poll_mode_driver>` guide.
>
> Maybe say that it is the network PMD?

OK. I'll send v2 then.

>
> Thanks,
> Pablo
>

--
- Tomasz Duszyński

[dpdk-dev] [PATCH v2 0/2] Sync compilation with MUSDK-17.10

[Tomasz Duszynski]

This patchset comes with the following changes:

o MUSDK-17.10 is the latest version of the library. Since it brings
  improvements and fixes switch is necessary.

o Some minor updates to the documentation.

Note that this series should be applied after net pmd patch series.

Changes since v1:
- Rename net pmd doc reference.

Tomasz Duszynski (2):
  crypto/mrvl: sync compilation with musdk-17.10
  crypto/mrvl: update MRVL CRYPTO PMD documentation


 doc/guides/cryptodevs/mrvl.rst        | 28 ++++------------------------
 doc/guides/nics/mrvl.rst              |  2 ++
 drivers/crypto/mrvl/Makefile          |  3 ++-
 drivers/crypto/mrvl/rte_mrvl_compat.h |  1 +
 4 files changed, 9 insertions(+), 25 deletions(-)

--
2.7.4

[dpdk-dev] [PATCH v2 1/2] crypto/mrvl: sync compilation with musdk-17.10

[Tomasz Duszynski]

With a new version of the musdk library it's no longer necessary to
explicitly define MVCONF_ARCH_DMA_ADDR_T_64BIT.

Proper defines are autogenerated by ./configure script based on
passed options and available after mv_autogen_comp_flags.h inclusion.

Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
Acked-by: Jianbo Liu <jianbo.liu@arm.com>
---
 drivers/crypto/mrvl/Makefile          | 3 ++-
 drivers/crypto/mrvl/rte_mrvl_compat.h | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/crypto/mrvl/Makefile b/drivers/crypto/mrvl/Makefile
index 3532f7c..5515b40 100644
--- a/drivers/crypto/mrvl/Makefile
+++ b/drivers/crypto/mrvl/Makefile
@@ -47,7 +47,8 @@ LIB = librte_pmd_mrvl_crypto.a
 CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
 CFLAGS += -I$(LIBMUSDK_PATH)/include
-CFLAGS += -DMVCONF_ARCH_DMA_ADDR_T_64BIT
+CFLAGS += -DMVCONF_TYPES_PUBLIC
+CFLAGS += -DMVCONF_DMA_PHYS_ADDR_T_PUBLIC

 # library version
 LIBABIVER := 1
diff --git a/drivers/crypto/mrvl/rte_mrvl_compat.h b/drivers/crypto/mrvl/rte_mrvl_compat.h
index c29fa10..22cd184 100644
--- a/drivers/crypto/mrvl/rte_mrvl_compat.h
+++ b/drivers/crypto/mrvl/rte_mrvl_compat.h
@@ -43,6 +43,7 @@
 #ifdef container_of
 #undef container_of
 #endif
+#include "env/mv_autogen_comp_flags.h"
 #include "drivers/mv_sam.h"
 #include "drivers/mv_sam_cio.h"
 #include "drivers/mv_sam_session.h"
--
2.7.4

[dpdk-dev] [PATCH v2 2/2] crypto/mrvl: update MRVL CRYPTO PMD documentation

[Tomasz Duszynski]

Update MRVL CRYPTO PMD documentation.

Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
Acked-by: Jianbo Liu <jianbo.liu@arm.com>
---
 doc/guides/cryptodevs/mrvl.rst | 28 ++++------------------------
 doc/guides/nics/mrvl.rst       |  2 ++
 2 files changed, 6 insertions(+), 24 deletions(-)

diff --git a/doc/guides/cryptodevs/mrvl.rst b/doc/guides/cryptodevs/mrvl.rst
index 4e992fb..22a48e4 100644
--- a/doc/guides/cryptodevs/mrvl.rst
+++ b/doc/guides/cryptodevs/mrvl.rst
@@ -70,13 +70,6 @@ Limitations
 * Hardware only supports scenarios where ICV (digest buffer) is placed just
   after the authenticated data. Other placement will result in error.

-* Before running crypto test suite it is advised to increase limit of
-  opened files:
-
-  .. code-block:: console
-
-     ulimit -n 20000
-
 Installation
 ------------

@@ -92,20 +85,11 @@ Currently there are two driver specific compilation options in

     Toggle display of debugging messages.

-During compilation external MUSDK library, which provides direct access
-to Marvell's EIP197 cryptographic engine, is necessary. Library sources are
-available `here <https://github.com/MarvellEmbeddedProcessors/musdk-marvell/tree/musdk-armada-17.08>`__.
+For a list of prerequisites please refer to `Prerequisites` section in
+:ref:`MRVL NET Poll Mode Driver <mrvl_poll_mode_driver>` guide.

-Alternatively, prebuilt library can be downloaded from
-`Marvell Extranet <https://extranet.marvell.com>`_. Once approval has been
-granted, library can be found by typing ``musdk`` in the search box.
-
-For MUSDK library build instructions please refer to ``doc/musdk_get_started.txt``
-in library sources directory.
-
-MUSDK requires out of tree kernel modules to work. Kernel tree needed to build
-them is available
-`here <https://github.com/MarvellEmbeddedProcessors/linux-marvell/tree/linux-4.4.52-armada-17.08>`__.
+For `crypto_safexcel.ko` module build instructions please refer
+to `doc/musdk_get_started.txt`.

 Initialization
 --------------
@@ -121,10 +105,6 @@ loaded:
    insmod mv_sam_uio.ko
    insmod crypto_safexcel.ko

-- `musdk_uio.ko`, `mv_pp2_uio.ko` and `mv_sam_uio.ko` are distributed together with MUSDK library.
-- `crypto_safexcel.ko` is an in-kernel module.
-- `mvpp2x_sysfs.ko` can be build from sources available `here <https://github.com/MarvellEmbeddedProcessors/mvpp2x-marvell/tree/mvpp2x-armada-17.08>`__.
-
 The following parameters (all optional) are exported by the driver:

 * max_nb_queue_pairs: maximum number of queue pairs in the device (8 by default).
diff --git a/doc/guides/nics/mrvl.rst b/doc/guides/nics/mrvl.rst
index 67b254c..892097d 100644
--- a/doc/guides/nics/mrvl.rst
+++ b/doc/guides/nics/mrvl.rst
@@ -29,6 +29,8 @@
     (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
     OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

+.. _mrvl_poll_mode_driver:
+
 MRVL Poll Mode Driver
 ======================

--
2.7.4

Re: [dpdk-dev] [PATCH v2 1/2] crypto/mrvl: sync compilation with musdk-17.10

[Tomasz Duszynski]

On Mon, Dec 11, 2017 at 03:07:02PM +0100, Tomasz Duszynski wrote:
> With a new version of the musdk library it's no longer necessary to
> explicitly define MVCONF_ARCH_DMA_ADDR_T_64BIT.
>
> Proper defines are autogenerated by ./configure script based on
> passed options and available after mv_autogen_comp_flags.h inclusion.
>
> Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> Acked-by: Jianbo Liu <jianbo.liu@arm.com>
> ---
>  drivers/crypto/mrvl/Makefile          | 3 ++-
>  drivers/crypto/mrvl/rte_mrvl_compat.h | 1 +
>  2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/mrvl/Makefile b/drivers/crypto/mrvl/Makefile
> index 3532f7c..5515b40 100644
> --- a/drivers/crypto/mrvl/Makefile
> +++ b/drivers/crypto/mrvl/Makefile
> @@ -47,7 +47,8 @@ LIB = librte_pmd_mrvl_crypto.a
>  CFLAGS += -O3
>  CFLAGS += $(WERROR_FLAGS)
>  CFLAGS += -I$(LIBMUSDK_PATH)/include
> -CFLAGS += -DMVCONF_ARCH_DMA_ADDR_T_64BIT
> +CFLAGS += -DMVCONF_TYPES_PUBLIC
> +CFLAGS += -DMVCONF_DMA_PHYS_ADDR_T_PUBLIC
>
>  # library version
>  LIBABIVER := 1
> diff --git a/drivers/crypto/mrvl/rte_mrvl_compat.h b/drivers/crypto/mrvl/rte_mrvl_compat.h
> index c29fa10..22cd184 100644
> --- a/drivers/crypto/mrvl/rte_mrvl_compat.h
> +++ b/drivers/crypto/mrvl/rte_mrvl_compat.h
> @@ -43,6 +43,7 @@
>  #ifdef container_of
>  #undef container_of
>  #endif
> +#include "env/mv_autogen_comp_flags.h"
>  #include "drivers/mv_sam.h"
>  #include "drivers/mv_sam_cio.h"
>  #include "drivers/mv_sam_session.h"
> --
> 2.7.4
>

This patch has been available here for some time already and it looks it
has not been picked up yet. Should I respin the series?

--
- Tomasz Duszyński

Re: [dpdk-dev] [PATCH v2 1/2] crypto/mrvl: sync compilation with musdk-17.10

[De Lara Guarch, Pablo]

Hi Tomasz,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Duszynski
> Sent: Monday, January 8, 2018 2:28 PM
> To: dev@dpdk.org
> Cc: mw@semihalf.com; jck@semihalf.com; dima@marvell.com;
> nsamsono@marvell.com; jianbo.liu@arm.com; Tomasz Duszynski
> <tdu@semihalf.com>
> Subject: Re: [dpdk-dev] [PATCH v2 1/2] crypto/mrvl: sync compilation with
> musdk-17.10
> 
> On Mon, Dec 11, 2017 at 03:07:02PM +0100, Tomasz Duszynski wrote:
> > With a new version of the musdk library it's no longer necessary to
> > explicitly define MVCONF_ARCH_DMA_ADDR_T_64BIT.
> >
> > Proper defines are autogenerated by ./configure script based on passed
> > options and available after mv_autogen_comp_flags.h inclusion.
> >
> > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> > Acked-by: Jianbo Liu <jianbo.liu@arm.com>
> > ---
> >  drivers/crypto/mrvl/Makefile          | 3 ++-
> >  drivers/crypto/mrvl/rte_mrvl_compat.h | 1 +
> >  2 files changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/crypto/mrvl/Makefile
> > b/drivers/crypto/mrvl/Makefile index 3532f7c..5515b40 100644
> > --- a/drivers/crypto/mrvl/Makefile
> > +++ b/drivers/crypto/mrvl/Makefile
> > @@ -47,7 +47,8 @@ LIB = librte_pmd_mrvl_crypto.a  CFLAGS += -O3
> > CFLAGS += $(WERROR_FLAGS)  CFLAGS += -I$(LIBMUSDK_PATH)/include
> > -CFLAGS += -DMVCONF_ARCH_DMA_ADDR_T_64BIT
> > +CFLAGS += -DMVCONF_TYPES_PUBLIC
> > +CFLAGS += -DMVCONF_DMA_PHYS_ADDR_T_PUBLIC
> >
> >  # library version
> >  LIBABIVER := 1
> > diff --git a/drivers/crypto/mrvl/rte_mrvl_compat.h
> > b/drivers/crypto/mrvl/rte_mrvl_compat.h
> > index c29fa10..22cd184 100644
> > --- a/drivers/crypto/mrvl/rte_mrvl_compat.h
> > +++ b/drivers/crypto/mrvl/rte_mrvl_compat.h
> > @@ -43,6 +43,7 @@
> >  #ifdef container_of
> >  #undef container_of
> >  #endif
> > +#include "env/mv_autogen_comp_flags.h"
> >  #include "drivers/mv_sam.h"
> >  #include "drivers/mv_sam_cio.h"
> >  #include "drivers/mv_sam_session.h"
> > --
> > 2.7.4
> >
> 
> This patch has been available here for some time already and it looks it has
> not been picked up yet. Should I respin the series?

Sorry, I missed this. I was waiting for the network driver patches to be applied, which are now.

Will merge soon.

Pablo

> 
> --
> - Tomasz Duszyński

Re: [dpdk-dev] [PATCH v2 1/2] crypto/mrvl: sync compilation with musdk-17.10

[Tomasz Duszynski]

On Mon, Jan 08, 2018 at 02:41:30PM +0000, De Lara Guarch, Pablo wrote:
> Hi Tomasz,
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Duszynski
> > Sent: Monday, January 8, 2018 2:28 PM
> > To: dev@dpdk.org
> > Cc: mw@semihalf.com; jck@semihalf.com; dima@marvell.com;
> > nsamsono@marvell.com; jianbo.liu@arm.com; Tomasz Duszynski
> > <tdu@semihalf.com>
> > Subject: Re: [dpdk-dev] [PATCH v2 1/2] crypto/mrvl: sync compilation with
> > musdk-17.10
> >
> > On Mon, Dec 11, 2017 at 03:07:02PM +0100, Tomasz Duszynski wrote:
> > > With a new version of the musdk library it's no longer necessary to
> > > explicitly define MVCONF_ARCH_DMA_ADDR_T_64BIT.
> > >
> > > Proper defines are autogenerated by ./configure script based on passed
> > > options and available after mv_autogen_comp_flags.h inclusion.
> > >
> > > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> > > Acked-by: Jianbo Liu <jianbo.liu@arm.com>
> > > ---
> > >  drivers/crypto/mrvl/Makefile          | 3 ++-
> > >  drivers/crypto/mrvl/rte_mrvl_compat.h | 1 +
> > >  2 files changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/crypto/mrvl/Makefile
> > > b/drivers/crypto/mrvl/Makefile index 3532f7c..5515b40 100644
> > > --- a/drivers/crypto/mrvl/Makefile
> > > +++ b/drivers/crypto/mrvl/Makefile
> > > @@ -47,7 +47,8 @@ LIB = librte_pmd_mrvl_crypto.a  CFLAGS += -O3
> > > CFLAGS += $(WERROR_FLAGS)  CFLAGS += -I$(LIBMUSDK_PATH)/include
> > > -CFLAGS += -DMVCONF_ARCH_DMA_ADDR_T_64BIT
> > > +CFLAGS += -DMVCONF_TYPES_PUBLIC
> > > +CFLAGS += -DMVCONF_DMA_PHYS_ADDR_T_PUBLIC
> > >
> > >  # library version
> > >  LIBABIVER := 1
> > > diff --git a/drivers/crypto/mrvl/rte_mrvl_compat.h
> > > b/drivers/crypto/mrvl/rte_mrvl_compat.h
> > > index c29fa10..22cd184 100644
> > > --- a/drivers/crypto/mrvl/rte_mrvl_compat.h
> > > +++ b/drivers/crypto/mrvl/rte_mrvl_compat.h
> > > @@ -43,6 +43,7 @@
> > >  #ifdef container_of
> > >  #undef container_of
> > >  #endif
> > > +#include "env/mv_autogen_comp_flags.h"
> > >  #include "drivers/mv_sam.h"
> > >  #include "drivers/mv_sam_cio.h"
> > >  #include "drivers/mv_sam_session.h"
> > > --
> > > 2.7.4
> > >
> >
> > This patch has been available here for some time already and it looks it has
> > not been picked up yet. Should I respin the series?
>
> Sorry, I missed this. I was waiting for the network driver patches to be applied, which are now.
>
> Will merge soon.
>
> Pablo
>

No problem, thanks.

--
- Tomasz Duszyński

[dpdk-dev] [PATCH v3 1/2] crypto/mrvl: sync compilation with musdk-17.10

[Tomasz Duszynski]

With a new version of the musdk library it's no longer necessary to
explicitly define MVCONF_ARCH_DMA_ADDR_T_64BIT.

Proper defines are autogenerated by ./configure script based on
passed options and available after mv_autogen_comp_flags.h inclusion.

Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
Acked-by: Jianbo Liu <jianbo.liu@arm.com>
---
 v2:
  * Mention required MUSDK compilation option

 drivers/crypto/mrvl/Makefile          | 3 ++-
 drivers/crypto/mrvl/rte_mrvl_compat.h | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/crypto/mrvl/Makefile b/drivers/crypto/mrvl/Makefile
index 3532f7c..5515b40 100644
--- a/drivers/crypto/mrvl/Makefile
+++ b/drivers/crypto/mrvl/Makefile
@@ -47,7 +47,8 @@ LIB = librte_pmd_mrvl_crypto.a
 CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
 CFLAGS += -I$(LIBMUSDK_PATH)/include
-CFLAGS += -DMVCONF_ARCH_DMA_ADDR_T_64BIT
+CFLAGS += -DMVCONF_TYPES_PUBLIC
+CFLAGS += -DMVCONF_DMA_PHYS_ADDR_T_PUBLIC

 # library version
 LIBABIVER := 1
diff --git a/drivers/crypto/mrvl/rte_mrvl_compat.h b/drivers/crypto/mrvl/rte_mrvl_compat.h
index c29fa10..22cd184 100644
--- a/drivers/crypto/mrvl/rte_mrvl_compat.h
+++ b/drivers/crypto/mrvl/rte_mrvl_compat.h
@@ -43,6 +43,7 @@
 #ifdef container_of
 #undef container_of
 #endif
+#include "env/mv_autogen_comp_flags.h"
 #include "drivers/mv_sam.h"
 #include "drivers/mv_sam_cio.h"
 #include "drivers/mv_sam_session.h"
--
2.7.4

[dpdk-dev] [PATCH v3 2/2] crypto/mrvl: update MRVL CRYPTO PMD documentation

[Tomasz Duszynski]

Update MRVL CRYPTO PMD documentation.

Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
Acked-by: Jianbo Liu <jianbo.liu@arm.com>
---
 doc/guides/cryptodevs/mrvl.rst | 31 +++++++++----------------------
 doc/guides/nics/mrvl.rst       |  2 ++
 2 files changed, 11 insertions(+), 22 deletions(-)

diff --git a/doc/guides/cryptodevs/mrvl.rst b/doc/guides/cryptodevs/mrvl.rst
index 4e992fb..6a0b08c 100644
--- a/doc/guides/cryptodevs/mrvl.rst
+++ b/doc/guides/cryptodevs/mrvl.rst
@@ -70,13 +70,6 @@ Limitations
 * Hardware only supports scenarios where ICV (digest buffer) is placed just
   after the authenticated data. Other placement will result in error.

-* Before running crypto test suite it is advised to increase limit of
-  opened files:
-
-  .. code-block:: console
-
-     ulimit -n 20000
-
 Installation
 ------------

@@ -92,20 +85,18 @@ Currently there are two driver specific compilation options in

     Toggle display of debugging messages.

-During compilation external MUSDK library, which provides direct access
-to Marvell's EIP197 cryptographic engine, is necessary. Library sources are
-available `here <https://github.com/MarvellEmbeddedProcessors/musdk-marvell/tree/musdk-armada-17.08>`__.
+For a list of prerequisites please refer to `Prerequisites` section in
+:ref:`MRVL Poll Mode Driver <mrvl_poll_mode_driver>` guide.

-Alternatively, prebuilt library can be downloaded from
-`Marvell Extranet <https://extranet.marvell.com>`_. Once approval has been
-granted, library can be found by typing ``musdk`` in the search box.
+MRVL CRYPTO PMD requires MUSDK built with EIP197 support thus following
+extra option must be passed to the library configuration script:

-For MUSDK library build instructions please refer to ``doc/musdk_get_started.txt``
-in library sources directory.
+.. code-block:: console
+
+   --enable-sam

-MUSDK requires out of tree kernel modules to work. Kernel tree needed to build
-them is available
-`here <https://github.com/MarvellEmbeddedProcessors/linux-marvell/tree/linux-4.4.52-armada-17.08>`__.
+For `crypto_safexcel.ko` module build instructions please refer
+to `doc/musdk_get_started.txt`.

 Initialization
 --------------
@@ -121,10 +112,6 @@ loaded:
    insmod mv_sam_uio.ko
    insmod crypto_safexcel.ko

-- `musdk_uio.ko`, `mv_pp2_uio.ko` and `mv_sam_uio.ko` are distributed together with MUSDK library.
-- `crypto_safexcel.ko` is an in-kernel module.
-- `mvpp2x_sysfs.ko` can be build from sources available `here <https://github.com/MarvellEmbeddedProcessors/mvpp2x-marvell/tree/mvpp2x-armada-17.08>`__.
-
 The following parameters (all optional) are exported by the driver:

 * max_nb_queue_pairs: maximum number of queue pairs in the device (8 by default).
diff --git a/doc/guides/nics/mrvl.rst b/doc/guides/nics/mrvl.rst
index 4dc4710..468cebd 100644
--- a/doc/guides/nics/mrvl.rst
+++ b/doc/guides/nics/mrvl.rst
@@ -29,6 +29,8 @@
     (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
     OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

+.. _mrvl_poll_mode_driver:
+
 MRVL Poll Mode Driver
 ======================

--
2.7.4

Re: [dpdk-dev] [PATCH v3 1/2] crypto/mrvl: sync compilation with musdk-17.10

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Duszynski
> Sent: Tuesday, January 9, 2018 9:09 AM
> To: dev@dpdk.org
> Cc: mw@semihalf.com; dima@marvell.com; nsamsono@marvell.com;
> jianbo.liu@arm.com; Tomasz Duszynski <tdu@semihalf.com>
> Subject: [dpdk-dev] [PATCH v3 1/2] crypto/mrvl: sync compilation with
> musdk-17.10
> 
> With a new version of the musdk library it's no longer necessary to
> explicitly define MVCONF_ARCH_DMA_ADDR_T_64BIT.
> 
> Proper defines are autogenerated by ./configure script based on passed
> options and available after mv_autogen_comp_flags.h inclusion.
> 
> Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> Acked-by: Jianbo Liu <jianbo.liu@arm.com>

Applied to dpdk-next-crypto.
Thanks,

Pablo

Re: [dpdk-dev] [PATCH v3 2/2] crypto/mrvl: update MRVL CRYPTO PMD documentation

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Duszynski
> Sent: Tuesday, January 9, 2018 9:09 AM
> To: dev@dpdk.org
> Cc: mw@semihalf.com; dima@marvell.com; nsamsono@marvell.com;
> jianbo.liu@arm.com; Tomasz Duszynski <tdu@semihalf.com>
> Subject: [dpdk-dev] [PATCH v3 2/2] crypto/mrvl: update MRVL CRYPTO
> PMD documentation
> 
> Update MRVL CRYPTO PMD documentation.
> 
> Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> Acked-by: Jianbo Liu <jianbo.liu@arm.com>

Applied to dpdk-next-crypto.
Thanks,

Pablo

Re: [dpdk-dev] [PATCH v3 1/2] crypto/mrvl: sync compilation with musdk-17.10

[Ferruh Yigit]

On 1/9/2018 11:47 AM, De Lara Guarch, Pablo wrote:
> 
> 
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Duszynski
>> Sent: Tuesday, January 9, 2018 9:09 AM
>> To: dev@dpdk.org
>> Cc: mw@semihalf.com; dima@marvell.com; nsamsono@marvell.com;
>> jianbo.liu@arm.com; Tomasz Duszynski <tdu@semihalf.com>
>> Subject: [dpdk-dev] [PATCH v3 1/2] crypto/mrvl: sync compilation with
>> musdk-17.10
>>
>> With a new version of the musdk library it's no longer necessary to
>> explicitly define MVCONF_ARCH_DMA_ADDR_T_64BIT.
>>
>> Proper defines are autogenerated by ./configure script based on passed
>> options and available after mv_autogen_comp_flags.h inclusion.
>>
>> Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
>> Acked-by: Jianbo Liu <jianbo.liu@arm.com>
> 
> Applied to dpdk-next-crypto.

Hi Pablo,

Would you be OK if I get this specific patch to the next-net? And merge with net
counterpart of it [1].

Because when net and crypto versions are separate patches, one of them is
causing build error for a specific version of musdk.
When musdk version is updated, both net and crypto should be updated atomically
for that new version.

[1]
https://dpdk.org/dev/patchwork/patch/31927/

> Thanks,
> 
> Pablo
>