From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20066.outbound.protection.outlook.com [40.107.2.66]) by dpdk.org (Postfix) with ESMTP id 9DCEF1B1B6; Tue, 9 Jan 2018 15:47:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=zBgTwn9Hmn1TpzNPIYd4D+90AWaW8ni8808kfyRu8EA=; b=mQXQ6nMjQtv7RDlP504nB/SGCFZdGJOakYgTIPXBZxvk/weUiUYA3bYUqY/A6wrTV12o3FnOYVuCWMwea9HskS4AnGCDDZYRx/VQTxxEtt3xNzWLdS//YyHtpnSNn3DMIhWWO9+iBjfs+HlEsKIhkvfDv3cFxosSNs10skE9rg8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; Received: from mellanox.com (37.142.13.130) by AM6PR0502MB3799.eurprd05.prod.outlook.com (2603:10a6:209:a::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.386.5; Tue, 9 Jan 2018 14:47:54 +0000 From: Matan Azrad To: Ferruh Yigit Cc: Thomas Monjalon , dev@dpdk.org, stephen@networkplumber.org, Adrien Mazarguil , stable@dpdk.org, Gaetan Rivet Date: Tue, 9 Jan 2018 14:47:26 +0000 Message-Id: <1515509253-17834-2-git-send-email-matan@mellanox.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1515509253-17834-1-git-send-email-matan@mellanox.com> References: <20171222173846.20731-1-adrien.mazarguil@6wind.com> <1515509253-17834-1-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: HE1P191CA0006.EURP191.PROD.OUTLOOK.COM (2603:10a6:3:cf::16) To AM6PR0502MB3799.eurprd05.prod.outlook.com (2603:10a6:209:a::28) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 27534fa3-e265-4965-e307-08d5576ff81f X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:AM6PR0502MB3799; X-Microsoft-Exchange-Diagnostics: 1; AM6PR0502MB3799; 3:cVxdrg7aimT8js8EvnhTgKPQdiN6pfwRu35g6TxTNOKwo534di9rEz8sKQIlE6r/3FliLwN7KuUT21J1NG7adxft8xTYUkvDnpoobt6vrNi9Zu4PftWYufeHFSsn0AGXJip9P4BP2HYtQsJo3n5GNb+aHE/lUUNCjwNvpqSAgf/XmeBZFQwfOCQf/zKHOy6/P0SpmQodyLbx1VHn5nAwYsRGutkLrEdfn0e88vaVWzwrfrFt9NYh3pcmJk7Z9X8m; 25:fySpdyh6IfD9JkLJqQK8H4QCI5AKrSmmSjKShjAE0jvwp63Qu/CAQPX4U8/+bVXv3pvqzT0DGe4yplefH6ZwV+0bw/+e88nc9RmtHEGlpW+pPawENK1CgwbbynrZYPP6rZbzPC48I3ViyCHaq7z1bAT85VqQwzF7gH3+ra953Wi2OITlVjXPtZySw9xNWsjAnXcGEGDiJXTlrstLF0wImMsIDMzuaaAyzoIy6ZLFlANWU8M51/J+d/+jrgnzZ6R0zSQheUYs9gHDY6po4JIpyng6MGfluQUzr+zgmET8JJpgIDlVRlkGO7ykDoQ890d4N6cTFoVuGNdTTyi1fC19+Q==; 31:0LTS2QcLgZkctlLd2BCOePVg3KAUR/zUijj6yJaLbz10zE7eAgIKNZ+LZWLp31GEHJbHWqxiix7Bs8Hc+DSp+bwmlsJyODddi1fKCUw5DpHNPzYNZA1tejY/CUsPN+7n86y6oj8xNkaueXyMzYiAxVym96NrpXJqc05l1aJKyRak06QKl6fsibn9ZVeAgi1YzeRxsZpZVYJnPYeH2wNzbcgumyQ4+xz3pFT2xMjIR3c= X-MS-TrafficTypeDiagnostic: AM6PR0502MB3799: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; AM6PR0502MB3799; 20:TWf9tSz7osNuRt1HPNgagcRrVYxQ6ubQIeB90kKDIx0R2oKejnS+YVfe7aVL+MB5ws8DhTL8T91/3mq81X5j9NwcmsLbmSZMyVgRKDzrTuN4sq9fEoggcudM+HBfFJFKhapESYkjRZsZxy608HVT5yaSWI2G4Fx4xpmlIuVlqDCA4mwIuWe8OBxhWs/i/VtuiVKTgNGL4qV01JqYQIyT3HurgD4T7aBrrcQKmJij+JngNg+G+V2h6H2nl9M6W1gOydZGTTYhYyokQjHUF/r4wOnojvLcXwCp+nUoa2UBmWPnMpTtGc2a+GHILtWNgcJFb4e/ApK3BjFJw8xOUKSUxZ0+C9reg8nmpCuugA+YLrIqZ7YQXpEG86WWHGOA0lY1r7r0bg09Ef5yCCwY2OpN+YUb/oEQkYtKYo8zcjpgnTRYA36RhLm5oQrWqRg2sPWqNETgAZC4j6tiri9UrJZJnT+do/k85WR6SKBkPAeNvAqEUgPu8VZZAoV/Fz2y+BRX; 4:Z/DiOz/WGG8nQ2Cd6/5khHnOna0w75+PH2V8fDcuVTNspOg+FJpjC+wdyr7un7FUb4Ywy01qir/tPTwCZx0I2s9ZJyBysNTS5+xEy0SVvSGg0wzZTOICWL8rsBb2Tl+qZt9VvT2iC/Keh6Fm4w12UdbZsnpAPaiw+Ot6yCOr3kkI3eIhpQ72ghz8tbs9ZX9Y4kURsENzLSarKGsLWtFbKJMVarQv4oAhd7utrIhE0BBkko8bPn+YqeR7M42hCRzXIR+mQeXr/mS3J0/wqSAFbg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(8121501046)(5005006)(3231023)(944501075)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041268)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(6072148)(201708071742011); SRVR:AM6PR0502MB3799; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:AM6PR0502MB3799; X-Forefront-PRVS: 0547116B72 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(39860400002)(39380400002)(346002)(366004)(376002)(189003)(199004)(21086003)(16586007)(8676002)(8936002)(54906003)(316002)(3846002)(51416003)(97736004)(33026002)(386003)(6116002)(55016002)(81156014)(86362001)(16526018)(50466002)(48376002)(69596002)(81166006)(50226002)(76176011)(53936002)(2950100002)(6916009)(59450400001)(7696005)(105586002)(36756003)(68736007)(4720700003)(25786009)(5660300001)(106356001)(305945005)(47776003)(52116002)(2906002)(4326008)(7736002)(478600001)(66066001)(6666003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR0502MB3799; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:3; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM6PR0502MB3799; 23:ry6tA/YwS2At84QnW760oVxwVQ301jvQZ0KaCX2?= =?us-ascii?Q?1I1kBtGqb7hyocHdc08Mduw5WFGdvtLtCiLJPiJ4aE5qjpmhgb75v7NbsKjy?= =?us-ascii?Q?am01YC5wMK23bIiJRJjsEnpcDQVIFxPjGdrF6ijTxCsPyUaIsqAfD0A9T8Eu?= =?us-ascii?Q?N8H8utrYBrSrJkH5ZVcRoXIiP7AFtojHx3OZGrdQ4RRDRKzMQcsWAqNxTFsW?= =?us-ascii?Q?AVM9+eJ7nKH10YiyIeCB2tbVjtw/qYlu+XIP6ntBACDiJoSz+Xc4shgoB/e8?= =?us-ascii?Q?sliswMeScaotCpMsV/wMn+RBQTKoV994gJ0iD+sWss1P4xuNt8rLNX3n4J2i?= =?us-ascii?Q?XkLqviBUnP9/5fbd9z7w0oQ3T5DAJJk5tJ2mz6PoOuIB1qO5goH3wsOeLRYF?= =?us-ascii?Q?g66FVatEBNMCiSLZS9CtWoQtpTXla61BzWTncJibKGyBkqpPU2sOkZafq/Ov?= =?us-ascii?Q?hl2Awkmfejgs/3uTu9jULlNQfXUET9yMosqwOCwKT4lSv1KigXpJ1Okez8or?= =?us-ascii?Q?fZCcwRTufCndbaLaAC99tHTAjavdNxiaTRlpdiPBnHg6tHsLHPh8GJ0nvs3T?= =?us-ascii?Q?+hwdyE6VIoeDG+6CWdDMeSes6NGuup7+uIz/XXLxxkasujbJS3z5U05Hp7ee?= =?us-ascii?Q?TWW1aeJpEUqbnSX/naAlOsgg683gS8YRQSW5lI4+nTRNxOebfLRjNUHRbmpy?= =?us-ascii?Q?x2gLzRIAttRuXwBP6ONfMAsXl/nUaRzduwf7vVURt7D9oIvrfkgVGinA9UBp?= =?us-ascii?Q?BxmSUuF0hLzvydQtOQEyak+O4GZmwJoUkFDP8rYQ0KhmMOxdglkOwICzd0xH?= =?us-ascii?Q?zlpz4VRrbCz9bYGHvBCeKE8tWMNvqRjpxlWlNdUFknE0nFlFrXN17dSRfGVO?= =?us-ascii?Q?7vSjOYqd1Tufb/XPoi7pEnp2r9ggMShDLfAyBVp3PvCyYa9beX1jTIqmgVTU?= =?us-ascii?Q?uMdBNHlsJ0AcpA/yr6fVdva8pQTNM1IwQadHy8qgjk0x+VyPbodqK9xGSjaN?= =?us-ascii?Q?WC3SiV2lGhbX829vL9HQWd2CSnEn+WvGSTRSHHi6VsLOCKdjA1FHM7lX5mSE?= =?us-ascii?Q?9j7JDyz5iS+hd9K0EiY11NhB7o3Arkivr6c8QgEhhf7tvEekjoBr8SVgxE4b?= =?us-ascii?Q?9V+6OFncZScLs1/S8cvriENjiQOFpoDJvmYhQF3ALciXmAMNx+jeJJn2OaoH?= =?us-ascii?Q?yjPjNhOpHbk9MfY0=3D?= X-Microsoft-Exchange-Diagnostics: 1; AM6PR0502MB3799; 6:47tTdsmspmmJUWut9X9u8bfWijBTEHETMYb+W1UAt3E4kDXX2Y8bAaq1SeqY9CQ7aT8KzASmK5chjbULoIyvuNbFMVAA2udkyegsjKZPl3sQdi0ry/2Xa6KLEy+uFBGi9GlscxkxWwzt+3tgQJfn0xTZqA7+ZYds1QgSMJzrF3wO1GlWlIc6iPe+fauWk2yzauaR++oyhDanYUSINqiz9VOBBbMCMPETiVOuSkzdzTAPV+oD5UhWxyXOozB/2mZIpe0V/G91RLvg9cxhZQp5F8Ren3unDD0LFpjm+xGnVAI2ypkT+TsYvb6AxULG+k29/eiShbiWWmeH9BM+GrJgCdMpn0sKFxKJqUU8/OayABY=; 5:Zxx9fbvLwHqir23QdsLR/NpPyG26lCehheDW5w+6laPrYYgb+H5uPyRkBZgYRiZwDI51TwPcOwpmqNkYYKJWtO0+/DvFgRbDW4QNX0KP5v4CabkuJ2veJoH+hpKXfhBVzzpT2iAXd/L3dZHXPfY4Gh4ZN+3kY6PPBe1rCSeSFak=; 24:Y+IFXYLf7l9+Fc4OivQEV1CMklyhbktyemCbc61C9NSX0WVzgSV/8OhNQSkt1lilByKehx6AbUfaqBsRGFo32NKX8gEql8tdrN4fHiYxOzA=; 7:knwvOOlmifpcx0m56t0yXst3U+q4d3e0KQtM5y4xRmlZ0W9/if7/+eUMehoBb9yP1i50G58VoukaeQghlSKlfhFD//+FhNTbd0JEao/gNgl2v66g09pNOSOe77mcI24HbhSmeuJA9g8/EKOkNi/jDQW8qgj0sOyznRj0E5GfnDffB7Xr6GJLX1ApJUJbneapG+PNxpsvklHf1DuWvSncv294kr8+PuViUmGZtF00+BDWg6aYaflV0c/jw+uov6et SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2018 14:47:54.6431 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 27534fa3-e265-4965-e307-08d5576ff81f X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0502MB3799 Subject: [dpdk-dev] [PATCH v3 1/8] net/failsafe: fix invalid free X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 14:47:59 -0000 From: Adrien Mazarguil rte_free() is not supposed to work with pointers returned by calloc(). Fixes: a0194d828100 ("net/failsafe: add flexible device definition") Cc: stable@dpdk.org Cc: Gaetan Rivet Signed-off-by: Adrien Mazarguil --- drivers/net/failsafe/failsafe_args.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/failsafe/failsafe_args.c b/drivers/net/failsafe/failsafe_args.c index cfc83e3..ec63ac9 100644 --- a/drivers/net/failsafe/failsafe_args.c +++ b/drivers/net/failsafe/failsafe_args.c @@ -407,7 +407,7 @@ typedef int (parse_cb)(struct rte_eth_dev *dev, const char *params, uint8_t i; FOREACH_SUBDEV(sdev, i, dev) { - rte_free(sdev->cmdline); + free(sdev->cmdline); sdev->cmdline = NULL; free(sdev->devargs.args); sdev->devargs.args = NULL; -- 1.8.3.1