From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 7DD841B16B; Wed, 10 Jan 2018 09:57:06 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2018 00:57:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,339,1511856000"; d="scan'208";a="8652361" Received: from dpdk6.bj.intel.com ([172.16.182.87]) by fmsmga008.fm.intel.com with ESMTP; 10 Jan 2018 00:57:02 -0800 From: Wei Dai To: konstantin.ananyev@intel.com, qiming.yang@intel.com, yuan.peng@intel.com, wenzhuo.lu@intel.com, jingjing.wu@intel.com Cc: dev@dpdk.org, stable@dpdk.org, Wei Dai Date: Wed, 10 Jan 2018 16:40:54 +0800 Message-Id: <1515573656-41847-1-git-send-email-wei.dai@intel.com> X-Mailer: git-send-email 2.7.5 In-Reply-To: <1515557660-36763-1-git-send-email-wei.dai@intel.com> References: <1515557660-36763-1-git-send-email-wei.dai@intel.com> Subject: [dpdk-dev] [PATCH v3 0/2] app/testpmd: fix invalid rxq and txq nubmer setting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 08:57:07 -0000 If an invlaid number of RX or TX queues is configured from testpmd command like "port config all rxq number" or "port config all txq number". The global variable rxq or txq is updated by the invalid input. This can cause testpmd crash. For example, if the maximum number of RX or TX queues is 4, testpmd will crash after running commands "port config all rxq 5", "port config all txq 5" and "start" in sequence. These 2 patches reserve the last correct rxq and txq, if an invalid input is detected, it is restored to the backup value to avoid crash. Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") Cc: stable@dpdk.org Signed-off-by: Wei Dai --- v3: follow the guide from Konstantin to use functions to check input rxq and txq instead of usage of new added global variables. v2: fix a bug in v1 Wei Dai (2): app/testpmd: fix invalid rxq number setting app/testpmd: fix invalid txq number setting app/test-pmd/cmdline.c | 4 ++ app/test-pmd/parameters.c | 13 ++++--- app/test-pmd/testpmd.c | 94 +++++++++++++++++++++++++++++++++++++++++++++++ app/test-pmd/testpmd.h | 5 +++ 4 files changed, 110 insertions(+), 6 deletions(-) -- 2.7.5