* [dpdk-dev] [PATCH v1] Return ENOMEM during mpipe_devinit failure
@ 2015-08-19 20:00 Ravi Kerur
2015-08-20 2:07 ` Tetsuya Mukawa
2015-08-20 2:14 ` Tony Lu
0 siblings, 2 replies; 4+ messages in thread
From: Ravi Kerur @ 2015-08-19 20:00 UTC (permalink / raw)
To: dev
In function rte_pmd_mpipe_devinit, if rte_eth_dev_allocate
fails return error which is inline with other drivers.
Signed-off-by: Ravi Kerur <rkerur@gmail.com>
---
drivers/net/mpipe/mpipe_tilegx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/mpipe/mpipe_tilegx.c b/drivers/net/mpipe/mpipe_tilegx.c
index 743feef..6e3e304 100644
--- a/drivers/net/mpipe/mpipe_tilegx.c
+++ b/drivers/net/mpipe/mpipe_tilegx.c
@@ -1582,6 +1582,7 @@ rte_pmd_mpipe_devinit(const char *ifname,
if (!eth_dev) {
RTE_LOG(ERR, PMD, "%s: Failed to allocate device.\n", ifname);
rte_free(priv);
+ return -ENOMEM;
}
RTE_LOG(INFO, PMD, "%s: Initialized mpipe device"
--
1.9.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH v1] Return ENOMEM during mpipe_devinit failure
2015-08-19 20:00 [dpdk-dev] [PATCH v1] Return ENOMEM during mpipe_devinit failure Ravi Kerur
@ 2015-08-20 2:07 ` Tetsuya Mukawa
2015-08-20 2:14 ` Tony Lu
1 sibling, 0 replies; 4+ messages in thread
From: Tetsuya Mukawa @ 2015-08-20 2:07 UTC (permalink / raw)
To: Ravi Kerur, dev
On 2015/08/20 5:00, Ravi Kerur wrote:
> In function rte_pmd_mpipe_devinit, if rte_eth_dev_allocate
> fails return error which is inline with other drivers.
>
> Signed-off-by: Ravi Kerur <rkerur@gmail.com>
> ---
> drivers/net/mpipe/mpipe_tilegx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/mpipe/mpipe_tilegx.c b/drivers/net/mpipe/mpipe_tilegx.c
> index 743feef..6e3e304 100644
> --- a/drivers/net/mpipe/mpipe_tilegx.c
> +++ b/drivers/net/mpipe/mpipe_tilegx.c
> @@ -1582,6 +1582,7 @@ rte_pmd_mpipe_devinit(const char *ifname,
> if (!eth_dev) {
> RTE_LOG(ERR, PMD, "%s: Failed to allocate device.\n", ifname);
> rte_free(priv);
> + return -ENOMEM;
> }
>
> RTE_LOG(INFO, PMD, "%s: Initialized mpipe device"
Acked-by: Tetsuya Mukawa <mukawa@igel.co.jp>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH v1] Return ENOMEM during mpipe_devinit failure
2015-08-19 20:00 [dpdk-dev] [PATCH v1] Return ENOMEM during mpipe_devinit failure Ravi Kerur
2015-08-20 2:07 ` Tetsuya Mukawa
@ 2015-08-20 2:14 ` Tony Lu
2015-10-24 17:28 ` Thomas Monjalon
1 sibling, 1 reply; 4+ messages in thread
From: Tony Lu @ 2015-08-20 2:14 UTC (permalink / raw)
To: 'Ravi Kerur', dev
>-----Original Message-----
>From: Ravi Kerur [mailto:rkerur@gmail.com]
>Sent: Thursday, August 20, 2015 4:00 AM
>To: dev@dpdk.org
>Cc: zlu@ezchip.com; Ravi Kerur
>Subject: [PATCH v1] Return ENOMEM during mpipe_devinit failure
>
>In function rte_pmd_mpipe_devinit, if rte_eth_dev_allocate
>fails return error which is inline with other drivers.
>
>Signed-off-by: Ravi Kerur <rkerur@gmail.com>
>---
> drivers/net/mpipe/mpipe_tilegx.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/mpipe/mpipe_tilegx.c
>b/drivers/net/mpipe/mpipe_tilegx.c
>index 743feef..6e3e304 100644
>--- a/drivers/net/mpipe/mpipe_tilegx.c
>+++ b/drivers/net/mpipe/mpipe_tilegx.c
>@@ -1582,6 +1582,7 @@ rte_pmd_mpipe_devinit(const char *ifname,
> if (!eth_dev) {
> RTE_LOG(ERR, PMD, "%s: Failed to allocate device.\n",
ifname);
> rte_free(priv);
>+ return -ENOMEM;
> }
>
> RTE_LOG(INFO, PMD, "%s: Initialized mpipe device"
>--
>1.9.1
Thanks for fixing this.
Acked-by: Zhigang Lu <zlu@ezchip.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH v1] Return ENOMEM during mpipe_devinit failure
2015-08-20 2:14 ` Tony Lu
@ 2015-10-24 17:28 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2015-10-24 17:28 UTC (permalink / raw)
To: 'Ravi Kerur'; +Cc: dev
> >In function rte_pmd_mpipe_devinit, if rte_eth_dev_allocate
> >fails return error which is inline with other drivers.
> >
> >Signed-off-by: Ravi Kerur <rkerur@gmail.com>
>
> Thanks for fixing this.
> Acked-by: Zhigang Lu <zlu@ezchip.com>
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-24 17:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-19 20:00 [dpdk-dev] [PATCH v1] Return ENOMEM during mpipe_devinit failure Ravi Kerur
2015-08-20 2:07 ` Tetsuya Mukawa
2015-08-20 2:14 ` Tony Lu
2015-10-24 17:28 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).