From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 3F53AA48D; Fri, 12 Jan 2018 12:47:42 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jan 2018 03:47:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,348,1511856000"; d="scan'208";a="10703995" Received: from dpdk6.bj.intel.com ([172.16.182.87]) by orsmga006.jf.intel.com with ESMTP; 12 Jan 2018 03:47:37 -0800 From: Wei Dai To: ferruh.yigit@intel.com, yuan.peng@intel.com, konstantin.ananyev@intel.com, wenzhuo.lu@intel.com, jingjing.wu@intel.com Cc: dev@dpdk.org, Wei Dai , stable@dpdk.org Date: Fri, 12 Jan 2018 19:31:20 +0800 Message-Id: <1515756682-69016-1-git-send-email-wei.dai@intel.com> X-Mailer: git-send-email 2.7.5 In-Reply-To: <1515744603-60457-1-git-send-email-wei.dai@intel.com> References: <1515744603-60457-1-git-send-email-wei.dai@intel.com> Subject: [dpdk-dev] [PATCH v6 0/2] app/testpmd: fix invalid rxq and txq nubmer settings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jan 2018 11:47:42 -0000 If an invlaid number of RX or TX queues is configured from testpmd command like "port config all rxq number" or "port config all txq number" or from --rxq and --txq in the command to start testpmd. The global variable nb_rxq or nb_txq is updated by the invalid input. This can cause testpmd crash. For example, if the maximum number of RX or TX queues is 4, testpmd will crash after running commands "port config all rxq 5", "port config all txq 5" and "start" in sequence. With these 2 patches, if an invalid input is detected, it is refused and testpmd keeps last correct values of nb_rxq and nb_txq. Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") Cc: stable@dpdk.org Signed-off-by: Wei Dai Aced-by: Konstantin Ananyev Tested-by: Yuan Peng --- v6: same as v5. only correct patchwork mail format error for maintainer's convenience. v5: fix building failure with -Werror=maybe-uninitialized by gcc 5.3.1 fix typo error v4: update git log message and rename 2 new added functions v3: follow the guide from Konstantin to use functions to check input rxq and txq instead of usage of new added global variables. v2: fix a bug in v1 Wei Dai (2): app/testpmd: fix invalid rxq number setting app/testpmd: fix invalid txq number setting app/test-pmd/cmdline.c | 4 +++ app/test-pmd/parameters.c | 13 +++---- app/test-pmd/testpmd.c | 92 +++++++++++++++++++++++++++++++++++++++++++++++ app/test-pmd/testpmd.h | 5 +++ 4 files changed, 108 insertions(+), 6 deletions(-) -- 2.7.5