From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00079.outbound.protection.outlook.com [40.107.0.79]) by dpdk.org (Postfix) with ESMTP id A8F391B025; Thu, 18 Jan 2018 11:02:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=a44iwuxPdrug9q0yyqckpNbS89ZFrleju5p3Es6xISo=; b=m2x00sBExlZXZ6oPtvikeH33cqqLanxTsc9wlFHZzGTdcZsvyZlkBreuWGxxkq6s5yNQKab22tFQtCx1hj3jqtOqkAneNXGcGQbc4CV/wB33yiRRw4WSjuG9jaD2bJKP5oPt1lUB4JeCtTQ3rh2bv9Vpf0X0q3sGBfn5bKTcsNI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; Received: from mellanox.com (37.142.13.130) by AM6PR0502MB3797.eurprd05.prod.outlook.com (2603:10a6:209:a::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.428.17; Thu, 18 Jan 2018 10:02:02 +0000 From: Matan Azrad To: Ferruh Yigit Cc: Thomas Monjalon , dev@dpdk.org, stephen@networkplumber.org, Adrien Mazarguil , stable@dpdk.org, Gaetan Rivet Date: Thu, 18 Jan 2018 10:01:42 +0000 Message-Id: <1516269709-15252-2-git-send-email-matan@mellanox.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1516269709-15252-1-git-send-email-matan@mellanox.com> References: <1516265026-6469-1-git-send-email-matan@mellanox.com> <1516269709-15252-1-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1PR0202CA0033.eurprd02.prod.outlook.com (2603:10a6:803:14::46) To AM6PR0502MB3797.eurprd05.prod.outlook.com (2603:10a6:209:a::26) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f62dff65-1b5f-4c92-8936-08d55e5a8606 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(48565401081)(2017052603307)(7153060)(7193020); SRVR:AM6PR0502MB3797; X-Microsoft-Exchange-Diagnostics: 1; AM6PR0502MB3797; 3:NTMrClZ//niqJVy0fv3MC7RsYy0R2+FUx5zwLh/ZdhBIvfzwqwIk/+uk3fknuElhvgECdh4oq33W6FMWKTX5Bye5QBfRHnup2IjNq/UDm1xwixQ4dkHIiOFoSzZGOsna9JeE8/jyvGd8yjNPaMeTe1FrqKul7ccVJZXjamDPh6FF237eRvSMIMaSKwUYKzIsVzQvR5fRVoYdeVdhgFTMb98TJ73fsrlVmf+7hvR0iEs8UkQ+Erv3UR3dmZz3t2d6; 25:EGTc6z4qC0GwsZ3Pt+RvIac/EnVgO9A5A/l5yU90QdaGGH0+bm9uO6E4qUR2rf7n6hdRN4BZk3iYHDd9RWMnHcgu/6cl44H7VFebChT3sTeGt9KvMOTc887e5TjV65t2oEaCNgB3AeCLvNxBRToV4d/tvFW3xmNHrh+LPF32fgeplXHwibN020d17RtXey5Ls7Ikqe345He9pPSFjASkCA9taVdgvXton4e58BLPv4z6NfXEuYDSFZ4i9JpPkIxNJqFXc2mZ+jaXx3Pn3nrOYJsPTVJLyBjcIuy4EbigyyTy3Wv3kQozdFh3udykTxy1CI/H4at0OxgajkkSFwmWyg==; 31:bmH8lCsLSouw0Y8mPUXdhig6sicSU8nxMs/f9w1lJIE4HYx8pRwCL8TG6noeoeaD0/Y3fo/z2GdGgViPYLVoc6zoxC69EnfPGG3v3KaHAQ30fodzNZOcIFLBVktodERIiF31OA27UieHTlWeRIWIxpQO+CZHJa1FwGWyh2dPX+0o9HkPDuJAlENWUT6grup4NXFV2O0q05ofFA/K4Njd6hroK8znPy6sl0xleZujUiY= X-MS-TrafficTypeDiagnostic: AM6PR0502MB3797: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; AM6PR0502MB3797; 20:6vePMl3SoCAYeubc2tFu0g026kymac3HHEKk6qizu3h31v1d7uySsHB0PVEicQu5xtD70YDUF+6/jkNQDAwjzPTTZGRTSU5KLKLX/rjo14xk1+Jis7pOgy1/YXUK+HvhrWcro+1dpg+JPW13XNpLGI3y2/exH99Qk8d2Vgqm6jKn22Ld9OHFvDGa8GcnETu8BmVB2Ubz+QiXxxVgUJzmNE5y2lKbM+73IU5QtxDrZEcsqYnDfTa5RczQU3z8nVoi4gTMK4rbLZYtF5izRFKb6QZEn35a3yV29y+g7GVCsmyz3N6r6miVdZNgWqJRwYvXjX6nZ4616fwaUkrlp1V2UkeVN+GEJvnPrJashqyNHbk0yyfGrVopYykYfZTzkuxFMLNUN4q2JRC5nza7u9xaPXravaXd8SmpVHbciJntNM8Axifu8fB53P4Qhp2FQbrc2/UPYudRa0+ngPiW3mLEeOHLkFXX8b7tjyNncRodr6u7aNRTUJ7+8vS5CxzD8zhD; 4:sPzc/OZjVkUVNAmNu4xMe/HCZ5Q4hXEQNTvFIaecaPWLiq6i8QLhOFGzLGPrqu3+tbp0BWfkbzSRXiSxqXKGElptQJJneCLPBFNMhQqjTQsZg3XzFbcjMrRvRFO00iAX1+edrwKzYOzNPJPTPvMTqeMwdoSw1HNA/y8qoRWWedhU6cNVom+fOB9Cw1EcJZi95hxGHJmcFQSuzjE7EcQ9H48LCiyMFHDSFg/1yVZzyrLcpkDYpNmedF4arqdNp9IgHkXhaJONz3InC8iPXJUijw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(10201501046)(3231023)(2400060)(944501161)(3002001)(93006095)(93001095)(6055026)(6041268)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:AM6PR0502MB3797; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:AM6PR0502MB3797; X-Forefront-PRVS: 05568D1FF7 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(39380400002)(346002)(396003)(376002)(199004)(189003)(6116002)(53936002)(76176011)(386003)(4720700003)(59450400001)(26005)(7736002)(305945005)(50466002)(66066001)(2906002)(47776003)(16586007)(54906003)(8676002)(478600001)(316002)(21086003)(2950100002)(25786009)(48376002)(52116002)(6666003)(51416003)(7696005)(6916009)(81166006)(81156014)(8936002)(4326008)(86362001)(16526018)(97736004)(68736007)(36756003)(50226002)(5660300001)(105586002)(3846002)(69596002)(106356001)(33026002)(55016002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR0502MB3797; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM6PR0502MB3797; 23:ka5TZE3ROpj+v6XOG9LL66VkbSNY+lnZllnudNY?= =?us-ascii?Q?/Ang+WFuSKTbsuC72GqS6QzNuC0ytPc1CnlqYL3p8kgHBJ4tSvZD6tqeBFxT?= =?us-ascii?Q?o6zTwJba/Bb7wUacVUR8XLE+AAXW7TmE7yh4SgETmc71qo3a/hx+2oSkFqSY?= =?us-ascii?Q?yhFB7JlidDiM7iNTugxDnMuC737pZOyhwE+9udY7Oo3VfYl1l+/AExxtKZog?= =?us-ascii?Q?Z+e1FdjrIs0WWYOXFXTKMuJKLL2hrH5Im+5Aa17/zfNg7sTCosbwaadRWsaY?= =?us-ascii?Q?imIHaJ1XHATZWPtepkk1v2rmiyIIJ0Rhtgs53Zl6wZgslrVEOuUzt2LdGXiH?= =?us-ascii?Q?lVf0/J+ZRqNJESmT6e80bV78CT3oTfRE6/dBUE1Ay/fSdcL264ggGA3GhpxS?= =?us-ascii?Q?rWOIOaJsTMmyDBE7IkOIUiYHwhhW1yq/FEqjgB9n2Ip/Q74BIz7Rkltxfm54?= =?us-ascii?Q?UqI0gmNHs9GxvPY5NAdA+7fuDub10vP9n2J0yWLGWNbCHIsbfGFwe2qSB6Iq?= =?us-ascii?Q?TthE8hHybicG/82wILZd5yZ3Cy+QMpfoOAOA2L1kcmpoA3XNZNdNBbhrFqz2?= =?us-ascii?Q?eXSNV632+P/zT04gYgPx6e9FiJleSm9WoNTxuxxzdTSuyOcohRet7PemlGeu?= =?us-ascii?Q?2FxYLJpjx0sZDhTHm4q9Lh8jCbtK3hcPL/Xv6+WWDM1kQelZkeZGcM03VRqi?= =?us-ascii?Q?e3PQtWr1hd0+38kC5Mm9PvFdEHT+Www9tik8QZ59BFDSq+A081StnAk/CUHH?= =?us-ascii?Q?IDMKF6Qk2JiiEWSHV+HZnIJsV1o2LMLE3WYwCZ7jDR6zzCnRaHOHYznFgNs7?= =?us-ascii?Q?DFgBnRC0EmMoY6XzUXRnAWGzo3OleON8h6N47mbWAfOrVd40ulSnwp3iZZxT?= =?us-ascii?Q?5w0TtN9d0OESlP/Vm87aqLTFrZDyr9UK9Y1YJPInyVUGnkvrp6HeLY5AltK9?= =?us-ascii?Q?IojercqgD9EqKfmehTqkKGlukzopF87gtyFA1T6aPBquJ06XjsFbm5TTL2UX?= =?us-ascii?Q?izXNCIgv0c7GUa+S+pRNEyCK0tctJ2p+AdTPSoCV5qU2biCwQhd0AqySal1G?= =?us-ascii?Q?+dx2vGiD9e3I+MPC6ofQ5+kYMkiJOUnsgY/C2LlqpcEKXkVQlKZ02toydR9h?= =?us-ascii?Q?SK4gGkad2/ViKJ1atM/xDwNq/dNvfzkkacK4ivycqyw0NxmnZGZGW7DyMt3i?= =?us-ascii?Q?hCVkbVQ7Rkcn/VzgfzxbvKCKmLvn6h52Fm34X?= X-Microsoft-Exchange-Diagnostics: 1; AM6PR0502MB3797; 6:gxvXwJOey+r7ccrmeFsu9firkbVQ+tIop3MjGf/axT7u3UaXaYC9n1BwURZyu2m4Nt2576maTBPj6mbMhvL2y7um1Z98x3mJ94a/JEOKSK63xKxnA5GM3dE3GH5QkMxjS2DMg6O+A+prOLmDMe1HWJmoKq3n95F0n4HrA6M4pwrGg6tBbNHwiLE2oPIBggonxATsMf6adoy4HWBv3PIcujmIFV72UtQ3K6mINbrzG0ddZ/26wdSJ0JDNYHCiXX96DUekkZ/N2Yikeg22DNyU9HMyot7cGPHfrFf8As3Lu50MJpCAnpWwi9Nl6MAW7kFWhoRee1O8EEU54OWq7zkp8E4+2RpcxdnTfi8MVdis2Fw=; 5:qsI2A2uB4oRWizU9LM/G4L4ZEdTglYedhw/pvuslq5AngrB+fo4KGSHEKf99/LMZX321Am+jmte/l4Txu32ngJBw0UmQLnjaeACNC6O7r//Ain7JEajLjH4nHVIfSVBeIWrD0IjA+xVuWucYg2tIW6wcfSx4Uo3PEEvQ+JHRvzg=; 24:pa7t1qfKZq4XRRMJKajUVJ6iXBteQJJskiQdAQAWbqV1Ma0FoP+j+lgxTWsZnFarZINDEN9g/fqOME8t7Z4eRFZWMDZyX1DTIeejvN7rsJ0=; 7:Y+oRZVD8PbnNe6ha+Qypx7I57KnQwouRz2f06vQCSg3Eir4ndIXRIuu5Nnjh4Ti2/Oq1zGhv/QCyNzo8ubZxTD4XN9cl6V1M+hx6G1QB1zIgVBBDt4rVHhl6VPnDK6z5d2wJBAhpGQekn0cvUwEHJeNBfqWsiPK9F9UvnsyEr3xF4LxbC8R7vKQY9FiXcuJBF++t/SoMwZPwoqnVk1umOmP+bhAoLN38Af+EzXGpRwC0b1AMyZGCC6zJOZ4mv8d1 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2018 10:02:02.1748 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f62dff65-1b5f-4c92-8936-08d55e5a8606 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0502MB3797 Subject: [dpdk-dev] [PATCH v5 1/8] net/failsafe: fix invalid free X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jan 2018 10:02:04 -0000 From: Adrien Mazarguil rte_free() is not supposed to work with pointers returned by calloc(). Fixes: a0194d828100 ("net/failsafe: add flexible device definition") Cc: stable@dpdk.org Cc: Gaetan Rivet Signed-off-by: Adrien Mazarguil Acked-by: Gaetan Rivet --- drivers/net/failsafe/failsafe_args.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/failsafe/failsafe_args.c b/drivers/net/failsafe/failsafe_args.c index cfc83e3..ec63ac9 100644 --- a/drivers/net/failsafe/failsafe_args.c +++ b/drivers/net/failsafe/failsafe_args.c @@ -407,7 +407,7 @@ typedef int (parse_cb)(struct rte_eth_dev *dev, const char *params, uint8_t i; FOREACH_SUBDEV(sdev, i, dev) { - rte_free(sdev->cmdline); + free(sdev->cmdline); sdev->cmdline = NULL; free(sdev->devargs.args); sdev->devargs.args = NULL; -- 1.8.3.1