* [dpdk-dev] [PATCH 0/2] fixes for net/mrvl pmd
@ 2018-01-18 10:57 Tomasz Duszynski
2018-01-18 10:57 ` [dpdk-dev] [PATCH 1/2] net/mrvl: allow changing MTU before port init Tomasz Duszynski
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Tomasz Duszynski @ 2018-01-18 10:57 UTC (permalink / raw)
To: dev; +Cc: jck, dima, nsamsono, jianbo.liu, Tomasz Duszynski
This patch-set contains a couple of changes which let the application
using pmd to set mtu and mac addresses before port is initialized.
Tomasz Duszynski (2):
net/mrvl: allow changing MTU before port init
net/mrvl: allow adding ether addr before port init
drivers/net/mrvl/mrvl_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread* [dpdk-dev] [PATCH 1/2] net/mrvl: allow changing MTU before port init
2018-01-18 10:57 [dpdk-dev] [PATCH 0/2] fixes for net/mrvl pmd Tomasz Duszynski
@ 2018-01-18 10:57 ` Tomasz Duszynski
2018-01-18 10:57 ` [dpdk-dev] [PATCH 2/2] net/mrvl: allow adding ether addr " Tomasz Duszynski
2018-01-18 16:26 ` [dpdk-dev] [PATCH 0/2] fixes for net/mrvl pmd Ferruh Yigit
2 siblings, 0 replies; 4+ messages in thread
From: Tomasz Duszynski @ 2018-01-18 10:57 UTC (permalink / raw)
To: dev; +Cc: jck, dima, nsamsono, jianbo.liu, Tomasz Duszynski, stable
DPDK updates MTU once mtu_set() callback returns success.
Since PMD changes port's MTU to dev->mtu every time device is
started it is safe to call mtu_set() before MUSDK ppio was initialized.
Fixes: c0511a8f741f ("net/mrvl: check if ppio is initialized")
Cc: stable@dpdk.org
Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
---
drivers/net/mrvl/mrvl_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mrvl/mrvl_ethdev.c b/drivers/net/mrvl/mrvl_ethdev.c
index 4294c56..a011675 100644
--- a/drivers/net/mrvl/mrvl_ethdev.c
+++ b/drivers/net/mrvl/mrvl_ethdev.c
@@ -379,7 +379,7 @@ mrvl_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
return -EINVAL;
if (!priv->ppio)
- return -EPERM;
+ return 0;
ret = pp2_ppio_set_mru(priv->ppio, mru);
if (ret)
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread* [dpdk-dev] [PATCH 2/2] net/mrvl: allow adding ether addr before port init
2018-01-18 10:57 [dpdk-dev] [PATCH 0/2] fixes for net/mrvl pmd Tomasz Duszynski
2018-01-18 10:57 ` [dpdk-dev] [PATCH 1/2] net/mrvl: allow changing MTU before port init Tomasz Duszynski
@ 2018-01-18 10:57 ` Tomasz Duszynski
2018-01-18 16:26 ` [dpdk-dev] [PATCH 0/2] fixes for net/mrvl pmd Ferruh Yigit
2 siblings, 0 replies; 4+ messages in thread
From: Tomasz Duszynski @ 2018-01-18 10:57 UTC (permalink / raw)
To: dev; +Cc: jck, dima, nsamsono, jianbo.liu, Tomasz Duszynski, stable
Since DPDK restores ether address configuration after device
is started it is safe to add ether address to uninitialized port (ppio).
Fixes: c0511a8f741f ("net/mrvl: check if ppio is initialized")
Cc: stable@dpdk.org
Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
---
drivers/net/mrvl/mrvl_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mrvl/mrvl_ethdev.c b/drivers/net/mrvl/mrvl_ethdev.c
index a011675..16a964b 100644
--- a/drivers/net/mrvl/mrvl_ethdev.c
+++ b/drivers/net/mrvl/mrvl_ethdev.c
@@ -909,7 +909,7 @@ mrvl_mac_addr_add(struct rte_eth_dev *dev, struct ether_addr *mac_addr,
return -1;
if (!priv->ppio)
- return -EPERM;
+ return 0;
/*
* Maximum number of uc addresses can be tuned via kernel module mvpp2x
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH 0/2] fixes for net/mrvl pmd
2018-01-18 10:57 [dpdk-dev] [PATCH 0/2] fixes for net/mrvl pmd Tomasz Duszynski
2018-01-18 10:57 ` [dpdk-dev] [PATCH 1/2] net/mrvl: allow changing MTU before port init Tomasz Duszynski
2018-01-18 10:57 ` [dpdk-dev] [PATCH 2/2] net/mrvl: allow adding ether addr " Tomasz Duszynski
@ 2018-01-18 16:26 ` Ferruh Yigit
2 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2018-01-18 16:26 UTC (permalink / raw)
To: Tomasz Duszynski, dev; +Cc: jck, dima, nsamsono, jianbo.liu
On 1/18/2018 10:57 AM, Tomasz Duszynski wrote:
> This patch-set contains a couple of changes which let the application
> using pmd to set mtu and mac addresses before port is initialized.
>
> Tomasz Duszynski (2):
> net/mrvl: allow changing MTU before port init
> net/mrvl: allow adding ether addr before port init
Series applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-01-18 16:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-18 10:57 [dpdk-dev] [PATCH 0/2] fixes for net/mrvl pmd Tomasz Duszynski
2018-01-18 10:57 ` [dpdk-dev] [PATCH 1/2] net/mrvl: allow changing MTU before port init Tomasz Duszynski
2018-01-18 10:57 ` [dpdk-dev] [PATCH 2/2] net/mrvl: allow adding ether addr " Tomasz Duszynski
2018-01-18 16:26 ` [dpdk-dev] [PATCH 0/2] fixes for net/mrvl pmd Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).