From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10055.outbound.protection.outlook.com [40.107.1.55]) by dpdk.org (Postfix) with ESMTP id B72451B2E7; Thu, 18 Jan 2018 14:51:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=a44iwuxPdrug9q0yyqckpNbS89ZFrleju5p3Es6xISo=; b=w1FxJd0dW879jUAsLAccr+6uIiQaCUWtPgVifx5sDG5sRglO/yvuImjIOEhF9qNuHlkKl7cRck4PmZnRuD3vwIl8TVzzaFZsLuTov7Mc3s1aC89gN2NsfvLktF8PDzzoDdlTV/Gr8XhBSDAMfKBPOU++pvrPu75lSSle/jfTVH4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; Received: from mellanox.com (37.142.13.130) by AM6PR0502MB3798.eurprd05.prod.outlook.com (2603:10a6:209:a::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.407.7; Thu, 18 Jan 2018 13:51:57 +0000 From: Matan Azrad To: Ferruh Yigit , Adrien Mazarguil , Gaetan Rivet Cc: Thomas Monjalon , dev@dpdk.org, stable@dpdk.org Date: Thu, 18 Jan 2018 13:51:39 +0000 Message-Id: <1516283506-21198-2-git-send-email-matan@mellanox.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1516283506-21198-1-git-send-email-matan@mellanox.com> References: <1516269709-15252-1-git-send-email-matan@mellanox.com> <1516283506-21198-1-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1PR08CA0115.eurprd08.prod.outlook.com (2603:10a6:800:d4::17) To AM6PR0502MB3798.eurprd05.prod.outlook.com (2603:10a6:209:a::27) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 5bbf7b95-8c68-454f-7fa8-08d55e7aa4cf X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534125)(4602075)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:AM6PR0502MB3798; X-Microsoft-Exchange-Diagnostics: 1; AM6PR0502MB3798; 3:KpkABRe8Hg7SfSx+zXcFdJYAZ8UkkQV4lVakQUwGjTYxM5n/Y9y9+GgH+iEhfDeoeM0adb+qaNFeLVyD7h5X9incUG91KsJ5Opk3XQtgMST+DVMX+uzm9jWzcUf1ZY42ApWkE6pKi7Yjz36Pk7+5QN/jCITCAo3Xd8jqTy52n6ObiLi/D2/HVbjQ1M4MEb3p4/Bjp7A4gO3jkPAcfFSYxHMruwqVtnVu77m5HFA9GbpnjDSktHRIC6yCn/8d05lc; 25:4Fw5yXOS6ejgS0k2d9RekWutq6jqltq32L8uUc10LlScjRvY99Rx5h+91z1gMszVM8nqEFFYmiV5PDZjUL3H9ZoLRgANgOdmSFUQ8+5FYBSvW9rpYC5ZDB2FvJ4B+uFrL81egXWY5UOypUy2XEse8f/kNtSAps8hlq1b6ABClNdPbuVVjLUqJ5dbMYyFrKC7WAMcI4iwr6jM+QWb/l2CQ+nOhfGyaJtOfAuISVFxBC8uGFfD43WNm8WsLiuCRQz18+b+bUiuy/pJ8X4853aiNTut88utxnW5oNcxyoJm25U5X6bGDacH1t5RbO8z9zs7Wgr52MEda7a98ycNKl1cSQ==; 31:Ediqf1dLzMHQVLnlPvCt71n4N9pzwLSHGCuzLS5NOOz10ZPmwhvUe6qHHAoXts+fe+IeLUBSK3ix42tk3tcp9Vqo1SnYfqSSnmSnosEX9cMiQfbqEal8gpQGPnjDK54hEMAQxz3WlyPexx5Y/YbOtnyGf5tqr+5mKeXSXWVN+MTBjZKaQkeBScdYbzaq6GNvdPnS8MsE/awjOu6+hb55Gsut4mR3i7FIn8ibxMLlY9I= X-MS-TrafficTypeDiagnostic: AM6PR0502MB3798: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; AM6PR0502MB3798; 20:qP8jQ7bPR36o3SdFKUkEIzHwThcwCRg81l+rwfMRoVZD1K84GTGv8m+xYqa8CrdByzBMVVUmBseBYdM1lR6YEGhWhsRa3pcZxIbgxu+xyoOCdbeygNxxvsN0hVqfKYHcrp+oN1WP4aVjIz3VKD5XYZ2cmvupRmbLa8O47kGjvAd9vVL3tWBUxao/X8Pmao96EXEpkFeSyARP1Rv2HwtL+cY4ytA+xuo+Bw7JRwo83e5/comUACUX1llY/f9LVT2yz7UM4YLXfduI58xmHu/XM5DnfKLspCkMSehNROv7CKPmT+J7/z51eeMyrC6FTSh9daIe6XxOGkfyhMyuQk8qxkjJ8DvxRpRulbO3SKFRqZNls6nYwdxU5LmZufNwBIt8ad4/4xqrCUXV851upAD+Ay5OW9VQwkPxjJUB10DgFukn/1hUEIKskSVXxtIYk513YNFhgqUDOcLTJA8NDuL5h7oMVU9oQKGU8Pi8br3vNzDOVRpgneKJxz6QB9ovWRye; 4:to0aXq7VpAHOag423mE1ivEu/9bIysgQikgaVLU5SV3sfs71/IBlnMwawtQNXAeBum9N5t4q7ADISUuSAtm2dM85NofDlEBnLprkuwrtNwqD/zrtzbOCMSSI//XZEGwFOCsgM5FeurNQtk4zYwDDiD3yVUHHgEvVyq+JKZe9Z8+u6/0rkzUAsByF4+h6HcKVh9phO4/yvATWU7412hl7dRRY06PVU3mXuERRv83GWzkhQnrMPPHZNGO91eruXHovJEXOjokwB31qjHOqd+5t6A== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(8121501046)(5005006)(3002001)(10201501046)(3231023)(944501161)(93006095)(93001095)(6055026)(6041268)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(6072148)(201708071742011); SRVR:AM6PR0502MB3798; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:AM6PR0502MB3798; X-Forefront-PRVS: 05568D1FF7 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(396003)(346002)(39380400002)(39860400002)(376002)(199004)(189003)(386003)(2906002)(51416003)(81156014)(81166006)(5660300001)(305945005)(4326008)(21086003)(7696005)(106356001)(8676002)(68736007)(26005)(69596002)(76176011)(59450400001)(105586002)(86362001)(97736004)(3846002)(6116002)(52116002)(53936002)(6666003)(50226002)(55016002)(4720700003)(33026002)(7736002)(2950100002)(36756003)(47776003)(478600001)(16526018)(8936002)(66066001)(316002)(110136005)(48376002)(50466002)(16586007)(25786009); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR0502MB3798; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM6PR0502MB3798; 23:bXK+u0Z6dcO6wE+cXbiA55/lvNwTn2Jj8OosZAO?= =?us-ascii?Q?erAvQKfEZt/CXyHYDWUKRpcNjJdqDn3Nv1+iGXLQ6rMlmgchnVWVdvh35kCc?= =?us-ascii?Q?6ulnekNhU24DDxfShbKVjFR41hG2yGlgZBE0jFkRGa03nCRuYZ9PhYFfLQlL?= =?us-ascii?Q?eHZvLkHHmkR1drWFFZjM3zhnha+9aK1XZRlJS/MilZP9UkedowCSQ0Nv5Unl?= =?us-ascii?Q?Mdt8UEv6KXaYKzMCRZo6Yl/gObC0nQuxPdiXRaF9Xr8t/kfixcSB0lnAGVdo?= =?us-ascii?Q?RO9X6Za4Hp6pEWRC8k97UuFGk4G9NWLZFEdr9ozQSVDCB2BTTTgqRhA2x7+v?= =?us-ascii?Q?uiB+ktjbwdIiDrUIgtxw8JzsKtdw8M1Sy4fK3akFPOkw3aanqFf5N4eLJAXA?= =?us-ascii?Q?S9XLS3yaImJg7kb58Y8eiSS1HUHtOj/DVPCLumhTF+bPFnS6Itw2lh5k1Hnd?= =?us-ascii?Q?PvATsnZVt7y+vrmi7sRCHoW2a66cj8PTRfTFEZUy/+OIaQpqKISqMZ7cJKkd?= =?us-ascii?Q?pn3NauZqI45+jTIcuA86qEzvm2aMpRV0tRRU7tlh2+Oqqew96vwEpz6pPWEM?= =?us-ascii?Q?ybwGh02cGRZhwn1X7ECvfPS5/1l+CcSrphkMRZfBWN049A6zH8BtpW7L03Cv?= =?us-ascii?Q?bStZzA2oFTYuiwwC3IonyX7YyKxipb6PU7d9XbO/R30zyb2ljXvPTL+1kQfo?= =?us-ascii?Q?xT1En0jnGhH9AnfE/2epLM8EY0lfWPSJOQ+2FAbOaTJZ2cIYuYuuj55IdYWm?= =?us-ascii?Q?WSx0KFhfWXJqUi7iw/pqUU3/MflHuI28sHjNXbdiMFStQ4aHjoctqTBphvpp?= =?us-ascii?Q?QfSWjkLirH2/Y3cOPcE4KJvM17dw9sBK+VDO78RW0CkQ1N3XuzzKnAmOfY0A?= =?us-ascii?Q?RNdUJJZeqUN4tRDnU+I81WXSS/XyuPV8Xtn1+fsasV7yF7xFL+5l50adVQhQ?= =?us-ascii?Q?GiBdX5xWL9rCAMPTfCf5D6H9dp9WRJVxD+nx6nc77B656iIB2StWInsfeih0?= =?us-ascii?Q?5PtxFJ8eaxQtj/FtFQDAzMGl/CfqbbC8VEJayWSgeBJvPgTOoB9axW/Q9E5k?= =?us-ascii?Q?VFjxlfjyPmG94wli8HwdbcihyzytwkbmzV2o8IiZPXw6z6tb1SmFjJ+/euOI?= =?us-ascii?Q?BIJnfYy84tamyMrW2Le0Z+Zbd64YUfkqYzxYCLWt7X4VAlysv5j7t2rlUjtY?= =?us-ascii?Q?rYyO1rwmIjDTZtuw=3D?= X-Microsoft-Exchange-Diagnostics: 1; AM6PR0502MB3798; 6:gNkqk1WAHGoGpziXQKDXvU2Gf1Mtw1Ps0RrZDZVZhV+LobYOfm7DgFwCq1CR4V1gL94eCRb5EvAXKV3a+vl+jKgWU5cbHasCfH0mQiIDfguHn115vMfo7ROESelIsmHEkBN6vwTqEYnVmiq6O8ONxBb5AF30iP7Jx9t56sza3wxGVi6OlzydIWQ2YqZ93SOoGuF0qgpHlE3sLP460LTiFvae8uStbMhu05oNcj9GEPCD20Ej7YXdVqN24Rd65lj2hZSn9Mag+9UFh2wJ28vfivD2tXwf4X/AsrghKp6ZZ4ZQCXHettVMYehC8x78NumC/AVD1ybzq0y4ALdJX+rpUta9y2LpQRGmyz+3ok5pN8c=; 5:/srTPACGThwyOsbmGkJKeAzn/rP6T549BSPMMMDPQFtVd/5bzjSGXWiVxg6GJ3GK3PuVgnaN9W/sI3jCSpJ7oWy9BmBtfxRM2e1kAjluHL+3v9FLAIVccVrzfSCp71uLORrJ+4jZT4hMRugu5z6+mlEdSmM4boK3AyuJtDay58o=; 24:Md3cvJta2IXJKLqnlhK2FSYccu3rycmIrb4s2MzzWpE69yGC3J8ZOT8I4ntQppEs+5IlAtAWoTXtqI6smvs4QuR3i9R2IN72cRmn8d2KLtw=; 7:pBrfR88Nr0GaJhwDrt938Gkq68G/xYj4gqEbVLS8jG15qBGp9DhTi2jORL2PxKWh5hFAag0iaOUHS48e2gNcadYW6wPzGUgKWg465AbbJEDVSX4brxLB8nxApGO3WHibR/+syi3cRnulisd5zjrJoSeeK7g2ElRvTaCZ+o6uw+rw83sAwvNkcBTBdIDkxzZZSHorogEXwLK4zvpenWSHJNRJjeQaw7ggf40ESvTWBndgXadHtJ3xrYJQI1xc/4Gt SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2018 13:51:57.8595 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5bbf7b95-8c68-454f-7fa8-08d55e7aa4cf X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0502MB3798 Subject: [dpdk-dev] [PATCH v6 1/8] net/failsafe: fix invalid free X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jan 2018 13:52:00 -0000 From: Adrien Mazarguil rte_free() is not supposed to work with pointers returned by calloc(). Fixes: a0194d828100 ("net/failsafe: add flexible device definition") Cc: stable@dpdk.org Cc: Gaetan Rivet Signed-off-by: Adrien Mazarguil Acked-by: Gaetan Rivet --- drivers/net/failsafe/failsafe_args.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/failsafe/failsafe_args.c b/drivers/net/failsafe/failsafe_args.c index cfc83e3..ec63ac9 100644 --- a/drivers/net/failsafe/failsafe_args.c +++ b/drivers/net/failsafe/failsafe_args.c @@ -407,7 +407,7 @@ typedef int (parse_cb)(struct rte_eth_dev *dev, const char *params, uint8_t i; FOREACH_SUBDEV(sdev, i, dev) { - rte_free(sdev->cmdline); + free(sdev->cmdline); sdev->cmdline = NULL; free(sdev->devargs.args); sdev->devargs.args = NULL; -- 1.8.3.1