* [dpdk-dev] [PATCH] app/testpmd: change log level at run time
@ 2018-01-19 22:19 Elza Mathew
2018-01-20 1:23 ` Ferruh Yigit
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Elza Mathew @ 2018-01-19 22:19 UTC (permalink / raw)
To: wenzhuo.lu, jingjing.wu; +Cc: dev
Introduced a run time command to change the
log level for a given log type. Added the
necessary documentation.
Signed-off-by: Elza Mathew <elza.mathew@intel.com>
---
app/test-pmd/cmdline.c | 53 +++++++++++++++++++++++++++++
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 19 +++++++++++
2 files changed, 72 insertions(+)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index f7d5bb0..56b2fb6 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -274,6 +274,9 @@ static void cmd_help_long_parsed(void *parsed_result,
"set verbose (level)\n"
" Set the debug verbosity level X.\n\n"
+ "set log global|(type) (level)\n"
+ " Set the log level.\n\n"
+
"set nbport (num)\n"
" Set number of ports.\n\n"
@@ -3055,6 +3058,55 @@ static void cmd_set_parsed(void *parsed_result,
},
};
+/* *** SET LOG LEVEL CONFIGURATION *** */
+
+struct cmd_set_log_result {
+ cmdline_fixed_string_t set;
+ cmdline_fixed_string_t log;
+ cmdline_fixed_string_t type;
+ uint32_t level;
+};
+
+static void
+cmd_set_log_parsed(void *parsed_result,
+ __attribute__((unused)) struct cmdline *cl,
+ __attribute__((unused)) void *data)
+{
+ struct cmd_set_log_result *res;
+ int ret;
+
+ res = parsed_result;
+ if (!strcmp(res->type, "global"))
+ rte_log_set_global_level(res->level);
+ else {
+ ret = rte_log_set_level_regexp(res->type, res->level);
+ if (ret < 0)
+ printf("Unable to set log level\n");
+ }
+}
+
+cmdline_parse_token_string_t cmd_set_log_set =
+ TOKEN_STRING_INITIALIZER(struct cmd_set_log_result, set, "set");
+cmdline_parse_token_string_t cmd_set_log_log =
+ TOKEN_STRING_INITIALIZER(struct cmd_set_log_result, log, "log");
+cmdline_parse_token_string_t cmd_set_log_type =
+ TOKEN_STRING_INITIALIZER(struct cmd_set_log_result, type, NULL);
+cmdline_parse_token_num_t cmd_set_log_level =
+ TOKEN_NUM_INITIALIZER(struct cmd_set_log_result, level, UINT32);
+
+cmdline_parse_inst_t cmd_set_log = {
+ .f = cmd_set_log_parsed,
+ .data = NULL,
+ .help_str = "set log global|<type> <level>",
+ .tokens = {
+ (void *)&cmd_set_log_set,
+ (void *)&cmd_set_log_log,
+ (void *)&cmd_set_log_type,
+ (void *)&cmd_set_log_level,
+ NULL,
+ },
+};
+
/* *** SET SEGMENT LENGTHS OF TXONLY PACKETS *** */
struct cmd_set_txpkts_result {
@@ -16026,6 +16078,7 @@ struct cmd_cmdfile_result {
(cmdline_parse_inst_t *)&cmd_set_link_down,
(cmdline_parse_inst_t *)&cmd_reset,
(cmdline_parse_inst_t *)&cmd_set_numbers,
+ (cmdline_parse_inst_t *)&cmd_set_log,
(cmdline_parse_inst_t *)&cmd_set_txpkts,
(cmdline_parse_inst_t *)&cmd_set_txsplit,
(cmdline_parse_inst_t *)&cmd_set_fwd_list,
diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index d8c9ef0..3c55eb6 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -505,6 +505,25 @@ When retry is enabled, the transmit delay time and number of retries can also be
testpmd> set burst tx delay (microseconds) retry (num)
+set log
+~~~~~~~
+
+Set the log level for a log type::
+
+ testpmd> set log global|(type) (level)
+
+Where:
+
+* ``type`` is the log name.
+
+* ``level`` is the log level.
+
+For example, to change the global log level::
+ testpmd> set log global (level)
+
+Regexes can also be used for type. To change log level of user1, user2 and user3::
+ testpmd> set log user[1-3] (level)
+
set txpkts
~~~~~~~~~~
--
1.9.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] app/testpmd: change log level at run time
2018-01-19 22:19 [dpdk-dev] [PATCH] app/testpmd: change log level at run time Elza Mathew
@ 2018-01-20 1:23 ` Ferruh Yigit
2018-01-20 14:29 ` Thomas Monjalon
2018-01-22 22:09 ` [dpdk-dev] [PATCH v2] " Elza Mathew
2 siblings, 0 replies; 5+ messages in thread
From: Ferruh Yigit @ 2018-01-20 1:23 UTC (permalink / raw)
To: Elza Mathew, wenzhuo.lu, jingjing.wu; +Cc: dev
On 1/19/2018 10:19 PM, Elza Mathew wrote:
> Introduced a run time command to change the
> log level for a given log type. Added the
> necessary documentation.
>
> Signed-off-by: Elza Mathew <elza.mathew@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: change log level at run time
2018-01-19 22:19 [dpdk-dev] [PATCH] app/testpmd: change log level at run time Elza Mathew
2018-01-20 1:23 ` Ferruh Yigit
@ 2018-01-20 14:29 ` Thomas Monjalon
2018-01-22 22:09 ` [dpdk-dev] [PATCH v2] " Elza Mathew
2 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2018-01-20 14:29 UTC (permalink / raw)
To: Elza Mathew; +Cc: dev, wenzhuo.lu, jingjing.wu
19/01/2018 23:19, Elza Mathew:
> @@ -16026,6 +16078,7 @@ struct cmd_cmdfile_result {
> (cmdline_parse_inst_t *)&cmd_set_link_down,
> (cmdline_parse_inst_t *)&cmd_reset,
> (cmdline_parse_inst_t *)&cmd_set_numbers,
> + (cmdline_parse_inst_t *)&cmd_set_log,
> (cmdline_parse_inst_t *)&cmd_set_txpkts,
> (cmdline_parse_inst_t *)&cmd_set_txsplit,
> (cmdline_parse_inst_t *)&cmd_set_fwd_list,
> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> index d8c9ef0..3c55eb6 100644
> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> @@ -505,6 +505,25 @@ When retry is enabled, the transmit delay time and number of retries can also be
>
> testpmd> set burst tx delay (microseconds) retry (num)
>
> +set log
> +~~~~~~~
> +
> +Set the log level for a log type::
> +
> + testpmd> set log global|(type) (level)
> +
> +Where:
> +
> +* ``type`` is the log name.
> +
> +* ``level`` is the log level.
> +
> +For example, to change the global log level::
> + testpmd> set log global (level)
> +
> +Regexes can also be used for type. To change log level of user1, user2 and user3::
> + testpmd> set log user[1-3] (level)
> +
> set txpkts
> ~~~~~~~~~~
I know that testpmd code and doc are a bit messy,
but maybe we can find a better place for this command
in the doc and in the code.
As it is very generic, I think it should be one of the first commands.
^ permalink raw reply [flat|nested] 5+ messages in thread* [dpdk-dev] [PATCH v2] app/testpmd: change log level at run time
2018-01-19 22:19 [dpdk-dev] [PATCH] app/testpmd: change log level at run time Elza Mathew
2018-01-20 1:23 ` Ferruh Yigit
2018-01-20 14:29 ` Thomas Monjalon
@ 2018-01-22 22:09 ` Elza Mathew
2018-01-31 22:15 ` Thomas Monjalon
2 siblings, 1 reply; 5+ messages in thread
From: Elza Mathew @ 2018-01-22 22:09 UTC (permalink / raw)
To: jingjing.wu, wenzhuo.lu; +Cc: dev
Introduced a run time command to change the
log level for a given log type. Added the
necessary documentation.
V2: Changed the position of the command in
the documentation since generic commands
are placed at the beginning.
Signed-off-by: Elza Mathew <elza.mathew@intel.com>
---
app/test-pmd/cmdline.c | 53 +++++++++++++++++++++++++++++
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 19 +++++++++++
2 files changed, 72 insertions(+)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 9f12c0f..c9b2b57 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -274,6 +274,9 @@ static void cmd_help_long_parsed(void *parsed_result,
"set verbose (level)\n"
" Set the debug verbosity level X.\n\n"
+ "set log global|(type) (level)\n"
+ " Set the log level.\n\n"
+
"set nbport (num)\n"
" Set number of ports.\n\n"
@@ -3055,6 +3058,55 @@ static void cmd_set_parsed(void *parsed_result,
},
};
+/* *** SET LOG LEVEL CONFIGURATION *** */
+
+struct cmd_set_log_result {
+ cmdline_fixed_string_t set;
+ cmdline_fixed_string_t log;
+ cmdline_fixed_string_t type;
+ uint32_t level;
+};
+
+static void
+cmd_set_log_parsed(void *parsed_result,
+ __attribute__((unused)) struct cmdline *cl,
+ __attribute__((unused)) void *data)
+{
+ struct cmd_set_log_result *res;
+ int ret;
+
+ res = parsed_result;
+ if (!strcmp(res->type, "global"))
+ rte_log_set_global_level(res->level);
+ else {
+ ret = rte_log_set_level_regexp(res->type, res->level);
+ if (ret < 0)
+ printf("Unable to set log level\n");
+ }
+}
+
+cmdline_parse_token_string_t cmd_set_log_set =
+ TOKEN_STRING_INITIALIZER(struct cmd_set_log_result, set, "set");
+cmdline_parse_token_string_t cmd_set_log_log =
+ TOKEN_STRING_INITIALIZER(struct cmd_set_log_result, log, "log");
+cmdline_parse_token_string_t cmd_set_log_type =
+ TOKEN_STRING_INITIALIZER(struct cmd_set_log_result, type, NULL);
+cmdline_parse_token_num_t cmd_set_log_level =
+ TOKEN_NUM_INITIALIZER(struct cmd_set_log_result, level, UINT32);
+
+cmdline_parse_inst_t cmd_set_log = {
+ .f = cmd_set_log_parsed,
+ .data = NULL,
+ .help_str = "set log global|<type> <level>",
+ .tokens = {
+ (void *)&cmd_set_log_set,
+ (void *)&cmd_set_log_log,
+ (void *)&cmd_set_log_type,
+ (void *)&cmd_set_log_level,
+ NULL,
+ },
+};
+
/* *** SET SEGMENT LENGTHS OF TXONLY PACKETS *** */
struct cmd_set_txpkts_result {
@@ -16026,6 +16078,7 @@ struct cmd_cmdfile_result {
(cmdline_parse_inst_t *)&cmd_set_link_down,
(cmdline_parse_inst_t *)&cmd_reset,
(cmdline_parse_inst_t *)&cmd_set_numbers,
+ (cmdline_parse_inst_t *)&cmd_set_log,
(cmdline_parse_inst_t *)&cmd_set_txpkts,
(cmdline_parse_inst_t *)&cmd_set_txsplit,
(cmdline_parse_inst_t *)&cmd_set_fwd_list,
diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index d8c9ef0..f7a709f 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -448,6 +448,25 @@ Set the debug verbosity level::
Currently the only available levels are 0 (silent except for error) and 1 (fully verbose).
+set log
+~~~~~~~
+
+Set the log level for a log type::
+
+ testpmd> set log global|(type) (level)
+
+Where:
+
+* ``type`` is the log name.
+
+* ``level`` is the log level.
+
+For example, to change the global log level::
+ testpmd> set log global (level)
+
+Regexes can also be used for type. To change log level of user1, user2 and user3::
+ testpmd> set log user[1-3] (level)
+
set nbport
~~~~~~~~~~
--
1.9.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH v2] app/testpmd: change log level at run time
2018-01-22 22:09 ` [dpdk-dev] [PATCH v2] " Elza Mathew
@ 2018-01-31 22:15 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2018-01-31 22:15 UTC (permalink / raw)
To: Elza Mathew; +Cc: dev, jingjing.wu, wenzhuo.lu
22/01/2018 23:09, Elza Mathew:
> Introduced a run time command to change the
> log level for a given log type. Added the
> necessary documentation.
>
> V2: Changed the position of the command in
> the documentation since generic commands
> are placed at the beginning.
>
> Signed-off-by: Elza Mathew <elza.mathew@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-01-31 22:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-19 22:19 [dpdk-dev] [PATCH] app/testpmd: change log level at run time Elza Mathew
2018-01-20 1:23 ` Ferruh Yigit
2018-01-20 14:29 ` Thomas Monjalon
2018-01-22 22:09 ` [dpdk-dev] [PATCH v2] " Elza Mathew
2018-01-31 22:15 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).