* [dpdk-dev] [PATCH] vfio: fix error check when checking if vfio is enabled
@ 2017-12-22 10:30 Anatoly Burakov
2018-01-12 15:02 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Anatoly Burakov @ 2017-12-22 10:30 UTC (permalink / raw)
To: dev; +Cc: viktorin, stable
rte_eal_check_module() might return -1, which would have been a
"not false" condition for mod_available. Fix that to only report
vfio being enabled if rte_eal_check_module() returns 1.
Fixes: 221f7c220d6b ("vfio: move global config out of PCI files")
Cc: viktorin@rehivetech.com
Cc: stable@dpdk.org
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
lib/librte_eal/linuxapp/eal/eal_vfio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal_vfio.c b/lib/librte_eal/linuxapp/eal/eal_vfio.c
index 58f0123..fb1a622 100644
--- a/lib/librte_eal/linuxapp/eal/eal_vfio.c
+++ b/lib/librte_eal/linuxapp/eal/eal_vfio.c
@@ -525,7 +525,7 @@ rte_vfio_enable(const char *modname)
int
rte_vfio_is_enabled(const char *modname)
{
- const int mod_available = rte_eal_check_module(modname);
+ const int mod_available = rte_eal_check_module(modname) > 0;
return vfio_cfg.vfio_enabled && mod_available;
}
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] vfio: fix error check when checking if vfio is enabled
2017-12-22 10:30 [dpdk-dev] [PATCH] vfio: fix error check when checking if vfio is enabled Anatoly Burakov
@ 2018-01-12 15:02 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2018-01-12 15:02 UTC (permalink / raw)
To: Anatoly Burakov; +Cc: stable, dev, viktorin
22/12/2017 11:30, Anatoly Burakov:
> rte_eal_check_module() might return -1, which would have been a
> "not false" condition for mod_available. Fix that to only report
> vfio being enabled if rte_eal_check_module() returns 1.
>
> Fixes: 221f7c220d6b ("vfio: move global config out of PCI files")
> Cc: viktorin@rehivetech.com
> Cc: stable@dpdk.org
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-12 15:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-22 10:30 [dpdk-dev] [PATCH] vfio: fix error check when checking if vfio is enabled Anatoly Burakov
2018-01-12 15:02 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).