From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00071.outbound.protection.outlook.com [40.107.0.71]) by dpdk.org (Postfix) with ESMTP id 7F49B727A for ; Tue, 23 Jan 2018 09:11:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=lVHfI0t/30s4NsSOWvxMxpJXLp6/3qfOxl95o2mN0fo=; b=lU1Cp2UHc35lI8+rMhi0T8kgUbf5aj0G0GomBLEwQkYOKPO1GboB5/HmddhKLAbkVcyna67bkaRKVKK8lvLqljpr5sdOjc2nMtjaxaOwVTXmHPSD/c0VB0xlGAMQlX+oIA0Jemgx0UA1Vvg4yIzygXu0tXiAMlZJzoea4vj0Wt8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=motih@mellanox.com; Received: from mellanox.com (37.142.13.130) by HE1PR05MB3212.eurprd05.prod.outlook.com (2603:10a6:7:35::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.428.17; Tue, 23 Jan 2018 08:11:35 +0000 From: Moti Haimovsky To: wenzhuo.lu@intel.com, thomas@monjalon.net Cc: dev@dpdk.org, Moti Haimovsky Date: Tue, 23 Jan 2018 10:11:21 +0200 Message-Id: <1516695081-178919-1-git-send-email-motih@mellanox.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: AM5PR0701CA0024.eurprd07.prod.outlook.com (2603:10a6:203:51::34) To HE1PR05MB3212.eurprd05.prod.outlook.com (2603:10a6:7:35::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: c8c97bf9-5866-4479-4471-08d56238ec76 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(4534145)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:HE1PR05MB3212; X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB3212; 3:aTShqjRScOVf7HhfMfnJYC12WlRzw9baG3y/UE/5QvVgXbUzBfvt2sSxOeCICLjcSnSx3VaAmAJd/nORdANeTfZtFbE+duMBhfbrUoQlPG5sPapt9vi/XvEabIl7HXjWwuwmECTpkVxS8npOwiys7g+3KZpBx2YYnIQa+DETLbiomHeAi2xAoBDttvnZXRRzhTKT5W5OAiJHxsizDjRD6wKH5pxHgWV6D4n3iPAGNTUjWAmuCEMe5wCd4AhHI9Qy; 25:wDt5hnYTGti+h4isJxXwMZe0bvpehCd7UeeBPTT+hkBPjQ9mwNTXtC3ch83g5la1cCpqXQJpjihmrmUA/elhCo1HhtG01LfJ68kg6k7U70lWMSXqi6Cg/hbCrnRrqzCzwl8Bcb33XnsFFM1IQs+LFvn+dQebha9V1OTFeJ+3KeqCrm9Wt3+xFKuQbmmonsdJwPXCXWAXOSo3k9LWY52p9shFIuOAPBgA1VXm0ysajK5wGD5e13KWtz8sI9jLDEnlNrUEgX4uGpy6ic2WiYnb1hTTzL3yhRWtRMsNPRx1u2lPtx5M524DDzs3NkFxEEnbtNUfzF3HbXNT5iAuUHdWBA==; 31:8Cb40FHE7QEVzm0CR5Pr4BfIU+5ydAG/R7GWR/wAZftYipKXRoXAApFFVj3HHmSPKi9EES3bvl6YYElbOadDAJpVkw6nspizXNkWxelOR1QtCGA0QUW+ayjU8ZI18OXOIyVlwVUKlqOnvsoz1EWODNN1lelncZI8Y7q8lrcfgUHM76oVDNMmU9oadIjOeVT06u125dxoxZAjCE7z7euKzCbexMNaY3HsYOSnjdxEJCs= X-MS-TrafficTypeDiagnostic: HE1PR05MB3212: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB3212; 20:MOd+670QmVmnfqMG5sav9o4t7Or4gXcDme2uDPMNtQmb3+5k82F37xFM1L9BZYBOGe5m5u51L4zJVUXPEF/kZVuZdqVSmAKJSORRLqeBg156DjFb2r34chlHSvKtxa1Vy509e083siCkxJSroyphMzqsh7PKeygy0vH65Y2FTh1gAcOUqjU49F+bkgANBWCqQFmb69mYsvcpB4x0Acyy6+SbJ7PfAVnbIkUA24jOxwjNa5KYLmfvAqk3tjG7RMzcPuu9tyk14/WhhpM8eYJJA0rLbVLQO5ot6BoIXiY7J7kvYP8Q2MS6I+JP41eIbSWgid22AB2+Gp5JhNi2m2xenApUqO/j6BIb5G4/zuWjkzQ1Po1TOvM7dIpDOo3JJxku3sFdcDIXyu/lkH970fvKcQght9x3VJpo4hGjoNWihoJhJvBZ3l3g259PGau4OwuAH6Y9vww4O/40HFlg1hZ7dXEZqrUH9GcWtSgZJqlvZFSs7WnNwlySICAiHFgQSIE0; 4:vYG7tglBy85RvMIdQ3toAQgYk63nuefwMv0CUD8N+TsnyhomhOtXSftrDmp3X5oKHSXFwAsIovQEUh2qChvBNukWSLkHN7iXNdb6Eg8Yq6yU/vqGvgq+tZQ3MVMxhJAaazmyQXBE6SnFljqhpYgXylJnsQExkVYMt0iuAzQfhPfLc/5zK7HZdZxhu86sCoobHjgbwCDT/U5sq32kgC4Xu4E/xh5yWfEvdEzkXotXm6es21XAhxQCsxsjD5TVZpe2gFC6ubCK6pKK6hNHg6VqlA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(3231023)(2400081)(944501161)(6055026)(6041288)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(6072148)(201708071742011); SRVR:HE1PR05MB3212; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:HE1PR05MB3212; X-Forefront-PRVS: 05610E64EE X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(376002)(396003)(39380400002)(346002)(189003)(199004)(3846002)(106356001)(68736007)(5660300001)(50226002)(6116002)(2906002)(305945005)(7736002)(53936002)(386003)(48376002)(33026002)(50466002)(69596002)(36756003)(97736004)(7696005)(52116002)(47776003)(51416003)(105586002)(66066001)(8676002)(16526018)(6666003)(55016002)(26005)(81156014)(107886003)(21086003)(4326008)(316002)(86362001)(25786009)(81166006)(478600001)(4720700003)(8936002)(16586007); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR05MB3212; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR05MB3212; 23:issbIysYX1I5mobcd7fORKyT6+gWfUwWB8T8oZ3Yp?= =?us-ascii?Q?liYEfn1e4eSnn4CAEnjwbOPIikv0Oppdgm3NmKWRTuWq4TaNhB/d+iGZ1+26?= =?us-ascii?Q?CNHWJUArSvPj4s0HMwSAphImdg7YsGmxz6jtHZb5PIKDH8h/ZnDuA3/K03Jb?= =?us-ascii?Q?o4K6OsRPnaAOGPA1DLt+FLC+rT9VCtYrCTanc8lUQcZHJ0VJyut8ZGO7ngqS?= =?us-ascii?Q?97PToQl6iPLq+pUEXEB8ljyvkRfh44zwGXEeCcxShgpvqKMQStCM/ta5evaU?= =?us-ascii?Q?W9xdzIaDsQeiGFlQodYLpjuriA2HBg5dFZzqsGGjCk2e0Aez2G57bICypkKP?= =?us-ascii?Q?FR/cknS6hTL72mjZDPUZDaFrBcIkIKrvJwU4mWKjE0R+NLUZV8bRtIhG/xSv?= =?us-ascii?Q?XnhOEBLBLW9t9qBfNUy79tGwFfBlTjo2iUxXMtjXld7xczQohL5ff3PoFJ9Z?= =?us-ascii?Q?ukTBMi0lsII+ZrdXnyNLGdZ+jRyLOWdGxCDYd3pRzv18l/0dRvoeEHxFG24N?= =?us-ascii?Q?4Y1scuXWtmUAv5f2kT4l2z5JSFf2eP0MRJMuLfGpKhNI7Nn71GgaTk0d0Cnn?= =?us-ascii?Q?qb4KpzF5a8a8l3TylW+jqeZBQTeHAqlNZSpK0PyztKoVdcV7S6pxWkAHVYej?= =?us-ascii?Q?neOPEYQDMxtDjZbtkfujrV65sZfz/2IyaN9PQOCE3RpobO9SCEY3Ir/1O62u?= =?us-ascii?Q?2raQxHSM7wgH9nqtM4PbFGwaz19eD/V3AaC3DoLX+5u8Aa6ZODhOChS3q0ET?= =?us-ascii?Q?nDcC+YVuYDlCjh0iWDnCxZ1WbmG63OA+XjOWhAvKOiU7TQi8J8Lw3kk4/uJG?= =?us-ascii?Q?zY2ZL4rWybNXfqFevTNF3fswvdm6LnugpFlcblRk2DWBI1+IP1wIrX/Ofo8L?= =?us-ascii?Q?/grMI57y4nzLIrvFTub8bl92jedYeq3y9LMdLFDbS6vb/rtzGan50yG2jicX?= =?us-ascii?Q?N5EjQmA/46wA3MmgfPk/IzYTt+yqyjqAb2MFWETEW50t1v+rWZYfKZbH00xx?= =?us-ascii?Q?idN+AcdKPawEQj2TT5q9pY2Ik341CpIum315vrO1Fu+GiLGX48kZjUI5J6+G?= =?us-ascii?Q?2FMzqgjqpzgkaA4d9LQZ/mwPVEnjfG7enxmI6ZM5l6V0/Q1MHHmUPXmwu+Lr?= =?us-ascii?Q?oIYpfGoehI=3D?= X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB3212; 6:IhljfsIB5q4bvx/nr5wMpI/7UcdTO66HuwV63BlYinycFu0TXe8pO0zFEhQOCt0C0+7XvzwvC3vf3K9PAAuX74AhmMR4UKtIVWK90V81m79dXgf9tqEEEmPMQIsKSi47ftnzPiNpnVEyBXjb6jkPjD6Pe1OPfb7YU0gp1+kuKC1xmSwE2dIl5qMmMWkVRExOIUI7UZM+mnN0iQ7y3OWFBs049sgj4PB2ZselGI2BXJDjRarP0aOX4DwEOp5Y+IZiOQk6KS2F3arrMo5Dt0n8Cy3XGbcdfnipjIMqazf994sqal0YLXkNDLEF8Kxi4wqtwn98hbcBpMioyCksp8nFwnZeynbEhrKRadM4dUYyhLs=; 5:HlIpYrh2JkExJoLHSBrcvwvJJKhA70wz6iG8P0wNq7QeY0kWrcMN520UmQP4nFS9ZOW8HveTlvCwpQDNZrkoViUdyl6DLIje3CsMsmIySYcCX8fyDsaycXSlbWlCtfeQ705gOLUVouEUitI3ODNkndAZzFBSPbK8cZ8sKHiVrcQ=; 24:57dku0vbcFof7Qq0TADZTlCKVfQww/xoaqXdu5XSZKlM8Yy1FUF6Ca4vUldYP8cCiiBvMbVqRVdRoFfJ27ZatSd/OLWCJeMGPFPUiiz3dxA=; 7:f/u2PrgqPYpWHffJ8EdmR4v0+AB0TesAeTAQreugUxDCs1QacY1FOMrkbmAckry4qLA8Zb0h5fz2vmEKIPOmJBlU0q6m1phddYe9ULTmJ28Ox/kzkSBOow5y9NiLmxOvjetw6XVLw9LoZfMnbb0dq4clLDroBCsoBYBlcvFd581ebE6Myx8ZoTV4wJHnsAOyOXoCBu0HfALY0bSABzoGBjtT+05+tAuzFR0q33VeIV8Yv2z+wkBXVGCJUc0P56de SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2018 08:11:35.8907 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c8c97bf9-5866-4479-4471-08d56238ec76 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB3212 Subject: [dpdk-dev] [PATCH] app/testpmd: do not enable Rx offloads by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jan 2018 08:11:38 -0000 Removed the hardcoded preconfigured Rx offload configuration from testpmd. Testers who wish to use these offloads will now have to explicitly write them in the command-line when running testpmd. Motivation: Some PMDs such at the mlx4 may not implement all the offloads. After the offload API rework assuming no offload is enabled by default, commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") trying to enable a not supported offload is clearly an error which will cause configuration failing. Considering that testpmd is an application to test the PMD, it should not fail on a configuration which was not explicitly requested. The behavior of this test application is then turned to an opt-in model. Signed-off-by: Moti Haimovsky --- app/test-pmd/testpmd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 5dc8cca..a082352 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -305,9 +305,7 @@ struct fwd_engine * fwd_engines[] = { */ struct rte_eth_rxmode rx_mode = { .max_rx_pkt_len = ETHER_MAX_LEN, /**< Default maximum frame length. */ - .offloads = (DEV_RX_OFFLOAD_VLAN_FILTER | - DEV_RX_OFFLOAD_VLAN_STRIP | - DEV_RX_OFFLOAD_CRC_STRIP), + .offloads = 0, .ignore_offload_bitfield = 1, }; -- 1.8.3.1