[dpdk-dev] [PATCH 0/5] ARMv8: enable DPAA-X driver compilation

[dpdk-dev] [PATCH 0/5] ARMv8: enable DPAA-X driver compilation

[Hemant Agrawal]

This patchset enables DPAA drivers compilation for ARM targets.
This also includes patches to fix the DPAA compilation for clang
compiler.

Note that the dpaa(x) specific config files are still preserved
to continue customer support. They also contain some of the ARM
performance tuning flags. e.g the default ARM cache size of 128
is not optimal for NXP platforms.

However, these configs will be cleaned up and eventually be
removed once a dynamic mechanisms are developed to detect the
performance settings.

Hemant Agrawal (5):
  bus/dpaa: fix compilation warnings with clang
  bus/dpaa: fix unused function warning with clang
  crypto/dpaa2_sec: fix enum conversion for GCM
  crypto/dpaa_sec: fix enum conversion for GCM
  config: enable dpaaX drivers compilation for ARMv8

 config/common_armv8a_linuxapp               | 58 +++++++++++++++++++++++++++++
 drivers/bus/dpaa/base/fman/fman.c           |  2 +-
 drivers/bus/dpaa/base/fman/netcfg_layer.c   | 16 --------
 drivers/bus/dpaa/dpaa_bus.c                 |  6 ---
 drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c |  2 +-
 drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h   |  1 +
 drivers/crypto/dpaa_sec/dpaa_sec.h          |  2 +-
 7 files changed, 62 insertions(+), 25 deletions(-)

-- 
2.7.4

[dpdk-dev] [PATCH 1/5] bus/dpaa: fix compilation warnings with clang

[Hemant Agrawal]

fman.c:570:15: error: format specifies type 'unsigned short' but the
argument has type 'int' [-Werror,-Wformat]  __FILE__, __LINE__, __func__,

fman/netcfg_layer.c:80:1: error: unused function 'get_num_netcfg_interfaces
' [-Werror,-Wunused-function] get_num_netcfg_interfaces(char *str)

Fixes: 5b22cf744689 ("bus/dpaa: introducing FMan configurations")
Cc: stable@dpdk.org

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 drivers/bus/dpaa/base/fman/fman.c         |  2 +-
 drivers/bus/dpaa/base/fman/netcfg_layer.c | 16 ----------------
 2 files changed, 1 insertion(+), 17 deletions(-)

diff --git a/drivers/bus/dpaa/base/fman/fman.c b/drivers/bus/dpaa/base/fman/fman.c
index 1dd1f91..bda62e0 100644
--- a/drivers/bus/dpaa/base/fman/fman.c
+++ b/drivers/bus/dpaa/base/fman/fman.c
@@ -566,7 +566,7 @@ fman_finish(void)
 		/* release the mapping */
 		_errno = munmap(__if->ccsr_map, __if->regs_size);
 		if (unlikely(_errno < 0))
-			fprintf(stderr, "%s:%hu:%s(): munmap() = %d (%s)\n",
+			fprintf(stderr, "%s:%d:%s(): munmap() = %d (%s)\n",
 				__FILE__, __LINE__, __func__,
 				-errno, strerror(errno));
 		printf("Tearing down %s\n", __if->node_path);
diff --git a/drivers/bus/dpaa/base/fman/netcfg_layer.c b/drivers/bus/dpaa/base/fman/netcfg_layer.c
index 24186c9..3e956ce 100644
--- a/drivers/bus/dpaa/base/fman/netcfg_layer.c
+++ b/drivers/bus/dpaa/base/fman/netcfg_layer.c
@@ -76,22 +76,6 @@ dump_netcfg(struct netcfg_info *cfg_ptr)
 }
 #endif /* RTE_LIBRTE_DPAA_DEBUG_DRIVER */
 
-static inline int
-get_num_netcfg_interfaces(char *str)
-{
-	char *pch;
-	uint8_t count = 0;
-
-	if (str == NULL)
-		return -EINVAL;
-	pch = strtok(str, ",");
-	while (pch != NULL) {
-		count++;
-		pch = strtok(NULL, ",");
-	}
-	return count;
-}
-
 struct netcfg_info *
 netcfg_acquire(void)
 {
-- 
2.7.4

[dpdk-dev] [PATCH 2/5] bus/dpaa: fix unused function warning with clang

[Hemant Agrawal]

fman/netcfg_layer.c:80:1: error: unused function 'get_num_netcfg_interfaces
' [-Werror,-Wunused-function] get_num_netcfg_interfaces(char *str)

Fixes: 919eeaccb2ba ("bus/dpaa: introduce NXP DPAA bus driver skeleton")
Cc: stable@dpdk.org

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 drivers/bus/dpaa/dpaa_bus.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c
index ba33566..1093b4d 100644
--- a/drivers/bus/dpaa/dpaa_bus.c
+++ b/drivers/bus/dpaa/dpaa_bus.c
@@ -63,12 +63,6 @@ dpaa_add_to_device_list(struct rte_dpaa_device *dev)
 	TAILQ_INSERT_TAIL(&rte_dpaa_bus.device_list, dev, next);
 }
 
-static inline void
-dpaa_remove_from_device_list(struct rte_dpaa_device *dev)
-{
-	TAILQ_INSERT_TAIL(&rte_dpaa_bus.device_list, dev, next);
-}
-
 /*
  * Reads the SEC device from DTS
  * Returns -1 if SEC devices not available, 0 otherwise
-- 
2.7.4

[dpdk-dev] [PATCH 3/5] crypto/dpaa2_sec: fix enum conversion for GCM

[Hemant Agrawal]

dpaa2_sec/dpaa2_sec_dpseci.c:1287:25: error: implicit conversion from
enumeration type 'enum rte_crypto_aead_algorithm' to different enumeration
type 'enum rte_crypto_cipher_algorithm' [-Werror,-Wenum-conversion]
                session->cipher_alg = RTE_CRYPTO_AEAD_AES_GCM;

Fixes: 13273250eec5 ("crypto/dpaa2_sec: support AES-GCM and CTR")
Cc: stable@dpdk.org
Cc: akhil.goyal@nxp.com

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +-
 drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h   | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
index a67d979..80ceaa2 100644
--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
@@ -1284,7 +1284,7 @@ dpaa2_sec_aead_init(struct rte_cryptodev *dev,
 	case RTE_CRYPTO_AEAD_AES_GCM:
 		aeaddata.algtype = OP_ALG_ALGSEL_AES;
 		aeaddata.algmode = OP_ALG_AAI_GCM;
-		session->cipher_alg = RTE_CRYPTO_AEAD_AES_GCM;
+		session->aead_alg = RTE_CRYPTO_AEAD_AES_GCM;
 		break;
 	case RTE_CRYPTO_AEAD_AES_CCM:
 		RTE_LOG(ERR, PMD, "Crypto: Unsupported AEAD alg %u\n",
diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
index c76b082..e8ac95b 100644
--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
@@ -143,6 +143,7 @@ typedef struct dpaa2_sec_session_entry {
 	uint8_t dir;         /*!< Operation Direction */
 	enum rte_crypto_cipher_algorithm cipher_alg; /*!< Cipher Algorithm*/
 	enum rte_crypto_auth_algorithm auth_alg; /*!< Authentication Algorithm*/
+	enum rte_crypto_aead_algorithm aead_alg; /*!< AEAD Algorithm*/
 	union {
 		struct {
 			uint8_t *data;	/**< pointer to key data */
-- 
2.7.4

[dpdk-dev] [PATCH 4/5] crypto/dpaa_sec: fix enum conversion for GCM

[Hemant Agrawal]

dpaa_sec/dpaa_sec.h:297:13: error: implicit conversion from enumeration
type 'enum rte_crypto_aead_algorithm' to different enumeration type 'enum
rte_crypto_auth_algorithm' [-Werror,-Wenum-conversion]
	.algo = RTE_CRYPTO_AEAD_AES_GCM,

Fixes: c3e85bdcc6e6 ("crypto/dpaa_sec: add crypto driver for NXP DPAA platform")
Cc: stable@dpdk.org
Cc: akhil.goyal@nxp.com

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 drivers/crypto/dpaa_sec/dpaa_sec.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.h b/drivers/crypto/dpaa_sec/dpaa_sec.h
index c53d9ae..f45b36c 100644
--- a/drivers/crypto/dpaa_sec/dpaa_sec.h
+++ b/drivers/crypto/dpaa_sec/dpaa_sec.h
@@ -293,7 +293,7 @@ static const struct rte_cryptodev_capabilities dpaa_sec_capabilities[] = {
 		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
 		{.sym = {
 			.xform_type = RTE_CRYPTO_SYM_XFORM_AEAD,
-			{.auth = {
+			{.aead = {
 				.algo = RTE_CRYPTO_AEAD_AES_GCM,
 				.block_size = 16,
 				.key_size = {
-- 
2.7.4

[dpdk-dev] [PATCH 5/5] config: enable dpaaX drivers compilation for ARMv8

[Hemant Agrawal]

This patch enables the NXP DPAA & DPAA2 drivers for
ARMV8 targets. They can be used with standard armv8 config
with command line mempool argument or newly introduced
platform mempool internal registration mechanism.

Note that the dpaa(x) specific config files are still preserved
to continue customer support. They also contain some of the ARM
performance tuning flags. e.g the default ARM cache size of 128
is not optimal for NXP platforms.

However, these configs will eventually be removed once a dynamic
mechanisms are developed to detect the performance settings.

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 config/common_armv8a_linuxapp | 58 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 58 insertions(+)

diff --git a/config/common_armv8a_linuxapp b/config/common_armv8a_linuxapp
index 790e716..572db11 100644
--- a/config/common_armv8a_linuxapp
+++ b/config/common_armv8a_linuxapp
@@ -34,3 +34,61 @@ CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n
 CONFIG_RTE_LIBRTE_AVP_PMD=n
 
 CONFIG_RTE_SCHED_VECTOR=n
+
+#
+# ARMv8 Specific driver compilation flags
+#
+
+#
+# Compile NXP DPAA Bus
+#
+CONFIG_RTE_LIBRTE_DPAA_BUS=y
+CONFIG_RTE_LIBRTE_DPAA_HWDEBUG=n
+
+#
+# Compile NXP DPAA2 FSL-MC Bus
+#
+CONFIG_RTE_LIBRTE_FSLMC_BUS=y
+
+#
+# Compile NXP DPAA Mempool
+#
+CONFIG_RTE_LIBRTE_DPAA_MEMPOOL=y
+
+#
+# Compile NXP DPAA2 Mempool
+#
+CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL=y
+
+#
+# Compile bust-oriented NXP DPAA PMD
+#
+CONFIG_RTE_LIBRTE_DPAA_PMD=y
+
+#
+# Compile burst-oriented NXP DPAA2 PMD driver
+#
+CONFIG_RTE_LIBRTE_DPAA2_PMD=y
+
+#
+# Compile schedule-oriented NXP DPAA Event Dev PMD
+#
+CONFIG_RTE_LIBRTE_PMD_DPAA_EVENTDEV=y
+
+#
+# Compile schedule-oriented NXP DPAA2 EVENTDEV driver
+#
+CONFIG_RTE_LIBRTE_PMD_DPAA2_EVENTDEV=y
+
+#
+# Compile NXP DPAA caam - crypto driver
+#
+CONFIG_RTE_LIBRTE_PMD_DPAA_SEC=y
+CONFIG_RTE_LIBRTE_DPAA_MAX_CRYPTODEV=4
+CONFIG_RTE_DPAA_SEC_PMD_MAX_NB_SESSIONS=2048
+
+#
+# Compile NXP DPAA2 crypto sec driver for CAAM HW
+#
+CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC=y
+CONFIG_RTE_DPAA2_SEC_PMD_MAX_NB_SESSIONS=2048
-- 
2.7.4

Re: [dpdk-dev] [PATCH 5/5] config: enable dpaaX drivers compilation for ARMv8

[Jerin Jacob]

-----Original Message-----
> Date: Thu, 25 Jan 2018 15:23:31 +0530
> From: Hemant Agrawal <hemant.agrawal@nxp.com>
> To: dev@dpdk.org
> CC: jerin.jacob@caviumnetworks.com
> Subject: [PATCH 5/5] config: enable dpaaX drivers compilation for ARMv8
> X-Mailer: git-send-email 2.7.4
> 
> This patch enables the NXP DPAA & DPAA2 drivers for
> ARMV8 targets. They can be used with standard armv8 config
> with command line mempool argument or newly introduced
> platform mempool internal registration mechanism.
> 
> Note that the dpaa(x) specific config files are still preserved
> to continue customer support. They also contain some of the ARM
> performance tuning flags. e.g the default ARM cache size of 128
> is not optimal for NXP platforms.
> 
> However, these configs will eventually be removed once a dynamic
> mechanisms are developed to detect the performance settings.
> 
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
>  config/common_armv8a_linuxapp | 58 +++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 58 insertions(+)
> 
> diff --git a/config/common_armv8a_linuxapp b/config/common_armv8a_linuxapp
> index 790e716..572db11 100644
> --- a/config/common_armv8a_linuxapp
> +++ b/config/common_armv8a_linuxapp
> @@ -34,3 +34,61 @@ CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n
>  CONFIG_RTE_LIBRTE_AVP_PMD=n
>  
>  CONFIG_RTE_SCHED_VECTOR=n
> +
> +#
> +# ARMv8 Specific driver compilation flags
> +#

Will it be better if it is enabled in generic config?

If you have any assembly code then you just stub it for non arm64.
Since these are integrate controllers, I guess, there is no issue in
stubbing the non arm64 specific things.

I believe in that way, it will be maintainable. i.e there will not
any case where arm64 config failing but not non arm64 configs.

On the upside, The common code(ethdev, cryptodev) changes will be build
against your driver by all the developers.

> +
> +#
> +# Compile NXP DPAA Bus
> +#
> +CONFIG_RTE_LIBRTE_DPAA_BUS=y
> +CONFIG_RTE_LIBRTE_DPAA_HWDEBUG=n
> +
> +#
> +# Compile NXP DPAA2 FSL-MC Bus
> +#
> +CONFIG_RTE_LIBRTE_FSLMC_BUS=y
> +
> +#
> +# Compile NXP DPAA Mempool
> +#
> +CONFIG_RTE_LIBRTE_DPAA_MEMPOOL=y
> +
> +#
> +# Compile NXP DPAA2 Mempool
> +#
> +CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL=y
> +
> +#
> +# Compile bust-oriented NXP DPAA PMD
> +#
> +CONFIG_RTE_LIBRTE_DPAA_PMD=y
> +
> +#
> +# Compile burst-oriented NXP DPAA2 PMD driver
> +#
> +CONFIG_RTE_LIBRTE_DPAA2_PMD=y
> +
> +#
> +# Compile schedule-oriented NXP DPAA Event Dev PMD
> +#
> +CONFIG_RTE_LIBRTE_PMD_DPAA_EVENTDEV=y
> +
> +#
> +# Compile schedule-oriented NXP DPAA2 EVENTDEV driver
> +#
> +CONFIG_RTE_LIBRTE_PMD_DPAA2_EVENTDEV=y
> +
> +#
> +# Compile NXP DPAA caam - crypto driver
> +#
> +CONFIG_RTE_LIBRTE_PMD_DPAA_SEC=y
> +CONFIG_RTE_LIBRTE_DPAA_MAX_CRYPTODEV=4
> +CONFIG_RTE_DPAA_SEC_PMD_MAX_NB_SESSIONS=2048
> +
> +#
> +# Compile NXP DPAA2 crypto sec driver for CAAM HW
> +#
> +CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC=y
> +CONFIG_RTE_DPAA2_SEC_PMD_MAX_NB_SESSIONS=2048
> -- 
> 2.7.4
> 

Re: [dpdk-dev] [PATCH 1/5] bus/dpaa: fix compilation warnings with clang

[Shreyansh Jain]

On Thursday 25 January 2018 03:23 PM, Hemant Agrawal wrote:
> fman.c:570:15: error: format specifies type 'unsigned short' but the
> argument has type 'int' [-Werror,-Wformat]  __FILE__, __LINE__, __func__,
> 
> fman/netcfg_layer.c:80:1: error: unused function 'get_num_netcfg_interfaces
> ' [-Werror,-Wunused-function] get_num_netcfg_interfaces(char *str)
> 
> Fixes: 5b22cf744689 ("bus/dpaa: introducing FMan configurations")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---

Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>

Re: [dpdk-dev] [PATCH 2/5] bus/dpaa: fix unused function warning with clang

[Shreyansh Jain]

On Thursday 25 January 2018 03:23 PM, Hemant Agrawal wrote:
> fman/netcfg_layer.c:80:1: error: unused function 'get_num_netcfg_interfaces
> ' [-Werror,-Wunused-function] get_num_netcfg_interfaces(char *str)
> 
> Fixes: 919eeaccb2ba ("bus/dpaa: introduce NXP DPAA bus driver skeleton")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---

Acked-By: Shreyansh Jain <shreyansh.jain@nxp.com>

Re: [dpdk-dev] [PATCH 5/5] config: enable dpaaX drivers compilation for ARMv8

[Hemant Agrawal]

Hi Jerin,

On 1/25/2018 4:51 PM, Jerin Jacob wrote:
> -----Original Message-----
>> Date: Thu, 25 Jan 2018 15:23:31 +0530
>> From: Hemant Agrawal <hemant.agrawal@nxp.com>
>> To: dev@dpdk.org
>> CC: jerin.jacob@caviumnetworks.com
>> Subject: [PATCH 5/5] config: enable dpaaX drivers compilation for ARMv8
>> X-Mailer: git-send-email 2.7.4
>>
>> This patch enables the NXP DPAA & DPAA2 drivers for
>> ARMV8 targets. They can be used with standard armv8 config
>> with command line mempool argument or newly introduced
>> platform mempool internal registration mechanism.
>>
>> Note that the dpaa(x) specific config files are still preserved
>> to continue customer support. They also contain some of the ARM
>> performance tuning flags. e.g the default ARM cache size of 128
>> is not optimal for NXP platforms.
>>
>> However, these configs will eventually be removed once a dynamic
>> mechanisms are developed to detect the performance settings.
>>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> ---
>>   config/common_armv8a_linuxapp | 58 +++++++++++++++++++++++++++++++++++++++++++
>>   1 file changed, 58 insertions(+)
>>
>> diff --git a/config/common_armv8a_linuxapp b/config/common_armv8a_linuxapp
>> index 790e716..572db11 100644
>> --- a/config/common_armv8a_linuxapp
>> +++ b/config/common_armv8a_linuxapp
>> @@ -34,3 +34,61 @@ CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n
>>   CONFIG_RTE_LIBRTE_AVP_PMD=n
>>   
>>   CONFIG_RTE_SCHED_VECTOR=n
>> +
>> +#
>> +# ARMv8 Specific driver compilation flags
>> +#
> 
> Will it be better if it is enabled in generic config?
> 
> If you have any assembly code then you just stub it for non arm64.
> Since these are integrate controllers, I guess, there is no issue in
> stubbing the non arm64 specific things.
> 
> I believe in that way, it will be maintainable. i.e there will not
> any case where arm64 config failing but not non arm64 configs.
> 
> On the upside, The common code(ethdev, cryptodev) changes will be build
> against your driver by all the developers.

It is a good suggestion and we did attempted it and realized that the 
amount of changes required are more than expected.
We will attempt it for next release.

However, if you are ok, please ack it in ARM for now.

Re: [dpdk-dev] [PATCH 5/5] config: enable dpaaX drivers compilation for ARMv8

[Hemant Agrawal]

On 1/30/2018 2:12 PM, Hemant Agrawal wrote:
> Hi Jerin,
> 
> On 1/25/2018 4:51 PM, Jerin Jacob wrote:
>> -----Original Message-----
>>> Date: Thu, 25 Jan 2018 15:23:31 +0530
>>> From: Hemant Agrawal <hemant.agrawal@nxp.com>
>>> To: dev@dpdk.org
>>> CC: jerin.jacob@caviumnetworks.com
>>> Subject: [PATCH 5/5] config: enable dpaaX drivers compilation for ARMv8
>>> X-Mailer: git-send-email 2.7.4
>>>
>>> This patch enables the NXP DPAA & DPAA2 drivers for
>>> ARMV8 targets. They can be used with standard armv8 config
>>> with command line mempool argument or newly introduced
>>> platform mempool internal registration mechanism.
>>>
>>> Note that the dpaa(x) specific config files are still preserved
>>> to continue customer support. They also contain some of the ARM
>>> performance tuning flags. e.g the default ARM cache size of 128
>>> is not optimal for NXP platforms.
>>>
>>> However, these configs will eventually be removed once a dynamic
>>> mechanisms are developed to detect the performance settings.
>>>
>>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>>> ---
>>>   config/common_armv8a_linuxapp | 58 
>>> +++++++++++++++++++++++++++++++++++++++++++
>>>   1 file changed, 58 insertions(+)
>>>
>>> diff --git a/config/common_armv8a_linuxapp 
>>> b/config/common_armv8a_linuxapp
>>> index 790e716..572db11 100644
>>> --- a/config/common_armv8a_linuxapp
>>> +++ b/config/common_armv8a_linuxapp
>>> @@ -34,3 +34,61 @@ CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n
>>>   CONFIG_RTE_LIBRTE_AVP_PMD=n
>>>   CONFIG_RTE_SCHED_VECTOR=n
>>> +
>>> +#
>>> +# ARMv8 Specific driver compilation flags
>>> +#
>>
>> Will it be better if it is enabled in generic config?
>>
>> If you have any assembly code then you just stub it for non arm64.
>> Since these are integrate controllers, I guess, there is no issue in
>> stubbing the non arm64 specific things.
>>
>> I believe in that way, it will be maintainable. i.e there will not
>> any case where arm64 config failing but not non arm64 configs.
>>
>> On the upside, The common code(ethdev, cryptodev) changes will be build
>> against your driver by all the developers.
> 
> It is a good suggestion and we did attempted it and realized that the 
> amount of changes required are more than expected.
> We will attempt it for next release.
> 
> However, if you are ok, please ack it in ARM for now.
> 
> 
I take it back. I figured out easy changes to make it compile for x86 as 
well.

We will submit the v2.

Re: [dpdk-dev] [PATCH 5/5] config: enable dpaaX drivers compilation for ARMv8

[Hemant Agrawal]

On 1/30/2018 3:03 PM, Hemant Agrawal wrote:
> On 1/30/2018 2:12 PM, Hemant Agrawal wrote:
>> Hi Jerin,
>>
>> On 1/25/2018 4:51 PM, Jerin Jacob wrote:
>>> -----Original Message-----
>>>> Date: Thu, 25 Jan 2018 15:23:31 +0530
>>>> From: Hemant Agrawal <hemant.agrawal@nxp.com>
>>>> To: dev@dpdk.org
>>>> CC: jerin.jacob@caviumnetworks.com
>>>> Subject: [PATCH 5/5] config: enable dpaaX drivers compilation for ARMv8
>>>> X-Mailer: git-send-email 2.7.4
>>>>
>>>> This patch enables the NXP DPAA & DPAA2 drivers for
>>>> ARMV8 targets. They can be used with standard armv8 config
>>>> with command line mempool argument or newly introduced
>>>> platform mempool internal registration mechanism.
>>>>
>>>> Note that the dpaa(x) specific config files are still preserved
>>>> to continue customer support. They also contain some of the ARM
>>>> performance tuning flags. e.g the default ARM cache size of 128
>>>> is not optimal for NXP platforms.
>>>>
>>>> However, these configs will eventually be removed once a dynamic
>>>> mechanisms are developed to detect the performance settings.
>>>>
>>>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>>>> ---
>>>>   config/common_armv8a_linuxapp | 58 
>>>> +++++++++++++++++++++++++++++++++++++++++++
>>>>   1 file changed, 58 insertions(+)
>>>>
>>>> diff --git a/config/common_armv8a_linuxapp 
>>>> b/config/common_armv8a_linuxapp
>>>> index 790e716..572db11 100644
>>>> --- a/config/common_armv8a_linuxapp
>>>> +++ b/config/common_armv8a_linuxapp
>>>> @@ -34,3 +34,61 @@ CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n
>>>>   CONFIG_RTE_LIBRTE_AVP_PMD=n
>>>>   CONFIG_RTE_SCHED_VECTOR=n
>>>> +
>>>> +#
>>>> +# ARMv8 Specific driver compilation flags
>>>> +#
>>>
>>> Will it be better if it is enabled in generic config?
>>>
>>> If you have any assembly code then you just stub it for non arm64.
>>> Since these are integrate controllers, I guess, there is no issue in
>>> stubbing the non arm64 specific things.
>>>
>>> I believe in that way, it will be maintainable. i.e there will not
>>> any case where arm64 config failing but not non arm64 configs.
>>>
>>> On the upside, The common code(ethdev, cryptodev) changes will be build
>>> against your driver by all the developers.
>>
>> It is a good suggestion and we did attempted it and realized that the 
>> amount of changes required are more than expected.
>> We will attempt it for next release.
>>
>> However, if you are ok, please ack it in ARM for now.
>>
>>
> I take it back. I figured out easy changes to make it compile for x86 as 
> well.
> 
> We will submit the v2.
> 
I think, we need to leave this patch as it is for this release.

We are running into freebsd issue w.r.t common_base
and 32 bit issues with common_linuxapp.

We will do these changes incrementally in next release.

Re: [dpdk-dev] [PATCH 0/5] ARMv8: enable DPAA-X driver compilation

[Thomas Monjalon]

25/01/2018 10:53, Hemant Agrawal:
> This patchset enables DPAA drivers compilation for ARM targets.
> This also includes patches to fix the DPAA compilation for clang
> compiler.
> 
> Note that the dpaa(x) specific config files are still preserved
> to continue customer support. They also contain some of the ARM
> performance tuning flags. e.g the default ARM cache size of 128
> is not optimal for NXP platforms.
> 
> However, these configs will be cleaned up and eventually be
> removed once a dynamic mechanisms are developed to detect the
> performance settings.
> 
> Hemant Agrawal (5):
>   bus/dpaa: fix compilation warnings with clang
>   bus/dpaa: fix unused function warning with clang
>   crypto/dpaa2_sec: fix enum conversion for GCM
>   crypto/dpaa_sec: fix enum conversion for GCM
>   config: enable dpaaX drivers compilation for ARMv8

First patches are squashed (2nd patch log was not accurate anyway).
Last patch is replaced by the v2.

Series applied, thanks

Re: [dpdk-dev] [PATCH 5/5] config: enable dpaaX drivers compilation for ARMv8

[Jerin Jacob]

-----Original Message-----
> Date: Tue, 30 Jan 2018 20:13:00 +0530
> From: Hemant Agrawal <hemant.agrawal@nxp.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> CC: dev@dpdk.org
> Subject: Re: [PATCH 5/5] config: enable dpaaX drivers compilation for ARMv8
> User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
>  Thunderbird/52.6.0
> 
> On 1/30/2018 3:03 PM, Hemant Agrawal wrote:
> > On 1/30/2018 2:12 PM, Hemant Agrawal wrote:
> > > Hi Jerin,
> > > 
> > > On 1/25/2018 4:51 PM, Jerin Jacob wrote:
> > > > -----Original Message-----
> > > > > Date: Thu, 25 Jan 2018 15:23:31 +0530
> > > > > From: Hemant Agrawal <hemant.agrawal@nxp.com>
> > > > > To: dev@dpdk.org
> > > > > CC: jerin.jacob@caviumnetworks.com
> > > > > Subject: [PATCH 5/5] config: enable dpaaX drivers compilation for ARMv8
> > > > > X-Mailer: git-send-email 2.7.4
> > > > > 
> > > > > This patch enables the NXP DPAA & DPAA2 drivers for
> > > > > ARMV8 targets. They can be used with standard armv8 config
> > > > > with command line mempool argument or newly introduced
> > > > > platform mempool internal registration mechanism.
> > > > > 
> > > > > Note that the dpaa(x) specific config files are still preserved
> > > > > to continue customer support. They also contain some of the ARM
> > > > > performance tuning flags. e.g the default ARM cache size of 128
> > > > > is not optimal for NXP platforms.
> > > > > 
> > > > > However, these configs will eventually be removed once a dynamic
> > > > > mechanisms are developed to detect the performance settings.
> > > > > 
> > > > > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> > > > > ---
> > > > >   config/common_armv8a_linuxapp | 58
> > > > > +++++++++++++++++++++++++++++++++++++++++++
> > > > >   1 file changed, 58 insertions(+)
> > > > > 
> > > > > diff --git a/config/common_armv8a_linuxapp
> > > > > b/config/common_armv8a_linuxapp
> > > > > index 790e716..572db11 100644
> > > > > --- a/config/common_armv8a_linuxapp
> > > > > +++ b/config/common_armv8a_linuxapp
> > > > > @@ -34,3 +34,61 @@ CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n
> > > > >   CONFIG_RTE_LIBRTE_AVP_PMD=n
> > > > >   CONFIG_RTE_SCHED_VECTOR=n
> > > > > +
> > > > > +#
> > > > > +# ARMv8 Specific driver compilation flags
> > > > > +#
> > > > 
> > > > Will it be better if it is enabled in generic config?
> > > > 
> > > > If you have any assembly code then you just stub it for non arm64.
> > > > Since these are integrate controllers, I guess, there is no issue in
> > > > stubbing the non arm64 specific things.
> > > > 
> > > > I believe in that way, it will be maintainable. i.e there will not
> > > > any case where arm64 config failing but not non arm64 configs.
> > > > 
> > > > On the upside, The common code(ethdev, cryptodev) changes will be build
> > > > against your driver by all the developers.
> > > 
> > > It is a good suggestion and we did attempted it and realized that
> > > the amount of changes required are more than expected.
> > > We will attempt it for next release.
> > > 
> > > However, if you are ok, please ack it in ARM for now.
> > > 
> > > 
> > I take it back. I figured out easy changes to make it compile for x86 as
> > well.
> > 
> > We will submit the v2.
> > 
> I think, we need to leave this patch as it is for this release.
> 
> We are running into freebsd issue w.r.t common_base
> and 32 bit issues with common_linuxapp.
> 
> We will do these changes incrementally in next release.

OK. Please make these changes in next release.
Even in the context of meson build, it make sense to move common config.
architecture specific config should be just arch specific things.
Please move to common config in next release.