From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Wei Dai <wei.dai@intel.com>
Cc: dev@dpdk.org, john.mcnamara@intel.com, david.marchand@intel.com
Subject: Re: [dpdk-dev] [PATCH 3/3] eal: remove references to execinfo.h for musl
Date: Fri, 10 Mar 2017 13:40:20 +0100 [thread overview]
Message-ID: <1517181.dliHzHtphb@xps13> (raw)
In-Reply-To: <1489147132-40922-4-git-send-email-wei.dai@intel.com>
2017-03-10 19:58, Wei Dai:
> @@ -47,6 +50,7 @@
> /* dump the stack of the calling core */
> void rte_dump_stack(void)
> {
> +#ifndef RTE_LIBC_MUSL
> void *func[BACKTRACE_SIZE];
> char **symb = NULL;
> int size;
> @@ -64,6 +68,7 @@ void rte_dump_stack(void)
> }
>
> free(symb);
> +#endif
> }
There are probably other libc implementations not supporting this feature.
Instead of calling it "RTE_LIBC_MUSL", it should something like
"ENABLE_BACKTRACE".
Then you can add a musl section in the Linux quick start guide.
next prev parent reply other threads:[~2017-03-10 12:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-10 11:58 [dpdk-dev] [PATCH 0/3] add support of musl Wei Dai
2017-03-10 11:58 ` [dpdk-dev] [PATCH 1/3] examples/performance-thread: remove reference to execinfo.h Wei Dai
2017-03-10 11:58 ` [dpdk-dev] [PATCH 2/3] config: add support of musl Wei Dai
2017-03-10 11:58 ` [dpdk-dev] [PATCH 3/3] eal: remove references to execinfo.h for musl Wei Dai
2017-03-10 12:40 ` Thomas Monjalon [this message]
2017-03-10 14:49 ` Jan Blunck
2017-03-13 8:10 ` Dai, Wei
2017-03-15 8:38 ` Jan Blunck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517181.dliHzHtphb@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=david.marchand@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=wei.dai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).