From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 4B08E6CC1 for ; Fri, 16 Sep 2016 15:20:07 +0200 (CEST) Received: by mail-wm0-f48.google.com with SMTP id b187so36905162wme.1 for ; Fri, 16 Sep 2016 06:20:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=RVVl46wPQpyqpcKYcDDz2HtDxnuT5m6kVwn2eiLUjik=; b=tn5t1s1hxV53jlb1V9m18igMTdEgDHmAVE1gVWOx1Wi0wgFKE6mc6jOlhty40XytJp BU6aDTMR0aJfGoBWHkfQPkwyWK6tOvWG8PLduxQ6Puq10bwWQ6kKXGOCZNKGx+QbTf/1 IKQjROqpQpS+JF72B0kz6D/7OQ1lFDKpyH9UeSuls+xeDsYA3MRu+D+jDVvu5evdURhx zavGpX+iFJiJSLeVVsW8Sj1wI/tEVpaT4tHe9prJ9tUUTXhRz+TMrlsJC0iDmgZ3BW+B 7AqZHcIc/UigCIZTDZuY9JtxkP6ihO8ym7cTMHbiOkojGIdiRY2Tp+3/4cDL/6I4TZ9K eqzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=RVVl46wPQpyqpcKYcDDz2HtDxnuT5m6kVwn2eiLUjik=; b=IP9zDfHd1Hjtke14v8nHas/BdID5VA8aPdoUxcIYPva/FKG/vFLoSxHpRZPCAozyEv EoVd0xIe62j5ttGGz79JKlX2cOj/DAdk3kKpqGB9H/nC1XHxrz6PnrOWz3KNDHQwgQHz MQNqMMgi42cboE5wWFIYsNeCVwgBF3NwONoyEIxm/lOsteE/FYVPdKXSWMy+gWBJD3yp AGoeBMJiEEPkjBtppBmPjo40m1XmvRdjS/Tp/1GLBqi/5PQPCEmUTYb3/ufPsHp9nh5g 836hL8sCKV4sqf86xVZQHjc/FkAh6ZsoVt+7AVPlCBY1od/gYZd8QoRokdq/oQPxK/v9 FW1Q== X-Gm-Message-State: AE9vXwMMmFn3jLAPisDTjsa+iA0OTge041i6nN97F7nvvRuxghaIBa3rkjnr93FkgiunJ0TH X-Received: by 10.28.60.2 with SMTP id j2mr8296971wma.46.1474032006838; Fri, 16 Sep 2016 06:20:06 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id r9sm8446730wjp.15.2016.09.16.06.20.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Sep 2016 06:20:05 -0700 (PDT) From: Thomas Monjalon To: Igor Ryzhov Cc: dev@dpdk.org Date: Fri, 16 Sep 2016 15:20:04 +0200 Message-ID: <1517241.brkdynD5ST@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1470311406-38841-1-git-send-email-iryzhov@nfware.com> References: <1470311406-38841-1-git-send-email-iryzhov@nfware.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] pci: fix one device probing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2016 13:20:07 -0000 2016-08-04 14:50, Igor Ryzhov: > The rte_eal_pci_probe_one function could return false positive result if > no driver is found for the device. > > Signed-off-by: Igor Ryzhov [...] > --- a/lib/librte_eal/common/eal_common_pci.c > +++ b/lib/librte_eal/common/eal_common_pci.c > @@ -344,7 +344,7 @@ rte_eal_pci_probe_one(const struct rte_pci_addr *addr) > continue; > > ret = pci_probe_all_drivers(dev); > - if (ret < 0) > + if (ret) > goto err_return; > return 0; > } This patch was discussed in another thread: http://dpdk.org/ml/archives/dev/2016-August/045127.html Is there anyone thinking this patch is not a step forward?