From: Vipin Varghese <vipin.varghese@intel.com>
To: dev@dpdk.org, nikhil.rao@intel.com
Cc: deepak.k.jain@intel.com, Vipin Varghese <vipin.varghese@intel.com>
Subject: [dpdk-dev] [PATCH] event/rx_adapter: fix ignore return of event start
Date: Wed, 31 Jan 2018 04:26:29 +0530 [thread overview]
Message-ID: <1517352989-11720-1-git-send-email-vipin.varghese@intel.com> (raw)
Capture the return value for rte_event_dev_start. Return the
result back to user.
Coverity issue: 257000
Fixes: 9c38b704d280 ("eventdev: add eth Rx adapter implementation")
Cc: nikhil.rao@intel.com
Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
---
lib/librte_eventdev/rte_event_eth_rx_adapter.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
index 90106e6..a818bef 100644
--- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
@@ -603,7 +603,7 @@ static uint16_t gcd_u16(uint16_t a, uint16_t b)
RTE_EDEV_LOG_ERR("failed to configure event dev %u\n",
dev_id);
if (started)
- rte_event_dev_start(dev_id);
+ ret = rte_event_dev_start(dev_id);
return ret;
}
@@ -617,7 +617,7 @@ static uint16_t gcd_u16(uint16_t a, uint16_t b)
conf->event_port_id = port_id;
conf->max_nb_rx = 128;
if (started)
- rte_event_dev_start(dev_id);
+ ret = rte_event_dev_start(dev_id);
rx_adapter->default_cb_arg = 1;
return ret;
}
--
1.9.1
next reply other threads:[~2018-01-30 22:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 22:56 Vipin Varghese [this message]
2018-01-31 5:32 ` Rao, Nikhil
2018-01-31 6:54 ` Jerin Jacob
2018-02-02 8:08 ` Varghese, Vipin
2018-02-02 10:04 ` Rao, Nikhil
2018-02-02 12:12 ` Jerin Jacob
2018-02-04 18:18 ` [dpdk-dev] [PATCH v2] eventdev: fix unchecked return in default Rx adapter conf cb Nikhil Rao
2018-02-06 19:01 ` Jerin Jacob
2018-02-06 20:24 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517352989-11720-1-git-send-email-vipin.varghese@intel.com \
--to=vipin.varghese@intel.com \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
--cc=nikhil.rao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).