* [dpdk-dev] [PATCH] vhost: fix ANY_LAYOUT definition for old kernels
@ 2018-01-31 14:20 Zhihong Wang
2018-01-31 8:07 ` Maxime Coquelin
0 siblings, 1 reply; 4+ messages in thread
From: Zhihong Wang @ 2018-01-31 14:20 UTC (permalink / raw)
To: yliu; +Cc: dev, jianfeng.tan, maxime.coquelin, Zhihong Wang
This patch fixes compile failure with old kernels which have no
VIRTIO_F_ANY_LAYOUT defined.
Signed-off-by: Zhihong Wang <zhihong.wang@intel.com>
---
lib/librte_vhost/vhost.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
index ba80584..646aad3 100644
--- a/lib/librte_vhost/vhost.h
+++ b/lib/librte_vhost/vhost.h
@@ -130,6 +130,10 @@ struct vhost_virtqueue {
#define VIRTIO_NET_F_MTU 3
#endif
+#ifndef VIRTIO_F_ANY_LAYOUT
+ #define VIRTIO_F_ANY_LAYOUT 27
+#endif
+
/* Declare IOMMU related bits for older kernels */
#ifndef VIRTIO_F_IOMMU_PLATFORM
--
2.7.5
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] vhost: fix ANY_LAYOUT definition for old kernels
2018-01-31 14:20 [dpdk-dev] [PATCH] vhost: fix ANY_LAYOUT definition for old kernels Zhihong Wang
@ 2018-01-31 8:07 ` Maxime Coquelin
2018-01-31 9:32 ` Jerin Jacob
0 siblings, 1 reply; 4+ messages in thread
From: Maxime Coquelin @ 2018-01-31 8:07 UTC (permalink / raw)
To: Zhihong Wang, yliu; +Cc: dev, jianfeng.tan
On 01/31/2018 03:20 PM, Zhihong Wang wrote:
> This patch fixes compile failure with old kernels which have no
> VIRTIO_F_ANY_LAYOUT defined.
>
> Signed-off-by: Zhihong Wang <zhihong.wang@intel.com>
> ---
> lib/librte_vhost/vhost.h | 4 ++++
> 1 file changed, 4 insertions(+)
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
> index ba80584..646aad3 100644
> --- a/lib/librte_vhost/vhost.h
> +++ b/lib/librte_vhost/vhost.h
> @@ -130,6 +130,10 @@ struct vhost_virtqueue {
> #define VIRTIO_NET_F_MTU 3
> #endif
>
> +#ifndef VIRTIO_F_ANY_LAYOUT
> + #define VIRTIO_F_ANY_LAYOUT 27
> +#endif
> +
> /* Declare IOMMU related bits for older kernels */
> #ifndef VIRTIO_F_IOMMU_PLATFORM
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] vhost: fix ANY_LAYOUT definition for old kernels
2018-01-31 8:07 ` Maxime Coquelin
@ 2018-01-31 9:32 ` Jerin Jacob
2018-01-31 11:11 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Jerin Jacob @ 2018-01-31 9:32 UTC (permalink / raw)
To: Maxime Coquelin; +Cc: Zhihong Wang, yliu, dev, jianfeng.tan, thomas
-----Original Message-----
> Date: Wed, 31 Jan 2018 09:07:49 +0100
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> To: Zhihong Wang <zhihong.wang@intel.com>, yliu@fridaylinux.org
> CC: dev@dpdk.org, jianfeng.tan@intel.com
> Subject: Re: [dpdk-dev] [PATCH] vhost: fix ANY_LAYOUT definition for old
> kernels
> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
> Thunderbird/52.5.2
>
>
> On 01/31/2018 03:20 PM, Zhihong Wang wrote:
> > This patch fixes compile failure with old kernels which have no
> > VIRTIO_F_ANY_LAYOUT defined.
> >
> > Signed-off-by: Zhihong Wang <zhihong.wang@intel.com>
> > ---
> > lib/librte_vhost/vhost.h | 4 ++++
> > 1 file changed, 4 insertions(+)
>
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: Thomas Monjalon <thomas@monjalon.net>
This fixes a cross compilation issue with arm64 too.
Tested-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] vhost: fix ANY_LAYOUT definition for old kernels
2018-01-31 9:32 ` Jerin Jacob
@ 2018-01-31 11:11 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2018-01-31 11:11 UTC (permalink / raw)
To: Zhihong Wang; +Cc: dev, Jerin Jacob, Maxime Coquelin, yliu, jianfeng.tan
> > > This patch fixes compile failure with old kernels which have no
> > > VIRTIO_F_ANY_LAYOUT defined.
> > >
> > > Signed-off-by: Zhihong Wang <zhihong.wang@intel.com>
> > > ---
> > > lib/librte_vhost/vhost.h | 4 ++++
> > > 1 file changed, 4 insertions(+)
> >
> > Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>
> Cc: Thomas Monjalon <thomas@monjalon.net>
>
> This fixes a cross compilation issue with arm64 too.
>
> Tested-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Fixes: 5a8bb6e9020f ("vhost: claim to support any layout feature")
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-01-31 11:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-31 14:20 [dpdk-dev] [PATCH] vhost: fix ANY_LAYOUT definition for old kernels Zhihong Wang
2018-01-31 8:07 ` Maxime Coquelin
2018-01-31 9:32 ` Jerin Jacob
2018-01-31 11:11 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).