From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 885545589 for ; Wed, 21 Sep 2016 23:20:16 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id w84so217122962wmg.1 for ; Wed, 21 Sep 2016 14:20:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZnBmpTtOQiwacUuS9d5ui68uMCtA/c85AM03YFpsRTs=; b=rOCuVqiSBEQnmlOPAvdGWl3nKgcJUptfBGnYd3K0vEhoICZeHBdbL3bLf97lE46hZ5 KzYY9JScTxXXKO56GaRu2gsczHbgklJPSSIsw+zSVh36H0oz0BoxQvs54tebwKGBXFV0 jBOFAs5qISq0L3H2Z0ioyD+zsP96/dgHNFSmnGykGWg+FK0TGXZYCFaLA2dcUSDDgrGt CqHHIdnw7P7u9wt0bYKmZ2hWCZDTNY4rpFYSK2g/WFHqtZGTaYANO6F2sDFwUYZwxn8H epoZbhane5XwCohD74zHVXSvTZAxhWmwunygW0/4TrGlPqa09ZfnZSdi1TA8Rryq9avZ Vtsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=ZnBmpTtOQiwacUuS9d5ui68uMCtA/c85AM03YFpsRTs=; b=BobTIKJMZ/lXPg1YinWxrIXJviYGF1oo5LSbvictNMLrW8X5B6JU5QVohMlY/x77iC yYOzHCGAPS/2Pd1VkgODX1bovtwG9oWXPhrehkW8MJgDZxsU9B158TqF8LMTHeNKZosH 5X+7SNluohUf8xLvYsuMIk7KK9BJxcXB7rtRNVvjVn0JGXx0+rvUuaEBlT9QLGicT7Ty K3RYvENz9E7AT8LfgDaMvziXGTsIpKLXhXnCTY2zxllKe9+nkAMVmM+tar5GsBT9R19z 4qZL5j/wlluHWjhuVIq8le6hnbcl03aTkpzSXTFx2n1xxSgSpTfggt3/ULOU6qzb9rnK HTAg== X-Gm-Message-State: AE9vXwM3z1w7rpuZafi4EAQN0mmsrWYzmb6eCJJNJROv6bWm3M9YP3JQ+KEEqYhBKmbti3W8 X-Received: by 10.194.19.67 with SMTP id c3mr33994209wje.90.1474492816281; Wed, 21 Sep 2016 14:20:16 -0700 (PDT) Received: from xps13.localnet (guy78-1-82-235-116-147.fbx.proxad.net. [82.235.116.147]) by smtp.gmail.com with ESMTPSA id jn7sm35422546wjb.5.2016.09.21.14.20.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Sep 2016 14:20:15 -0700 (PDT) From: Thomas Monjalon To: Nikhil Jagtap Cc: dev@dpdk.org, "Dumitrescu, Cristian" , "Ramia, Kannan Babu" Date: Wed, 21 Sep 2016 23:19:04 +0200 Message-ID: <1517417.ujR0TQTeQH@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D8912647A85CB4@IRSMSX108.ger.corp.intel.com> References: <1473228910-10429-1-git-send-email-nikhil.jagtap@gmail.com> <1474437462-6955-1-git-send-email-nikhil.jagtap@gmail.com> <3EB4FA525960D640B5BDFFD6A3D8912647A85CB4@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] meter: fix excess token bucket update in srtcm implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2016 21:20:16 -0000 > > As per srTCM RFC 2697, we should be updating the E bucket only after the > > C bucket overflows. This patch fixes the current DPDK implementation, > > where we are updating both the buckets simultaneously at the same rate > > (CIR) which results in token accumulation rate of (2*CIR). > > > > Signed-off-by: Nikhil Jagtap > > Acked-by: Cristian Dumitrescu Applied, thanks