From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by dpdk.org (Postfix) with ESMTP id EBF711B3ED for ; Tue, 6 Feb 2018 03:21:53 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1FCC01435; Mon, 5 Feb 2018 18:21:53 -0800 (PST) Received: from phil-VirtualBox.shanghai.arm.com (unknown [10.169.109.158]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 259B53F24D; Mon, 5 Feb 2018 18:21:52 -0800 (PST) From: Phil Yang To: dev@dpdk.org Cc: nd@arm.com, phil.yang@arm.com, anatoly.burakov@intel.com, herbert.guan@arm.com Date: Tue, 6 Feb 2018 10:21:38 +0800 Message-Id: <1517883698-12921-1-git-send-email-phil.yang@arm.com> X-Mailer: git-send-email 2.7.4 Subject: [dpdk-dev] [PATCH] test/eal_flags: Optimize memory flags test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2018 02:21:54 -0000 Since RTE_MAX_NUMA_NODES is configurable, the existing socket number could greater than RTE_MAX_NUMA_NODES. Optimize test case to cover this situation.(i.e RTE_MAX_NUMA_NODES=1) Fixes: 45f1b6e8680a ('app: add new tests on eal flags') Signed-off-by: Phil Yang --- test/test/test_eal_flags.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/test/test/test_eal_flags.c b/test/test/test_eal_flags.c index 37c42ef..7df0b8f 100644 --- a/test/test/test_eal_flags.c +++ b/test/test/test_eal_flags.c @@ -33,7 +33,7 @@ #define memtest "memtest" #define memtest1 "memtest1" #define memtest2 "memtest2" -#define SOCKET_MEM_STRLEN (RTE_MAX_NUMA_NODES * 10) +#define SOCKET_MEM_STRLEN (RTE_MAX_NUMA_NODES * 20) #define launch_proc(ARGV) process_dup(ARGV, \ sizeof(ARGV)/(sizeof(ARGV[0])), __func__) @@ -1138,10 +1138,11 @@ test_memory_flags(void) #ifdef RTE_EXEC_ENV_BSDAPP int i, num_sockets = 1; #else - int i, num_sockets = get_number_of_sockets(); + int i, num_sockets = RTE_MIN(get_number_of_sockets(), + RTE_MAX_NUMA_NODES); #endif - if (num_sockets <= 0 || num_sockets > RTE_MAX_NUMA_NODES) { + if (num_sockets <= 0) { printf("Error - cannot get number of sockets!\n"); return -1; } -- 2.7.4