* [dpdk-dev] [PATCH] net/mlx4: update Rx offload capabilities
@ 2018-02-08 11:14 Moti Haimovsky
2018-02-08 12:43 ` Adrien Mazarguil
0 siblings, 1 reply; 3+ messages in thread
From: Moti Haimovsky @ 2018-02-08 11:14 UTC (permalink / raw)
To: adrien.mazarguil; +Cc: thomas, dev, Moti Haimovsky
This patch updates mlx4 Rx offload capabilities to also indicate that
Rx CRC stripping is (always) supported.
Since the device does not support disabeling CRC stripping the PMD
silently ignores such requests.
Signed-off-by: Moti Haimovsky <motih@mellanox.com>
---
drivers/net/mlx4/mlx4_rxq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx4/mlx4_rxq.c b/drivers/net/mlx4/mlx4_rxq.c
index 39268ea..7a036ed 100644
--- a/drivers/net/mlx4/mlx4_rxq.c
+++ b/drivers/net/mlx4/mlx4_rxq.c
@@ -649,7 +649,8 @@ struct mlx4_rss *
uint64_t
mlx4_get_rx_queue_offloads(struct priv *priv)
{
- uint64_t offloads = DEV_RX_OFFLOAD_SCATTER;
+ uint64_t offloads = DEV_RX_OFFLOAD_SCATTER |
+ DEV_RX_OFFLOAD_CRC_STRIP;
if (priv->hw_csum)
offloads |= DEV_RX_OFFLOAD_CHECKSUM;
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx4: update Rx offload capabilities
2018-02-08 11:14 [dpdk-dev] [PATCH] net/mlx4: update Rx offload capabilities Moti Haimovsky
@ 2018-02-08 12:43 ` Adrien Mazarguil
2018-02-08 14:23 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Adrien Mazarguil @ 2018-02-08 12:43 UTC (permalink / raw)
To: Moti Haimovsky; +Cc: thomas, dev
On Thu, Feb 08, 2018 at 01:14:27PM +0200, Moti Haimovsky wrote:
> This patch updates mlx4 Rx offload capabilities to also indicate that
> Rx CRC stripping is (always) supported.
> Since the device does not support disabeling CRC stripping the PMD
disabeling => disabling
> silently ignores such requests.
>
> Signed-off-by: Moti Haimovsky <motih@mellanox.com>
Except for the typo,
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
--
Adrien Mazarguil
6WIND
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx4: update Rx offload capabilities
2018-02-08 12:43 ` Adrien Mazarguil
@ 2018-02-08 14:23 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-02-08 14:23 UTC (permalink / raw)
To: Adrien Mazarguil, Moti Haimovsky; +Cc: thomas, dev
On 2/8/2018 12:43 PM, Adrien Mazarguil wrote:
> On Thu, Feb 08, 2018 at 01:14:27PM +0200, Moti Haimovsky wrote:
>> This patch updates mlx4 Rx offload capabilities to also indicate that
>> Rx CRC stripping is (always) supported.
>> Since the device does not support disabeling CRC stripping the PMD
>
> disabeling => disabling
Fixed while applying.
>> silently ignores such requests.
>>
>> Signed-off-by: Moti Haimovsky <motih@mellanox.com>
>
> Except for the typo,
>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-08 14:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-08 11:14 [dpdk-dev] [PATCH] net/mlx4: update Rx offload capabilities Moti Haimovsky
2018-02-08 12:43 ` Adrien Mazarguil
2018-02-08 14:23 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).