Re: [dpdk-dev] [PATCH v4] i40e: fix TSO issue for tx function

[Thomas Monjalon <thomas.monjalon@6wind.com>]

> > We will not get what we want, the ipv6 packets sent out from IXIA can be
> > received by i40e, but cannot forward to another port.
> > The root cause is when HW doing the TSO offload for packets, it does not only
> > depends on the context descriptor to define the MSS and TSO payload size, it
> > also need to know whether this packets is ipv4 or ipv6, we use
> > i40e_txd_enable_checksum to generate the related fields for data descriptor.
> > But PMD will not call i40e_txd_enable_checksum if only the TSO offload flag is
> > set. The reason why ipv4 works fine for TSO in testpmd csum mode is csum engine
> > will set the ip csum flag when the packet is ipv4 and TSO is enabled but
> > will not set the flag for ipv6 and this flag will cause the
> > i40e_txd_enable_checksum to be invoked. For both the cases the TSO flag will be
> > set, so we need to use TSO flag to trigger the i40e_txd_enable_checksum.
> > The right logic here is we enable csum offload for both ipv4 and ipv6 when TSO
> > flag is set.
> > 
> > Fixes: e3f0151f (i40e: enable Tx checksum only for offloaded packets)
> > 
> > Signed-off-by: Zhe Tao <zhe.tao@intel.com>
> 
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

Applied, thanks