* [dpdk-dev] [PATCH v1 1/2] net/octeontx: fix null pointer dereference
@ 2018-02-20 17:14 Santosh Shukla
2018-02-20 17:14 ` [dpdk-dev] [PATCH v1 2/2] net/octeontx: fix for uninitialized scalar var Santosh Shukla
2018-03-06 17:51 ` [dpdk-dev] [PATCH v1 1/2] net/octeontx: fix null pointer dereference Ferruh Yigit
0 siblings, 2 replies; 4+ messages in thread
From: Santosh Shukla @ 2018-02-20 17:14 UTC (permalink / raw)
To: dev; +Cc: jerin.jacob, Santosh Shukla, stable
Fixes: f18b146c498d ("net/octeontx: create ethdev ports")
Coverity issue: 195040
Cc: stable@dpdk.org
Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
---
drivers/net/octeontx/octeontx_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c
index b739c0b..0d8937c 100644
--- a/drivers/net/octeontx/octeontx_ethdev.c
+++ b/drivers/net/octeontx/octeontx_ethdev.c
@@ -1149,7 +1149,7 @@ octeontx_create(struct rte_vdev_device *dev, int port, uint8_t evdev,
return data->port_id;
err:
- if (port)
+ if (nic)
octeontx_port_close(nic);
if (eth_dev != NULL) {
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread* [dpdk-dev] [PATCH v1 2/2] net/octeontx: fix for uninitialized scalar var
2018-02-20 17:14 [dpdk-dev] [PATCH v1 1/2] net/octeontx: fix null pointer dereference Santosh Shukla
@ 2018-02-20 17:14 ` Santosh Shukla
2018-03-06 17:51 ` [dpdk-dev] [PATCH v1 1/2] net/octeontx: fix null pointer dereference Ferruh Yigit
1 sibling, 0 replies; 4+ messages in thread
From: Santosh Shukla @ 2018-02-20 17:14 UTC (permalink / raw)
To: dev; +Cc: jerin.jacob, Santosh Shukla, stable
Fixes: f18b146c498d ("net/octeontx: create ethdev ports")
Coverity issue: 195045
Cc: stable@dpdk.org
Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
---
drivers/net/octeontx/octeontx_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c
index 0d8937c..f2893fa 100644
--- a/drivers/net/octeontx/octeontx_ethdev.c
+++ b/drivers/net/octeontx/octeontx_ethdev.c
@@ -122,7 +122,7 @@ octeontx_port_open(struct octeontx_nic *nic)
int res;
res = 0;
-
+ memset(&bgx_port_conf, 0x0, sizeof(bgx_port_conf));
PMD_INIT_FUNC_TRACE();
res = octeontx_bgx_port_open(nic->port_id, &bgx_port_conf);
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH v1 1/2] net/octeontx: fix null pointer dereference
2018-02-20 17:14 [dpdk-dev] [PATCH v1 1/2] net/octeontx: fix null pointer dereference Santosh Shukla
2018-02-20 17:14 ` [dpdk-dev] [PATCH v1 2/2] net/octeontx: fix for uninitialized scalar var Santosh Shukla
@ 2018-03-06 17:51 ` Ferruh Yigit
2018-03-07 8:20 ` Pavan Nikhilesh
1 sibling, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2018-03-06 17:51 UTC (permalink / raw)
To: Santosh Shukla, dev; +Cc: jerin.jacob, stable
On 2/20/2018 5:14 PM, Santosh Shukla wrote:
> Fixes: f18b146c498d ("net/octeontx: create ethdev ports")
> Coverity issue: 195040
>
> Cc: stable@dpdk.org
> Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Series applied to dpdk-next-net/master, thanks.
BTW, what is the plan to switching new offloading API in PMD? This release it is
planned to remove support for old API.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH v1 1/2] net/octeontx: fix null pointer dereference
2018-03-06 17:51 ` [dpdk-dev] [PATCH v1 1/2] net/octeontx: fix null pointer dereference Ferruh Yigit
@ 2018-03-07 8:20 ` Pavan Nikhilesh
0 siblings, 0 replies; 4+ messages in thread
From: Pavan Nikhilesh @ 2018-03-07 8:20 UTC (permalink / raw)
To: Ferruh Yigit, Santosh Shukla; +Cc: dev
On Tue, Mar 06, 2018 at 05:51:27PM +0000, Ferruh Yigit wrote:
> On 2/20/2018 5:14 PM, Santosh Shukla wrote:
> > Fixes: f18b146c498d ("net/octeontx: create ethdev ports")
> > Coverity issue: 195040
> >
> > Cc: stable@dpdk.org
> > Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
>
> Series applied to dpdk-next-net/master, thanks.
>
Hi Ferruh,
> BTW, what is the plan to switching new offloading API in PMD? This release it is
> planned to remove support for old API.
Thanks for the heads up, we will send out a patch switching to the new offload
scheme.
Pavan.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-03-07 8:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-20 17:14 [dpdk-dev] [PATCH v1 1/2] net/octeontx: fix null pointer dereference Santosh Shukla
2018-02-20 17:14 ` [dpdk-dev] [PATCH v1 2/2] net/octeontx: fix for uninitialized scalar var Santosh Shukla
2018-03-06 17:51 ` [dpdk-dev] [PATCH v1 1/2] net/octeontx: fix null pointer dereference Ferruh Yigit
2018-03-07 8:20 ` Pavan Nikhilesh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).