* [dpdk-dev] [PATCH] ip_frag: fix hash key usage
@ 2018-02-21 2:03 Sergey Alekseev
2018-03-27 22:29 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Sergey Alekseev @ 2018-02-21 2:03 UTC (permalink / raw)
To: dev
---
lib/librte_ip_frag/ip_frag_internal.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_ip_frag/ip_frag_internal.c b/lib/librte_ip_frag/ip_frag_internal.c
index 7397aa6..2cfa56b 100644
--- a/lib/librte_ip_frag/ip_frag_internal.c
+++ b/lib/librte_ip_frag/ip_frag_internal.c
@@ -61,7 +61,7 @@ ipv4_frag_hash(const struct ip_frag_key *key, uint32_t *v1, uint32_t *v2)
uint32_t v;
const uint32_t *p;
- p = (const uint32_t *)&key->src_dst;
+ p = (const uint32_t *) key->src_dst;
#ifdef RTE_ARCH_X86
v = rte_hash_crc_4byte(p[0], PRIME_VALUE);
@@ -82,7 +82,7 @@ ipv6_frag_hash(const struct ip_frag_key *key, uint32_t *v1, uint32_t *v2)
uint32_t v;
const uint32_t *p;
- p = (const uint32_t *) &key->src_dst;
+ p = (const uint32_t *) key->src_dst;
#ifdef RTE_ARCH_X86
v = rte_hash_crc_4byte(p[0], PRIME_VALUE);
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] ip_frag: fix hash key usage
2018-02-21 2:03 [dpdk-dev] [PATCH] ip_frag: fix hash key usage Sergey Alekseev
@ 2018-03-27 22:29 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2018-03-27 22:29 UTC (permalink / raw)
To: Sergey Alekseev; +Cc: dev, Konstantin Ananyev
Hi,
21/02/2018 03:03, Sergey Alekseev:
> ---
> lib/librte_ip_frag/ip_frag_internal.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Please we need an explanation and Signed-off-by.
Could you send a v2?
Do not hesitate to Cc Konstantin (maintainer of this lib) for reviews.
Thanks
> --- a/lib/librte_ip_frag/ip_frag_internal.c
> +++ b/lib/librte_ip_frag/ip_frag_internal.c
> @@ -61,7 +61,7 @@ ipv4_frag_hash(const struct ip_frag_key *key, uint32_t *v1, uint32_t *v2)
> uint32_t v;
> const uint32_t *p;
>
> - p = (const uint32_t *)&key->src_dst;
> + p = (const uint32_t *) key->src_dst;
>
> #ifdef RTE_ARCH_X86
> v = rte_hash_crc_4byte(p[0], PRIME_VALUE);
> @@ -82,7 +82,7 @@ ipv6_frag_hash(const struct ip_frag_key *key, uint32_t *v1, uint32_t *v2)
> uint32_t v;
> const uint32_t *p;
>
> - p = (const uint32_t *) &key->src_dst;
> + p = (const uint32_t *) key->src_dst;
>
> #ifdef RTE_ARCH_X86
> v = rte_hash_crc_4byte(p[0], PRIME_VALUE);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-27 22:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-21 2:03 [dpdk-dev] [PATCH] ip_frag: fix hash key usage Sergey Alekseev
2018-03-27 22:29 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).