DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/nfp: add port id to mbuf
@ 2018-02-22 11:13 Alejandro Lucero
  2018-03-07 11:37 ` Ferruh Yigit
  0 siblings, 1 reply; 2+ messages in thread
From: Alejandro Lucero @ 2018-02-22 11:13 UTC (permalink / raw)
  To: dev; +Cc: stable

Although this can be done by the app, because other PMDs are doing it,
apps expect this behaviour from the PMD.

Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
---
 drivers/net/nfp/nfp_net.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index e5bfde6..5180a31 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -2089,6 +2089,8 @@ enum nfp_qcp_ptr {
 		mb->nb_segs = 1;
 		mb->next = NULL;
 
+		mb->port = rxq->port_id;
+
 		/* Checking the RSS flag */
 		nfp_net_set_hash(rxq, rxds, mb);
 
-- 
1.9.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] net/nfp: add port id to mbuf
  2018-02-22 11:13 [dpdk-dev] [PATCH] net/nfp: add port id to mbuf Alejandro Lucero
@ 2018-03-07 11:37 ` Ferruh Yigit
  0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2018-03-07 11:37 UTC (permalink / raw)
  To: Alejandro Lucero, dev; +Cc: stable

On 2/22/2018 11:13 AM, Alejandro Lucero wrote:
> Although this can be done by the app, because other PMDs are doing it,
> apps expect this behaviour from the PMD.

Although it doesn't explicitly stated, I think expectation is PMD to set it, the
sample applications I checked in the dpdk don't set this.

And it can give better performance setting in PMD where the data is hot.

Fixes: b812daadad0d ("nfp: add Rx and Tx")
Cc: stable@dpdk.org

> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>

Applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-03-07 11:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-22 11:13 [dpdk-dev] [PATCH] net/nfp: add port id to mbuf Alejandro Lucero
2018-03-07 11:37 ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).