From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id 14F3923A; Tue, 27 Feb 2018 18:13:02 +0100 (CET) Received: by mail-wm0-f67.google.com with SMTP id h21so4763wmd.1; Tue, 27 Feb 2018 09:13:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=bbtPy1KWPYFNidWrurJEOEygzs7nB3Mv8Vatg2becKU=; b=V0HqYVtkcKcOUBXwOxY3Rf01CKNdKPgsCkmtlkdzB0190tYTmrIauwsVQGrMKU3weE 7CcYIwr8xRU+WTHvjdtFFzQ0rS9N3N/rucmA7IAH0PQVUSeiSeuPVGjvBwd2NT/cYjcH vYx4J6EW9U6i3kdVCs3oy9RFBojOwgUooXKGMtzceEbo1lYpU7/i3CLLLtU25V+G5AYW gwM7AHR7YrZMlkOQzS8IVw2Ni0C/piUNXJSqOOCdBZTp/TEBEjlnQHsttBif8ZHFHOJ3 vc3AdIxWX/NIEM+v8EBwPkotmN8sJZ7nP/ZvX/3ulhTmQIHDC9SW9/cpZS7e0BrHQSNz etnQ== X-Gm-Message-State: APf1xPA4XsTvQqisWRgGe9/f8uuwGQg6K3gYxXW0ag6s+tdj6f75+zF2 KiTocTqSs5lPT1J1FlonA3ojj4mO X-Google-Smtp-Source: AG47ELs0d63yxIm314shqpnozRnb6bfH2CgFbhwxgoxLJprcZlPHlzuNR93e/1ZkRajv2+zVk2x/tA== X-Received: by 10.28.21.136 with SMTP id 130mr10810021wmv.152.1519751581593; Tue, 27 Feb 2018 09:13:01 -0800 (PST) Received: from localhost ([2a00:23c5:be85:1400:6930:196b:56ac:33db]) by smtp.gmail.com with ESMTPSA id q74sm22767wmg.11.2018.02.27.09.12.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 27 Feb 2018 09:13:00 -0800 (PST) Message-ID: <1519751579.22753.53.camel@debian.org> From: Luca Boccassi To: Gowrishankar , dev@dpdk.org Cc: Chao Zhu , stable@dpdk.org, thomas@monjalon.net Date: Tue, 27 Feb 2018 17:12:59 +0000 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] eal/ppc: fix rte_smp_mb for a compilation error with else clause X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Feb 2018 17:13:02 -0000 On Tue, 2018-02-27 at 20:43 +0530, Gowrishankar wrote: > From: Gowrishankar Muthukrishnan >=20 > This patch fixes the compilation problem with rte_smp_mb, > when there is else clause following it, as in test_barrier.c. >=20 > Fixes: 05c3fd7110 ("eal/ppc: atomic operations for IBM Power") > Cc: stable@dpdk.org >=20 > Signed-off-by: Gowrishankar Muthukrishnan ibm.com> > --- > =C2=A0lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h | 2 +- > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h > b/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h > index 39fce7b..1821774 100644 > --- a/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h > +++ b/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h > @@ -55,7 +55,7 @@ > =C2=A0 * Guarantees that the LOAD and STORE operations generated before > the > =C2=A0 * barrier occur before the LOAD and STORE operations generated > after. > =C2=A0 */ > -#define rte_mb()=C2=A0=C2=A0{asm volatile("sync" : : : "memory"); } > +#define rte_mb()=C2=A0=C2=A0asm volatile("sync" : : : "memory") > =C2=A0 > =C2=A0/** > =C2=A0 * Write memory barrier. Acked-by: Luca Boccassi Maintainers and reviewers, 18.02 build on ppc64 is currently broken and I'd like to backport this patch to Debian ASAP and then backport to 16.11, so a quick review would be much much appreciated. Thank you! --=20 Kind regards, Luca Boccassi