From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0059.outbound.protection.outlook.com [104.47.2.59]) by dpdk.org (Postfix) with ESMTP id 016E94C97; Wed, 28 Feb 2018 17:47:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=vIq1DucdqzvY9nLia1OsoVBtt1sjYm2fo2gQueHdOWs=; b=I1Zwf9iZqj/MrYnEdOBBwReo2pfMwIkotRCMvRS9pn9x6A9sYG1/K9ETUdspo+2db6c+pi7EIcm7ptw7ZIsncHOUprLCLibRL9sCtSp4orOnfH0x2xoxCAHyMXyC/1nRjDvQuclnTE8B6+ogtGeNXKJIyTpRySAyUWWbUaOnjJY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ophirmu@mellanox.com; Received: from mellanox.com (37.142.13.130) by HE1PR0502MB3882.eurprd05.prod.outlook.com (2603:10a6:7:87::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.527.15; Wed, 28 Feb 2018 16:47:43 +0000 From: Ophir Munk To: dev@dpdk.org, Adrien Mazarguil Cc: Thomas Monjalon , Olga Shern , Ophir Munk , stable@dpdk.org Date: Wed, 28 Feb 2018 16:47:30 +0000 Message-Id: <1519836450-11895-1-git-send-email-ophirmu@mellanox.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1P194CA0048.EURP194.PROD.OUTLOOK.COM (2603:10a6:803:3c::37) To HE1PR0502MB3882.eurprd05.prod.outlook.com (2603:10a6:7:87::25) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 1d073c1b-cfae-487c-ff85-08d57ecafd6b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:HE1PR0502MB3882; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0502MB3882; 3:ZH5ycT0FYyjqqRQXGjTasJFsheixehUjtY98HaXYmpwy+JT5PIP8j1L/Rpq5WjDmahcQmqaNIbrQuANkfVPTIyEdL5P4UMJf1mdbwgqwayvndsB+6v4BA6hOYTbjHcBx2bY21PSJcHUBhM28/KjQFQ+Wybdl6eCAuem1daU29CVVNiTAClUnUcZC8GbGoH70265O+QnJIWt7LlD0L7JFPcm0aIpQMv3j77H45zUpZuFzlFY+MZ0Vap3QBehrFyFH; 25:ymluiLPS0XLIREMc0KheywJMEy9GTnuzlDBf0tFulYaPwYnWN1HvChdptrgLpvABH5/53nC//MYGBPq9lm4VRLJofrIaRugvf77lNANlFmd96GNZGjoVupKEzfZh19Fm8JkS2v8X5UJRYpd39McuFszrhafCD9XFfcZygwScN9MI8QOGcTR8wirwlq68ZgDaMlBEefagBhzoeAJhSpTeXh7xOZ4Afeuu1aiedwp1v09G2T+XywUq3LCfMKDXLw/7W5P8F+PS6HTFV2k/Ob8edsYQIf8uEGcMtthsymvuj5a7j9pB4T25j/wTpamIxe8sfDcLR82PdOhz2SSJl2J57w==; 31:2JdSo4F+oQvPwhCI7EwyQuI81KJRamP42SX5EzoWBs1Dtr2uzPrpl6iqJkoAYH+gK7w2lo7a+t8tLQ1Shm731SRq+yPJbih2/acEE0u0NeKiBZGZUatuVFGaiXRmyVDJTx2MLfPcunu1yAzariNyfqW/O7roxMGKIuN0/W4bBK7mc5IaF3YSAZWvjRs5PliJlIeYXWaOVyGokKU0Pv6ccag6kCj9x8yTATJujQdwHTE= X-MS-TrafficTypeDiagnostic: HE1PR0502MB3882: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; HE1PR0502MB3882; 20:U26yv/SLbiTbF3GVgdg9tdJFgJoXBE9IDgLEeec3I3L66vfngGHbVCVqk9gacAfXOEQ8O3yiHZqQJCsEPWMdHUs23H7MSZ89DLXLSsgmM7bSkYjTVi5w+eNZuYybz7mUx/WzRM8nM87h0AyIDpoclPws4Ds3+/5T9Plj1xWZrSt3sROg63v4v9ZZY8/OMWgei6JKRuooLDumLzRAQpEHnq3cBASmusFa6OCXZJlhOlFN6rR4hR6Dq/EHa+IqCEHih6o8zQNXvsWEkmebzcdzXfOejU0GEbIaQsdMqfaXathALrViyLVCggAur4O+qpXp3NOdOoB5xCzhWpBrpGqqwnykRjdCFXH9kYZA1jRwoB3kPh2PIr5lZOFoO2221RhrlGkI5Q/zTnaB7BNWUkQXeSpIkdRPPjj2LuqOhWiwfquGvBzRfjPr8H9U/eJR3Y/Fyye0SMxd67DpQ+iJeHTRdVZ1zkdEqSE1D4GiPwmjBPEsDKPdLJw0XpiRD03JZA84; 4:z8wdGfKl3yv2pUY/Cd2AJu+nENc3hssR8KhXCF/tYCwjYAtO9u02WaVSmbSP6FkrneYr0x9hLOs7Ww4NOHfhtzF8VwkfcLvTirw2V2XwZqUq9GOYBGoY6eQMB/DL0KTfyH4iaYMQ6d4MjFhmwVcIs/Wu2eOHw2HNEbBESJ80VV1ZYaY3MKEvI1qr8gapIbHx1ROZAP61JsWId3rqgWBZnmQYW0LqA3AfS1IFF/iDMFvbOSy4TGf0k5eIno4rtaHprTwv/rYu/B4KpcJkHrEXyw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040501)(2401047)(8121501046)(5005006)(3002001)(3231220)(944501217)(52105095)(93006095)(93001095)(10201501046)(6055026)(6041288)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011); SRVR:HE1PR0502MB3882; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0502MB3882; X-Forefront-PRVS: 0597911EE1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(366004)(376002)(396003)(39860400002)(39380400002)(189003)(199004)(50226002)(66066001)(8676002)(81166006)(7736002)(25786009)(4326008)(6916009)(478600001)(5660300001)(47776003)(4720700003)(2906002)(53936002)(305945005)(6666003)(16526019)(26005)(55016002)(8936002)(69596002)(21086003)(48376002)(7696005)(52116002)(50466002)(6116002)(33026002)(186003)(16586007)(386003)(97736004)(54906003)(105586002)(59450400001)(51416003)(316002)(106356001)(36756003)(3846002)(81156014)(86362001)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0502MB3882; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0502MB3882; 23:v4xcJKfmrrJ9Gj2lCQF0zNdgF+JmjALaDPeJRKv?= =?us-ascii?Q?avyF5p4/tyR5lKVs4/V1oVe2APJ1SupOxP0AIdg8dz/DGX2erFYhpxVmXdqv?= =?us-ascii?Q?6+sqhcLx7ih+garKE0s/G7jL8n+lszzwi1B4vUWXvilmFMp36FzqvAfimftE?= =?us-ascii?Q?N1dpZxkfghvloXvCEVpNmZBP0hQzsiFsGatg6jwQTjk/Do85ABOzFO2fMKKY?= =?us-ascii?Q?ubgY+B4tPc7uGK8GPm9d8ZppxiAg2DJlQZy/bdACD8ZfLoPQewg/oq7QFmFo?= =?us-ascii?Q?SdQd8aYpHVO7N8XAW5z6uRnwckSd+vHipYMiggkZxuiHuP2rGyBpuFihcXz8?= =?us-ascii?Q?l7bTyTqzJQ/mu7P9kjP1O6O64wL3sopWjZcbKCtXeXkvsGfw1rxisIcltrQ4?= =?us-ascii?Q?856Qc5foFDpbopXyub7DPi21X1migh0oZ90GcgjTNeFhHG/FyXKgepG57+25?= =?us-ascii?Q?Y/VCqIqny8jMXUmKeFurS6+g13SsnrsrYETu9mjF6ag26akKfQxpJUIgVIVy?= =?us-ascii?Q?lfZN0wadlwoAKMvxHG7W3TpRvht1OSsJ0CmDOLI9qrTz1hb54xeEg0Pw5LQp?= =?us-ascii?Q?c3m2QSXtab0awK7CFmVbeEC/CYRwiM+3kHfJeRm02yede9ZHB9a8Ihxef/Wu?= =?us-ascii?Q?7eswVARjXWjo8EackYa1fMR52fsoNoDqQ5cnUuFjnOajWkqUE/DmZ8gmS6dH?= =?us-ascii?Q?VCj/s6U6/+9eqkdB6wSO6zZkC6C/1XeuOO9zsPVDC6AyEZFbXbZyIJk44Wal?= =?us-ascii?Q?bkLDi3mCpO9Xo+rD6XYNT37CQf5ML2KdesGSmYOicJUZDp9Tn5nA6pAKerQy?= =?us-ascii?Q?bwRla6gxT9/CAQ6poEK2KacLZnYvvYIdv+4aOSPReQ+VG1KUT2YXkVQvnewM?= =?us-ascii?Q?TnU9VH0oI3DZ71i0V59IWxircRaeveNQ2h4Sk9pbgSxSTJRWnAU/FsbaZkL0?= =?us-ascii?Q?hOUHVgmxcljwY66nywGQ1kkfkG8DXUl5LjdtonxWTruV5Pl0vC4HRXvgX/bL?= =?us-ascii?Q?KtJYpiyXwbLoK7J4fZyzD5hOQ4HPnTP2N+0B5240lFtlerPuUYwljaI0ggE2?= =?us-ascii?Q?yBzGJtq1LZhhXR4+i2PQCeH3ULAQA+1Cjrr4GFf96onW6LpBtPTKSt62EgQx?= =?us-ascii?Q?EEGcaWuAtSupNljuGuTVm+0QV6iOea3bPz0gbOi2pCUvibn+itjkBUSOtJmI?= =?us-ascii?Q?0LfjJrthOmw9PO98=3D?= X-Microsoft-Exchange-Diagnostics: 1; HE1PR0502MB3882; 6:vZ3f3p55m2FT4VqC1vgJczvWcpf/HBCfzl5eeOvkbeF4oJbRb1mF92B2Jx7pGZv2MRx1MnqD0/H7XaYqXeuWiQJlahL5O5/81ZFcZ/h00YdkYcYUyskfU1A+BwhzgfHjSpXt/rxKE2gARr/6p1zOADvzisG8nJLknJjn366UxPbJ6xc/RbjE0soUHelk9KWtFL9ABg/F7qKF1aKKlNPH/PX2AfykwTwgKsZmiE4PAmgtbGM+pioX3/IZIGz0lm4gnxrZ3uXhRz2buwpXox3SrIPnSWynGwTGIrL/5Zymj+YTZAETPC0moZHC41rykpMZIdCShMzc+ioLXVedObfuYwxdB6rVezs71BUWph26clA=; 5:P97vAt73gleJPiNQUYEioinTAYnDqj0NSPEvEsB0RWRS+w+WbfJgNQ7WRtTXcC0RsAVcgUFjhSPgV2Tm3xXtbLxXVCpH1CA+GHBG8M6j99ePjecUQ32b//GjaRSHxl8qrzdNXD6uc6n/sk9Uq6MLFcGksIqEcBD3l1jjgcfZv4M=; 24:rZaF/QjM79xicKGVVi/YbddROxAJK4Hg09UsBOPqCnzC4DVGJl4e1yKs4gtstYy6V9CYt+alAFII/CJ2Yb5XI1CgHRwgI7+Otko/b19DSoc=; 7:6sM3yYPqY/FC3SQKkcxGDOllwXvVgFvni8bI56+JJddd7mHWAttnnUddTgauadlgI/dXDjKlKpPRawk8+7VSjwspcpfOZzVyWvI22I1Y2+JoJp/9IPAU2CUPrRkJl6EYCeR+EzGAJfgiT7VZliFglNlEQqnEM4WlXuBReZeHA6NtNpnBbLf5eGYviaYnh3jQO55KNq+qxzygDUNpKwQ4F4FPljxB0n+F5ynVCwmk/hSDEl+HMyrVeakR8mBPuCcN SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2018 16:47:43.1125 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1d073c1b-cfae-487c-ff85-08d57ecafd6b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0502MB3882 Subject: [dpdk-dev] [PATCH v1] net/mlx4: fix 'show port info all' during detach X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Feb 2018 16:47:46 -0000 The following scenario causes a crash in function mlx4_get_ifname 1. On testpmd startup mlx4 device is probed and started 2. mlx4 sriov is disabled. As a result an RMV event is sent to testpmd which closes the device and nullify the priv struct members. 3. Running 'show port info all' in testpmd results in segmentation fault because of accessing NULL pointer priv->ctx The fix is to return with an error from mlx4_get_ifname() if priv->ctx member is NULL. Fixes: 61cbdd419478 ("net/mlx4: separate device control functions") Cc: stable@dpdk.org Signed-off-by: Ophir Munk --- drivers/net/mlx4/mlx4_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/mlx4/mlx4_ethdev.c b/drivers/net/mlx4/mlx4_ethdev.c index 3bc6927..cca5223 100644 --- a/drivers/net/mlx4/mlx4_ethdev.c +++ b/drivers/net/mlx4/mlx4_ethdev.c @@ -67,6 +67,9 @@ mlx4_get_ifname(const struct priv *priv, char (*ifname)[IF_NAMESIZE]) char match[IF_NAMESIZE] = ""; { + if (priv->ctx == NULL) + return -ENOENT; + MKSTR(path, "%s/device/net", priv->ctx->device->ibdev_path); dir = opendir(path); -- 2.7.4