From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f47.google.com (mail-wg0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 5199D47D2 for ; Wed, 25 Jun 2014 11:51:11 +0200 (CEST) Received: by mail-wg0-f47.google.com with SMTP id k14so1697415wgh.6 for ; Wed, 25 Jun 2014 02:51:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=NBpGuHEOLKSR0HHPlbgl0OhcRGU6KwTn6xc+xwOG3PQ=; b=WSkZY/Sks3ZS0MEvaFRNFKmVAGGbNFjnJHAZ84XZEsVaisfuqEYgTQX7DYxT1tM9/1 qupEfZrr/9sRyMbZKiQGx94aT1M33jxdS5hGMFyquEhqRRPQ8QxxtgQ8oWwFsyVeUkq0 R6ElGxplhCA+1/Vpd8dKoAlSH5eCjDMkG1fRoj2ax8LKufJ7+r58/6PhEV6OUNwsCVQX 027J0VIpciIqjOAXf/+MEQp6l5UM7VQ3mkQ5XQtwGX7aznan7AL3iBWw5VUEjQ6so1ma 8KBw+JcTYrFF1AuVSUgoPc67meXv61gHCDL+sn3xRZoH4RcNaaofphHmZc3L5n673868 Z5pg== X-Gm-Message-State: ALoCoQnRyTYwJ4Oe6VqZPxW3H7jt91+kXW73//bMkjwhMKx9X7TJ5ce/A99OEO36oYx4ZJOco6RI X-Received: by 10.180.184.198 with SMTP id ew6mr40937587wic.13.1403689889436; Wed, 25 Jun 2014 02:51:29 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id lo18sm10527395wic.1.2014.06.25.02.51.27 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Jun 2014 02:51:28 -0700 (PDT) From: Thomas Monjalon To: "Xie, Huawei" Date: Wed, 25 Jun 2014 11:51:24 +0200 Message-ID: <1519995.xBIJsFhZji@xps13> Organization: 6WIND User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; ) In-Reply-To: References: <7F861DC0615E0C47A872E6F3C5FCDDBD0110E6A2@BPXM14GP.gisp.nec.co.jp> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Hayato Momma Subject: Re: [dpdk-dev] [PATCH] rte_memory.h: include stdio.h for FILE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jun 2014 09:51:11 -0000 Hi Huawei, 2014-06-17 03:48, Xie, Huawei: > At least rte_tailq.h, rte_mbuf.h should also include stdio.h. It has been fixed in this commit: http://dpdk.org/browse/dpdk/commit/?id=86d5de5c46fc0 But rte_memory.h was forgotten. rte_mbuf.h has no problem because it includes rte_mempool.h which includes stdio.h. -- Thomas > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hiroshi Shimamoto > Sent: Thursday, June 12, 2014 4:11 PM > To: dev@dpdk.org > Cc: Hayato Momma > Subject: [dpdk-dev] [PATCH] rte_memory.h: include stdio.h for FILE > > From: Hiroshi Shimamoto > > The below commit requires stdio FILE structure. > > commit 591a9d7985c1230652d9f7ea1f9221e8c66ec188 > Author: Stephen Hemminger > Date: Fri May 2 16:42:56 2014 -0700 > > add FILE argument to debug functions > > Application which includes rte_memory.h without stdio.h will be hit > compilation failure. > > /path/to/include/rte_memory.h:146:30: error: unknown type name 'FILE' > void rte_dump_physmem_layout(FILE *f); > > Signed-off-by: Hiroshi Shimamoto > Reviewed-by: Hayato Momma > --- > lib/librte_eal/common/include/rte_memory.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_eal/common/include/rte_memory.h > b/lib/librte_eal/common/include/rte_memory.h index 7f21244..4cf8ea9 100644 > --- a/lib/librte_eal/common/include/rte_memory.h > +++ b/lib/librte_eal/common/include/rte_memory.h > @@ -42,6 +42,7 @@ > > #include > #include > +#include > > #ifdef RTE_EXEC_ENV_LINUXAPP > #include > -- > 1.9.1