From: Thomas Monjalon <thomas@monjalon.net>
To: Lee Roberts <lee.roberts@hpe.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] kni: fix compilation under RHEL 7.4.
Date: Mon, 05 Jun 2017 15:46:48 +0200 [thread overview]
Message-ID: <1520135.VAqfqidlFp@xps> (raw)
In-Reply-To: <8e035ab5-0435-3346-b572-c618df12571f@intel.com>
31/05/2017 18:43, Ferruh Yigit:
> On 5/31/2017 4:40 PM, Lee Roberts wrote:
> > Fix kni compilation under RHEL 7.4.
> >
> > Signed-off-by: Lee Roberts <lee.roberts@hpe.com>
>
> Not tested on RHEL 7.4, but patch looks good to me except following
> nit-picking:
> - There should not be "." at the end of the patch title
> - It can be good to add Linux commit that is the reason of the change to
> the commit log:
> Linux: 9b36627acecd ("net: remove dev->trans_start")
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
prev parent reply other threads:[~2017-06-05 13:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 15:40 Lee Roberts
2017-05-31 16:43 ` Ferruh Yigit
2017-06-05 13:46 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520135.VAqfqidlFp@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=lee.roberts@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).