From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id 7A7EF4C75 for ; Wed, 7 Mar 2018 19:06:18 +0100 (CET) Received: by mail-wm0-f67.google.com with SMTP id h21so6527295wmd.1 for ; Wed, 07 Mar 2018 10:06:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=0/MxlYIkoEq6bBTggce24EhFRsDiYQLZfEb2oKFw1Zo=; b=HIJKg1ziIL6U+o8yLy5Q/XacXd86oDLNg8VIkgaG3RVLZg6ENg2NxF8viGfWuoirpn rGcHIHsA94/YMOiGqYsSsuKL9NslKtP9Qkhh/QWCc3vjWH5fsGKtPJh8vAGSyRUy1Ks6 8eyHz6qICX2QMYKVMe9KzA21LraVFG3+nk15xlxKiZu4yjrycLkU9M0wb+Rk78EsVfJu NLvSdMJUwZF5pfU4Nnp9tl3Zl0t8VlMS+OuBTPjkZKJoyEtnGH/oYy5AQqd7JzpSK03x K24dpkHp1vHLxjo3LqZ5tJEdhi2XtoPfa0DMA1366XadbpdoWBhpDVtADqLzMz0PX8LH /m3Q== X-Gm-Message-State: AElRT7HbM/g9pSIq6RBDNEa5W5f6fot3Qh9TwtL1mXuzXRhD1BSMYVhh iEtCJG6BbCrcMID18Po7j7U= X-Google-Smtp-Source: AG47ELvUYKe0raSWiVXtzcj4KVOuAPd4d047jKwTHgdaU1hf4uBsCbLxPXa8wR/dViXIMhwBzCnN0A== X-Received: by 10.28.31.215 with SMTP id f206mr6650666wmf.68.1520445978013; Wed, 07 Mar 2018 10:06:18 -0800 (PST) Received: from localhost ([213.251.34.146]) by smtp.gmail.com with ESMTPSA id 74sm4680352wmf.26.2018.03.07.10.06.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 07 Mar 2018 10:06:17 -0800 (PST) Message-ID: <1520445975.8866.19.camel@debian.org> From: Luca Boccassi To: Ferruh Yigit , Thomas Monjalon , Neil Horman , John McNamara , Marko Kovacevic Cc: dev@dpdk.org, Christian Ehrhardt Date: Wed, 07 Mar 2018 18:06:15 +0000 In-Reply-To: <20180307174422.118291-1-ferruh.yigit@intel.com> References: <20180307174422.118291-1-ferruh.yigit@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [RFC] config: remove RTE_NEXT_ABI X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 18:06:18 -0000 On Wed, 2018-03-07 at 17:44 +0000, Ferruh Yigit wrote: > After experimental API process defined do we still need RTE_NEXT_ABI > config and process which has similar targets? >=20 > Are distros disable experimental APIs when delivering DPDK? And is > there > any config required to control this, as RTE_NEXT_ABI intended to do? I tried to tinker with not exporting experimental APIs - but the problem is intra-project dependencies, iow: librte_foo has a foo_experimental API that librte_bar uses, so if librte_foo foo_experimental symbol is not available everything breaks down. I need to spend a bit more on this problem but -ENOTIME > Cc: Neil Horman > Cc: Thomas Monjalon > Cc: Luca Boccassi > Cc: Christian Ehrhardt >=20 > Signed-off-by: Ferruh Yigit > --- > =C2=A0config/common_base=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0|=C2=A0=C2=A05 ----- > =C2=A0devtools/test-build.sh=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A0=C2=A02 -- > =C2=A0devtools/validate-abi.sh=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A0=C2=A01 - > =C2=A0doc/guides/contributing/versioning.rst | 10 ---------- > =C2=A0mk/rte.lib.mk=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A0=C2=A05 ----- > =C2=A0pkg/dpdk.spec=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A0=C2=A01 - > =C2=A06 files changed, 24 deletions(-) >=20 > diff --git a/config/common_base b/config/common_base > index ad03cf433..6b867f6a9 100644 > --- a/config/common_base > +++ b/config/common_base > @@ -41,11 +41,6 @@ CONFIG_RTE_ARCH_STRICT_ALIGN=3Dn > =C2=A0CONFIG_RTE_BUILD_SHARED_LIB=3Dn > =C2=A0 > =C2=A0# > -# Use newest code breaking previous ABI > -# > -CONFIG_RTE_NEXT_ABI=3Dy > - > -# > =C2=A0# Major ABI to overwrite library specific LIBABIVER > =C2=A0# > =C2=A0CONFIG_RTE_MAJOR_ABI=3D > diff --git a/devtools/test-build.sh b/devtools/test-build.sh > index 3362edcc5..22b4e1a98 100755 > --- a/devtools/test-build.sh > +++ b/devtools/test-build.sh > @@ -154,8 +154,6 @@ config () # > =C2=A0 # Built-in options (lowercase) > =C2=A0 ! echo $3 | grep -q '+default' || \ > =C2=A0 sed -ri 's,(RTE_MACHINE=3D")native,\1default,' > $1/.config > - echo $3 | grep -q '+next' || \ > - sed -ri=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0's,(NEXT_ABI=3D)y,\1n,' $1/.config > =C2=A0 ! echo $3 | grep -q '+shared' || \ > =C2=A0 sed -ri=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0's,(= SHARED_LIB=3D)n,\1y,' $1/.config > =C2=A0 ! echo $3 | grep -q '+debug' || ( \ > diff --git a/devtools/validate-abi.sh b/devtools/validate-abi.sh > index 138436d93..a64edf92f 100755 > --- a/devtools/validate-abi.sh > +++ b/devtools/validate-abi.sh > @@ -105,7 +105,6 @@ set_log_file() { > =C2=A0fixup_config() { > =C2=A0 local conf=3Dconfig/defconfig_$target > =C2=A0 cmd sed -i -e"$ a\CONFIG_RTE_BUILD_SHARED_LIB=3Dy" $conf > - cmd sed -i -e"$ a\CONFIG_RTE_NEXT_ABI=3Dn" $conf > =C2=A0 cmd sed -i -e"$ a\CONFIG_RTE_EAL_IGB_UIO=3Dn" $conf > =C2=A0 cmd sed -i -e"$ a\CONFIG_RTE_LIBRTE_KNI=3Dn" $conf > =C2=A0 cmd sed -i -e"$ a\CONFIG_RTE_KNI_KMOD=3Dn" $conf > diff --git a/doc/guides/contributing/versioning.rst > b/doc/guides/contributing/versioning.rst > index c495294db..59ff0e8b7 100644 > --- a/doc/guides/contributing/versioning.rst > +++ b/doc/guides/contributing/versioning.rst > @@ -91,19 +91,9 @@ being provided. The requirements for doing so are: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0interest" be sought for each deprecat= ion, for example: from NIC > vendors, > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0CPU vendors, end-users, etc. > =C2=A0 > -#. The changes (including an alternative map file) must be gated > with > -=C2=A0=C2=A0=C2=A0the ``RTE_NEXT_ABI`` option, and provided with a depre= cation > notice at the > -=C2=A0=C2=A0=C2=A0same time. > -=C2=A0=C2=A0=C2=A0It will become the default ABI in the next release. > - > =C2=A0#. A full deprecation cycle, as explained above, must be made to > offer > =C2=A0=C2=A0=C2=A0=C2=A0downstream consumers sufficient warning of the ch= ange. > =C2=A0 > -#. At the beginning of the next release cycle, every > ``RTE_NEXT_ABI`` > -=C2=A0=C2=A0=C2=A0conditions will be removed, the ``LIBABIVER`` variable= in the > makefile(s) > -=C2=A0=C2=A0=C2=A0where the ABI is changed will be incremented, and the = map files > will > -=C2=A0=C2=A0=C2=A0be updated. > - > =C2=A0Note that the above process for ABI deprecation should not be > undertaken > =C2=A0lightly. ABI stability is extremely important for downstream > consumers of the > =C2=A0DPDK, especially when distributed in shared object form. Every > effort should > diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk > index c696a2174..8ac26face 100644 > --- a/mk/rte.lib.mk > +++ b/mk/rte.lib.mk > @@ -20,11 +20,6 @@ endif > =C2=A0ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) > =C2=A0LIB :=3D $(patsubst %.a,%.so.$(LIBABIVER),$(LIB)) > =C2=A0ifeq ($(EXTLIB_BUILD),n) > -ifeq ($(CONFIG_RTE_MAJOR_ABI),) > -ifeq ($(CONFIG_RTE_NEXT_ABI),y) > -LIB :=3D $(LIB).1 > -endif > -endif > =C2=A0CPU_LDFLAGS +=3D --version-script=3D$(SRCDIR)/$(EXPORT_MAP) > =C2=A0endif > =C2=A0endif > diff --git a/pkg/dpdk.spec b/pkg/dpdk.spec > index 4d3b5745c..d118f0463 100644 > --- a/pkg/dpdk.spec > +++ b/pkg/dpdk.spec > @@ -84,7 +84,6 @@ make O=3D%{target} T=3D%{config} config > =C2=A0sed -ri 's,(RTE_MACHINE=3D).*,\1%{machine},' %{target}/.config > =C2=A0sed -ri 's,(RTE_APP_TEST=3D).*,\1n,'=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0%{target}/.config > =C2=A0sed -ri 's,(RTE_BUILD_SHARED_LIB=3D).*,\1y,' %{target}/.config > -sed -ri 's,(RTE_NEXT_ABI=3D).*,\1n,'=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0%{target}/.config > =C2=A0sed -ri 's,(LIBRTE_VHOST=3D).*,\1y,'=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0%{target}/.config > =C2=A0sed -ri 's,(LIBRTE_PMD_PCAP=3D).*,\1y,'=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0%{target}/.config > =C2=A0make O=3D%{target} %{?_smp_mflags} --=20 Kind regards, Luca Boccassi