From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 8463BE6D for ; Mon, 11 Apr 2016 11:32:33 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id v188so78308878wme.1 for ; Mon, 11 Apr 2016 02:32:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=ny5pdJZeDcHNPVuYHLNrQBVVUaJQrgP7v+h+U9jpWBw=; b=etPN11NtlxwMo9mVmrRPx79OK5yOvfU6bacj758Rf+KIC94AeDsRdNfDwTPZ0nu2ZV I4kM0kHKxeH306YisOhFdmuNUp4GbQe3/SFqtIPm1zsO5aYhqVOCw4R9GwTNVAlI/5Wc GQ1bHSYkmuDp6s6YxZwFBou+WGC1RGgLyoehlKAzJDs5Tzq1C9vn6pbfXD2vEpsSf5gl Ao3jgo1VYKLKyzPTG+5WT/dj9NOEE2ccLWzS4oDJHQ1ZT2l6tG+VXq4sTwnEnIReNIg7 EqelJUPAexBvkQO1dJWuIwj5gioYHBKG3o1sD+tHWBLpXpmTw0YF0P/2x9bKLI/YA0ej EtCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=ny5pdJZeDcHNPVuYHLNrQBVVUaJQrgP7v+h+U9jpWBw=; b=dZ4iCoLNKcKeVN0YWqjH58MFu1155YS/w+W0et+FaMa1MHyQtCEIVv9pGZYgojhzwv 1eCSVpsQMK9prabs279P1eoTksJw7LEaLBGyJTdGeaUTiB39hv6ntt7jk1jBPP+4Wpyy eDDN8AR/6S3124cb2SqtDqk4iVYf5GQJp4/LKQh+48MG9pPHQlr0lyUF+qL/IAdP1X7g 4Xh6ZOpGH0hQEBKWeibNhZSurwQM9LmugsDjNcZ1TShk84ZxcbEBtUMtn7ioi0O2NLz0 aoF/g1lJLUTq8ovo4tUV82Ot/gKFdzD8m1SL9CtbMfPwJ1gMBaeMz2WtLUacB7NBo3yn MRvg== X-Gm-Message-State: AOPr4FX9y0uh6i7OBamNG9bcuG2MtSJNKGmwlUp8xVfmRB9aRoyaAdGb71iIWBcPRbSIpIoY X-Received: by 10.194.20.6 with SMTP id j6mr874903wje.118.1460367153339; Mon, 11 Apr 2016 02:32:33 -0700 (PDT) Received: from xps13.localnet (245.111.75.86.rev.sfr.net. [86.75.111.245]) by smtp.gmail.com with ESMTPSA id u3sm16290565wmg.15.2016.04.11.02.32.32 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 11 Apr 2016 02:32:32 -0700 (PDT) From: Thomas Monjalon To: Marvin Liu Cc: dev@dpdk.org Date: Mon, 11 Apr 2016 11:32:31 +0200 Message-ID: <1520567.Fdz9OaVc1U@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1729179.ZFCP7VmEgh@xps13> References: <1460346357-26592-1-git-send-email-yong.liu@intel.com> <1460364631-28381-1-git-send-email-yong.liu@intel.com> <1729179.ZFCP7VmEgh@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] examples/vm_power_manager: fix build with libvirt version < 0.9.3 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Apr 2016 09:32:33 -0000 2016-04-11 11:26, Thomas Monjalon: > 2016-04-11 16:50, Marvin Liu: > > Fixes: 2e099bc5d104 ("fix split of compiler and linker options") > > As commented earlier, I don't think it is the origin of the issue. > > > +$(info "vm_power_manager required libvirt version >= 0.9.3, please update libvirt-devel first") > > "required" should be "requires". > libvirt-devel is the name of the package on some distributions, but > it is not always the case. Moreover, the whole libvirt package must be > updated atomically, not only the headers. That's why I think it's better > to remove this part and just keep: > "vm_power_manager requires libvirt version >= 0.9.3" > > Other issue: it would better to use $(error to generate a compilation error. > But the example should not be skipped from examples/Makefile in this case. Sorry I mean the example *should be* skipped from examples/Makefile, with the small message "vm_power_manager requires libvirt >= 0.9.3".