From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 1BE372C12 for ; Sat, 10 Mar 2018 16:40:08 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 5EA7CB80065; Sat, 10 Mar 2018 15:40:06 +0000 (UTC) Received: from sfocexch01r.SolarFlarecom.com (10.20.40.34) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Sat, 10 Mar 2018 07:40:03 -0800 Received: from ocex03.SolarFlarecom.com (10.20.40.36) by sfocexch01r.SolarFlarecom.com (10.20.40.34) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Sat, 10 Mar 2018 07:40:02 -0800 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1044.25 via Frontend Transport; Sat, 10 Mar 2018 07:40:01 -0800 Received: from uklogin.uk.solarflarecom.com (uklogin.uk.solarflarecom.com [10.17.10.10]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id w2AFdxNj016786; Sat, 10 Mar 2018 15:40:00 GMT Received: from uklogin.uk.solarflarecom.com (localhost.localdomain [127.0.0.1]) by uklogin.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id w2AFdxbg016447; Sat, 10 Mar 2018 15:39:59 GMT From: Andrew Rybchenko To: CC: Olivier MATZ , Santosh Shukla , Jerin Jacob , Hemant Agrawal , Shreyansh Jain Date: Sat, 10 Mar 2018 15:39:33 +0000 Message-ID: <1520696382-16400-1-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.2.3 In-Reply-To: <1516713372-10572-1-git-send-email-arybchenko@solarflare.com> References: <1516713372-10572-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain X-MDID: 1520696407-s7XAvhvjPbNw Subject: [dpdk-dev] [PATCH v1 0/9] mempool: prepare to add bucket driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Mar 2018 15:40:08 -0000 The initial patch series [1] is split into two to simplify processing. The second series relies on this one and will add bucket mempool driver and related ops. The patch series has generic enhancements suggested by Olivier. Basically it adds driver callbacks to calculate required memory size and to populate objects using provided memory area. It allows to remove so-called capability flags used before to tell generic code how to allocate and slice allocated memory into mempool objects. Clean up which removes get_capabilities and register_memory_area is not strictly required, but I think right thing to do. Existing mempool drivers are updated. I've kept rte_mempool_populate_iova_tab() intact since it seems to be not directly related XMEM API functions. It breaks ABI since changes rte_mempool_ops. Also it removes rte_mempool_ops_register_memory_area() and rte_mempool_ops_get_capabilities() since corresponding callbacks are removed. Internal global functions are not listed in map file since it is not a part of external API. [1] http://dpdk.org/ml/archives/dev/2018-January/088698.html RFCv1 -> RFCv2: - add driver ops to calculate required memory size and populate mempool objects, remove extra flags which were required before to control it - transition of octeontx and dpaa drivers to the new callbacks - change info API to get information from driver required to API user to know contiguous block size - remove get_capabilities (not required any more and may be substituted with more in info get API) - remove register_memory_area since it is substituted with populate callback which can do more - use SPDX tags - avoid all objects affinity to single lcore - fix bucket get_count - deprecate XMEM API - avoid introduction of a new function to flush cache - fix NO_CACHE_ALIGN case in bucket mempool RFCv2 -> v1: - split the series in two - squash octeontx patches which implement calc_mem_size and populate callbacks into the patch which removes get_capabilities since it is the easiest way to untangle the tangle of tightly related library functions and flags advertised by the driver - consistently name default callbacks - move default callbacks to dedicated file - see detailed description in patches Andrew Rybchenko (7): mempool: add op to calculate memory size to be allocated mempool: add op to populate objects using provided memory mempool: remove callback to get capabilities mempool: deprecate xmem functions mempool/octeontx: prepare to remove register memory area op mempool/dpaa: prepare to remove register memory area op mempool: remove callback to register memory area Artem V. Andreev (2): mempool: ensure the mempool is initialized before populating mempool: support flushing the default cache of the mempool doc/guides/rel_notes/deprecation.rst | 12 +- doc/guides/rel_notes/release_18_05.rst | 32 ++- drivers/mempool/dpaa/dpaa_mempool.c | 13 +- drivers/mempool/octeontx/rte_mempool_octeontx.c | 64 ++++-- lib/librte_mempool/Makefile | 3 +- lib/librte_mempool/meson.build | 5 +- lib/librte_mempool/rte_mempool.c | 159 +++++++-------- lib/librte_mempool/rte_mempool.h | 260 +++++++++++++++++------- lib/librte_mempool/rte_mempool_ops.c | 37 ++-- lib/librte_mempool/rte_mempool_ops_default.c | 51 +++++ lib/librte_mempool/rte_mempool_version.map | 11 +- test/test/test_mempool.c | 31 --- 12 files changed, 437 insertions(+), 241 deletions(-) create mode 100644 lib/librte_mempool/rte_mempool_ops_default.c -- 2.7.4