From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 6AB9C36E for ; Thu, 17 Nov 2016 14:36:41 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id g23so311442747wme.1 for ; Thu, 17 Nov 2016 05:36:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=uat4RVuk4dA3uSQg/jrAg1Ku9+7CPs/cHv4Cvx3tepo=; b=GwE0/5CtfifbhzLjpnHwdOD9tHYjJFd8NwYfdQbrUkU2fHzco6u/MIa1Lp+/i7BupH qaW+BaV7cSK7rDm+Sd8x0Rl59M/spbZp8jnjGalb7E2SH66vseu4ke1BE9gWgLLUU1DD sQG/aOMKOStbjNI0Nw5hpTBcBGshMi5gcZDkEvSWDjSfDe26mY5wbe1sNMIzz3BWA6Tg kdwuQI0BWu8pKhsyGhOH8cJ2f+0bjzhm1k9jwYgVe/KNnfXV2dsX5A75NXyZ3zlV//vT 1yQT3H8h5IuyzoAtBt8AJE+FokbstyoNflaizKIYAWYojVacgyI2d195XyteIxsQnVKL yhPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=uat4RVuk4dA3uSQg/jrAg1Ku9+7CPs/cHv4Cvx3tepo=; b=LoH9ifSNE+LMqV0lz1fIz/7FTvmGNSdMRh7Dmoipwv5ty+OPp9JBFbkK3UNtj9aqgP 0Uxn0JpJwlL6RzDp87yMgiVci2uhOpZup+Zcjv4beyFaDQuhHXqeL8l8az0YsrzJpB94 INchDuWbhB21ZbEMxhXVe9R2sIRMYBVlLAzQRObQ6cg5LudhOcU/foiyDFZBWdf3d3Ld F8endHYkKIaeD8DEyX8qSDjt9fQ9u15pGCfBKR0JZaFRs0a6Vu7ONwLOozCjKNq3aFJ5 7f6TTHtNlgIS140tcpND/o37Jz1h3LKGJLX6qJr8pnb7QISYLDmjr4NQZaEbYXCG2fXE 0Now== X-Gm-Message-State: ABUngvewqVqm+UH38pwi1ismBRrVTV4EzKkD2IDryWAuViN1pP1Ud6IIwfYNR0KrjJ4gMKP6 X-Received: by 10.28.4.200 with SMTP id 191mr3965870wme.23.1479389800933; Thu, 17 Nov 2016 05:36:40 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id jx8sm3350356wjc.2.2016.11.17.05.36.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Nov 2016 05:36:40 -0800 (PST) From: Thomas Monjalon To: Qiming Yang Cc: dev@dpdk.org, remy.horton@intel.com, jingjing.wu@intel.com, jing.d.chen@intel.com Date: Thu, 17 Nov 2016 14:36:39 +0100 Message-ID: <1520754.cvFYjLZGdK@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1479375779-46629-2-git-send-email-qiming.yang@intel.com> References: <1479375779-46629-1-git-send-email-qiming.yang@intel.com> <1479375779-46629-2-git-send-email-qiming.yang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/5] ethdev: add firmware version get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Nov 2016 13:36:41 -0000 2016-11-17 17:42, Qiming Yang: > This patch added API for 'rte_eth_dev_fwver_get' > > void rte_eth_dev_fwver_get(uint8_t port_id, > char *fw_version, int fw_length); Copying some code here doesn't help really help. Could you describe what we can expect in this string? How can we compare this version number across different devices of the same driver? How does it apply to FPGA devices? What is the potential use? [...] > /** > + * Retrieve the firmware version of an Ethernet device. We should stop talking about Ethernet device. Networking device is more appropriate. And in this case, "device" is enough. > + * > + * @param port_id > + * The port identifier of the Ethernet device. > + * @param fw_version > + * A pointer the firmware version of an Ethernet device > + * @param fw_length > + * The size of the firmware version, which should be large enough to store > + * the firmware version of the device. How do we know that the length is too small? > + */ > +void rte_eth_dev_fwver_get(uint8_t port_id, char *fw_version, int fw_length); Why not returning some errors? You forgot to remove the deprecation notice in this patch. PS: the series is broken as some patches are not numbered and this one is not the first one. Please use a cover-letter to introduce such series.