From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 6A0E52030 for ; Wed, 19 Jul 2017 18:13:12 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 123DE20BC2; Wed, 19 Jul 2017 12:13:12 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 19 Jul 2017 12:13:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=Ag0CHHzLsNByEx8 qxjzIpg4HXwE6lbaFvb3gx3ww0CA=; b=oTHp8TfYMT4+B6GBHOFk/YD+ttDqhbH yJ77XyHdVqgnNqlXMWMouv69HzNSJOeCMiwqUX+4fvMJD8FFtzP8KFyTUD/8lbJv MoYSh6YIKbVbyC+wUvE3fYrV/5A2mJn3zNoZ2Uy+EldmFyTqcJ/s+UqHzCmaXuJd uXG06vuCkRM4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=Ag0CHHzLsNByEx8qxjzIpg4HXwE6lbaFvb3gx3ww0CA=; b=CDWD0j5R xecTQYZb86a3FKb/FUdH5f822NJ2j6Ebttoh0ja2K58Mhiogh9rGBMxhEy+ljL9u wWBTbjc1YoT1CDx3ww0kpM4MSPXWsysNYOEqS2CR1y1cnOKqR/myFnzpVmAxwI2R CPnlkGHXKGcV/1CY3nvB5RMGLSwd5VzbFVHf/4YbT2JPp2pOyDkdmT7fE3dAGCiK Zq/indiBNBl7KnL6tEN/P7TVzfX261GipccdOUCSaUIP63980RWSBTJESUuwgx1/ aOCe9KfFQZxzdC21JHTUdGmM76ALuoLXAIZMBDJ8oqc8nWEvmQYKSRdwrAJn7oKW m8VsO57U5a8+0A== X-ME-Sender: X-Sasl-enc: YupmmV5Ld91XqmFJlH66aSLepjS2shz7BSsAD73lUJc2 1500480791 Received: from xps.localnet (unknown [37.162.156.183]) by mail.messagingengine.com (Postfix) with ESMTPA id 906797E2E6; Wed, 19 Jul 2017 12:13:11 -0400 (EDT) From: Thomas Monjalon To: Remy Horton Cc: dev@dpdk.org Date: Wed, 19 Jul 2017 19:13:07 +0300 Message-ID: <1520852.R20bLQnZlh@xps> In-Reply-To: <20170718094347.5387-1-remy.horton@intel.com> References: <20170718094347.5387-1-remy.horton@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1] metrics: fix missing NULL termination X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jul 2017 16:13:12 -0000 18/07/2017 12:43, Remy Horton: > The public API (struct rte_metric_name) includes the NULL terminator > byte in RTE_METRICS_MAX_NAME_LENGTH but the library itself internally > excludes it. This makes it possible for an application to receive an > unterminated name string. Fix be enforcing the NULL termination of all > name strings to the length that the public API expects. > > Fixes: 349950ddb9c5 ("metrics: add information metrics library") > > Signed-off-by: Remy Horton Applied, thanks