* [dpdk-dev] [PATCH 01/13] net/bonding: fix library version in meson build
2018-03-20 11:26 [dpdk-dev] [PATCH 00/13] build: fix library version in meson build Andrew Rybchenko
@ 2018-03-20 11:26 ` Andrew Rybchenko
2018-03-23 21:31 ` Bruce Richardson
2018-03-27 16:43 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2018-03-20 11:26 ` [dpdk-dev] [PATCH 02/13] net/i40e: " Andrew Rybchenko
` (12 subsequent siblings)
13 siblings, 2 replies; 32+ messages in thread
From: Andrew Rybchenko @ 2018-03-20 11:26 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson, stable
Fixes: a0ace286a60b ("net/bonding: build with meson")
Cc: stable@dpdk.org
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/net/bonding/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/bonding/meson.build b/drivers/net/bonding/meson.build
index b90abc6..44d5fd8 100644
--- a/drivers/net/bonding/meson.build
+++ b/drivers/net/bonding/meson.build
@@ -2,6 +2,7 @@
# Copyright(c) 2017 Intel Corporation
name = 'bond' #, james bond :-)
+version = 2
sources = files('rte_eth_bond_api.c', 'rte_eth_bond_pmd.c',
'rte_eth_bond_args.c', 'rte_eth_bond_8023ad.c', 'rte_eth_bond_alb.c')
--
2.7.4
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: [dpdk-dev] [PATCH 01/13] net/bonding: fix library version in meson build
2018-03-20 11:26 ` [dpdk-dev] [PATCH 01/13] net/bonding: " Andrew Rybchenko
@ 2018-03-23 21:31 ` Bruce Richardson
2018-03-27 16:43 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
1 sibling, 0 replies; 32+ messages in thread
From: Bruce Richardson @ 2018-03-23 21:31 UTC (permalink / raw)
To: Andrew Rybchenko; +Cc: dev, stable
On Tue, Mar 20, 2018 at 11:26:15AM +0000, Andrew Rybchenko wrote:
> Fixes: a0ace286a60b ("net/bonding: build with meson")
> Cc: stable@dpdk.org
>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH 01/13] net/bonding: fix library version in meson build
2018-03-20 11:26 ` [dpdk-dev] [PATCH 01/13] net/bonding: " Andrew Rybchenko
2018-03-23 21:31 ` Bruce Richardson
@ 2018-03-27 16:43 ` Thomas Monjalon
2018-03-27 20:26 ` Bruce Richardson
1 sibling, 1 reply; 32+ messages in thread
From: Thomas Monjalon @ 2018-03-27 16:43 UTC (permalink / raw)
To: Bruce Richardson; +Cc: Andrew Rybchenko, dev
> --- a/drivers/net/bonding/meson.build
> +++ b/drivers/net/bonding/meson.build
> @@ -2,6 +2,7 @@
> # Copyright(c) 2017 Intel Corporation
>
> name = 'bond' #, james bond :-)
Ah ah ah, I had missed this important comment!
Unfortunately I think the real name is "bonding".
Does it mean the full name should be james bonding?
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH 01/13] net/bonding: fix library version in meson build
2018-03-27 16:43 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
@ 2018-03-27 20:26 ` Bruce Richardson
0 siblings, 0 replies; 32+ messages in thread
From: Bruce Richardson @ 2018-03-27 20:26 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: Andrew Rybchenko, dev
On Tue, Mar 27, 2018 at 06:43:48PM +0200, Thomas Monjalon wrote:
> > --- a/drivers/net/bonding/meson.build
> > +++ b/drivers/net/bonding/meson.build
> > @@ -2,6 +2,7 @@
> > # Copyright(c) 2017 Intel Corporation
> >
> > name = 'bond' #, james bond :-)
>
> Ah ah ah, I had missed this important comment!
>
> Unfortunately I think the real name is "bonding".
> Does it mean the full name should be james bonding?
>
Nope, the name of the driver when built is "bond", according to the old
build system anyway. The name of the directory is "bonding", hence the
override here.
ls x86_64-native-linuxapp-gcc/lib/librte_pmd_bond*
x86_64-native-linuxapp-gcc/lib/librte_pmd_bond.a
Ideally, I'd like to be able to get rid of that "name" parameter entirely,
if we can just rename all directories to match the driver names exactly. In
this case, if we do want the driver to be called librte_pmd_bonding.a/.so,
then we just remove this override.
/Bruce
^ permalink raw reply [flat|nested] 32+ messages in thread
* [dpdk-dev] [PATCH 02/13] net/i40e: fix library version in meson build
2018-03-20 11:26 [dpdk-dev] [PATCH 00/13] build: fix library version in meson build Andrew Rybchenko
2018-03-20 11:26 ` [dpdk-dev] [PATCH 01/13] net/bonding: " Andrew Rybchenko
@ 2018-03-20 11:26 ` Andrew Rybchenko
2018-03-23 21:32 ` Bruce Richardson
2018-03-20 11:26 ` [dpdk-dev] [PATCH 03/13] net/ixgbe: " Andrew Rybchenko
` (11 subsequent siblings)
13 siblings, 1 reply; 32+ messages in thread
From: Andrew Rybchenko @ 2018-03-20 11:26 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson, stable
Fixes: e940646b20fa ("drivers/net: build Intel NIC PMDs with meson")
Cc: stable@dpdk.org
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/net/i40e/meson.build | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/i40e/meson.build b/drivers/net/i40e/meson.build
index 8764b0e..197e611 100644
--- a/drivers/net/i40e/meson.build
+++ b/drivers/net/i40e/meson.build
@@ -1,6 +1,8 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017 Intel Corporation
+version = 2
+
cflags += ['-DPF_DRIVER',
'-DVF_DRIVER',
'-DINTEGRATED_VF',
--
2.7.4
^ permalink raw reply [flat|nested] 32+ messages in thread* [dpdk-dev] [PATCH 03/13] net/ixgbe: fix library version in meson build
2018-03-20 11:26 [dpdk-dev] [PATCH 00/13] build: fix library version in meson build Andrew Rybchenko
2018-03-20 11:26 ` [dpdk-dev] [PATCH 01/13] net/bonding: " Andrew Rybchenko
2018-03-20 11:26 ` [dpdk-dev] [PATCH 02/13] net/i40e: " Andrew Rybchenko
@ 2018-03-20 11:26 ` Andrew Rybchenko
2018-03-23 21:37 ` Bruce Richardson
2018-03-20 11:26 ` [dpdk-dev] [PATCH 04/13] net/null: " Andrew Rybchenko
` (10 subsequent siblings)
13 siblings, 1 reply; 32+ messages in thread
From: Andrew Rybchenko @ 2018-03-20 11:26 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson, stable
Fixes: e940646b20fa ("drivers/net: build Intel NIC PMDs with meson")
Cc: stable@dpdk.org
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/net/ixgbe/meson.build | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ixgbe/meson.build b/drivers/net/ixgbe/meson.build
index 60af0ba..f649e65 100644
--- a/drivers/net/ixgbe/meson.build
+++ b/drivers/net/ixgbe/meson.build
@@ -1,6 +1,8 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017 Intel Corporation
+version = 2
+
cflags += ['-DRTE_LIBRTE_IXGBE_BYPASS']
subdir('base')
--
2.7.4
^ permalink raw reply [flat|nested] 32+ messages in thread* [dpdk-dev] [PATCH 04/13] net/null: fix library version in meson build
2018-03-20 11:26 [dpdk-dev] [PATCH 00/13] build: fix library version in meson build Andrew Rybchenko
` (2 preceding siblings ...)
2018-03-20 11:26 ` [dpdk-dev] [PATCH 03/13] net/ixgbe: " Andrew Rybchenko
@ 2018-03-20 11:26 ` Andrew Rybchenko
2018-03-23 21:37 ` Bruce Richardson
2018-03-20 11:26 ` [dpdk-dev] [PATCH 05/13] net/ring: " Andrew Rybchenko
` (9 subsequent siblings)
13 siblings, 1 reply; 32+ messages in thread
From: Andrew Rybchenko @ 2018-03-20 11:26 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson, stable
Fixes: efd5d1a8d8dd ("drivers/net: build some vdev PMDs with meson")
Cc: stable@dpdk.org
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/net/null/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/null/meson.build b/drivers/net/null/meson.build
index 68ac0d2..60e2ce6 100644
--- a/drivers/net/null/meson.build
+++ b/drivers/net/null/meson.build
@@ -1,4 +1,5 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017 Intel Corporation
+version = 2
sources = files('rte_eth_null.c')
--
2.7.4
^ permalink raw reply [flat|nested] 32+ messages in thread* [dpdk-dev] [PATCH 05/13] net/ring: fix library version in meson build
2018-03-20 11:26 [dpdk-dev] [PATCH 00/13] build: fix library version in meson build Andrew Rybchenko
` (3 preceding siblings ...)
2018-03-20 11:26 ` [dpdk-dev] [PATCH 04/13] net/null: " Andrew Rybchenko
@ 2018-03-20 11:26 ` Andrew Rybchenko
2018-03-23 21:38 ` Bruce Richardson
2018-03-20 11:26 ` [dpdk-dev] [PATCH 06/13] bitratestats: " Andrew Rybchenko
` (8 subsequent siblings)
13 siblings, 1 reply; 32+ messages in thread
From: Andrew Rybchenko @ 2018-03-20 11:26 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson, stable
Fixes: efd5d1a8d8dd ("drivers/net: build some vdev PMDs with meson")
Cc: stable@dpdk.org
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/net/ring/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ring/meson.build b/drivers/net/ring/meson.build
index e877a4b..7659b04 100644
--- a/drivers/net/ring/meson.build
+++ b/drivers/net/ring/meson.build
@@ -1,5 +1,6 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017 Intel Corporation
+version = 2
sources = files('rte_eth_ring.c')
install_headers('rte_eth_ring.h')
--
2.7.4
^ permalink raw reply [flat|nested] 32+ messages in thread* [dpdk-dev] [PATCH 06/13] bitratestats: fix library version in meson build
2018-03-20 11:26 [dpdk-dev] [PATCH 00/13] build: fix library version in meson build Andrew Rybchenko
` (4 preceding siblings ...)
2018-03-20 11:26 ` [dpdk-dev] [PATCH 05/13] net/ring: " Andrew Rybchenko
@ 2018-03-20 11:26 ` Andrew Rybchenko
2018-03-23 21:39 ` Bruce Richardson
2018-03-20 11:26 ` [dpdk-dev] [PATCH 07/13] cryptodev: " Andrew Rybchenko
` (7 subsequent siblings)
13 siblings, 1 reply; 32+ messages in thread
From: Andrew Rybchenko @ 2018-03-20 11:26 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson, stable
Fixes: 5b9656b157d3 ("lib: build with meson")
Cc: stable@dpdk.org
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
lib/librte_bitratestats/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_bitratestats/meson.build b/lib/librte_bitratestats/meson.build
index ede7e0a..c35b62b 100644
--- a/lib/librte_bitratestats/meson.build
+++ b/lib/librte_bitratestats/meson.build
@@ -1,6 +1,7 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017 Intel Corporation
+version = 2
sources = files('rte_bitrate.c')
headers = files('rte_bitrate.h')
deps += ['ethdev', 'metrics']
--
2.7.4
^ permalink raw reply [flat|nested] 32+ messages in thread* [dpdk-dev] [PATCH 07/13] cryptodev: fix library version in meson build
2018-03-20 11:26 [dpdk-dev] [PATCH 00/13] build: fix library version in meson build Andrew Rybchenko
` (5 preceding siblings ...)
2018-03-20 11:26 ` [dpdk-dev] [PATCH 06/13] bitratestats: " Andrew Rybchenko
@ 2018-03-20 11:26 ` Andrew Rybchenko
2018-03-23 21:40 ` Bruce Richardson
2018-03-20 11:26 ` [dpdk-dev] [PATCH 08/13] eventdev: " Andrew Rybchenko
` (6 subsequent siblings)
13 siblings, 1 reply; 32+ messages in thread
From: Andrew Rybchenko @ 2018-03-20 11:26 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson, stable
Fixes: 5b9656b157d3 ("lib: build with meson")
Cc: stable@dpdk.org
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
lib/librte_cryptodev/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_cryptodev/meson.build b/lib/librte_cryptodev/meson.build
index 234da32..bd5fed8 100644
--- a/lib/librte_cryptodev/meson.build
+++ b/lib/librte_cryptodev/meson.build
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017 Intel Corporation
-version = 3
+version = 4
sources = files('rte_cryptodev.c', 'rte_cryptodev_pmd.c')
headers = files('rte_cryptodev.h',
'rte_cryptodev_pmd.h',
--
2.7.4
^ permalink raw reply [flat|nested] 32+ messages in thread* [dpdk-dev] [PATCH 08/13] eventdev: fix library version in meson build
2018-03-20 11:26 [dpdk-dev] [PATCH 00/13] build: fix library version in meson build Andrew Rybchenko
` (6 preceding siblings ...)
2018-03-20 11:26 ` [dpdk-dev] [PATCH 07/13] cryptodev: " Andrew Rybchenko
@ 2018-03-20 11:26 ` Andrew Rybchenko
2018-03-23 21:40 ` Bruce Richardson
2018-03-20 11:26 ` [dpdk-dev] [PATCH 09/13] mempool: " Andrew Rybchenko
` (5 subsequent siblings)
13 siblings, 1 reply; 32+ messages in thread
From: Andrew Rybchenko @ 2018-03-20 11:26 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson, stable
Fixes: 5b9656b157d3 ("lib: build with meson")
Cc: stable@dpdk.org
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
lib/librte_eventdev/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eventdev/meson.build b/lib/librte_eventdev/meson.build
index d1a9960..e1e22a5 100644
--- a/lib/librte_eventdev/meson.build
+++ b/lib/librte_eventdev/meson.build
@@ -1,6 +1,7 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017 Intel Corporation
+version = 3
allow_experimental_apis = true
sources = files('rte_eventdev.c',
'rte_event_ring.c',
--
2.7.4
^ permalink raw reply [flat|nested] 32+ messages in thread* [dpdk-dev] [PATCH 09/13] mempool: fix library version in meson build
2018-03-20 11:26 [dpdk-dev] [PATCH 00/13] build: fix library version in meson build Andrew Rybchenko
` (7 preceding siblings ...)
2018-03-20 11:26 ` [dpdk-dev] [PATCH 08/13] eventdev: " Andrew Rybchenko
@ 2018-03-20 11:26 ` Andrew Rybchenko
2018-03-23 21:41 ` Bruce Richardson
2018-03-20 11:26 ` [dpdk-dev] [PATCH 10/13] pdump: " Andrew Rybchenko
` (4 subsequent siblings)
13 siblings, 1 reply; 32+ messages in thread
From: Andrew Rybchenko @ 2018-03-20 11:26 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson, stable
Fixes: 5b9656b157d3 ("lib: build with meson")
Cc: stable@dpdk.org
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
lib/librte_mempool/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_mempool/meson.build b/lib/librte_mempool/meson.build
index 7a4f3da..712720f 100644
--- a/lib/librte_mempool/meson.build
+++ b/lib/librte_mempool/meson.build
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017 Intel Corporation
-version = 2
+version = 3
sources = files('rte_mempool.c', 'rte_mempool_ops.c')
headers = files('rte_mempool.h')
deps += ['ring']
--
2.7.4
^ permalink raw reply [flat|nested] 32+ messages in thread* [dpdk-dev] [PATCH 10/13] pdump: fix library version in meson build
2018-03-20 11:26 [dpdk-dev] [PATCH 00/13] build: fix library version in meson build Andrew Rybchenko
` (8 preceding siblings ...)
2018-03-20 11:26 ` [dpdk-dev] [PATCH 09/13] mempool: " Andrew Rybchenko
@ 2018-03-20 11:26 ` Andrew Rybchenko
2018-03-23 21:42 ` Bruce Richardson
2018-03-20 11:26 ` [dpdk-dev] [PATCH 11/13] table: " Andrew Rybchenko
` (3 subsequent siblings)
13 siblings, 1 reply; 32+ messages in thread
From: Andrew Rybchenko @ 2018-03-20 11:26 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson, stable
Fixes: 5b9656b157d3 ("lib: build with meson")
Cc: stable@dpdk.org
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
lib/librte_pdump/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_pdump/meson.build b/lib/librte_pdump/meson.build
index 3a95eab..435107a 100644
--- a/lib/librte_pdump/meson.build
+++ b/lib/librte_pdump/meson.build
@@ -1,6 +1,7 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017 Intel Corporation
+version = 2
sources = files('rte_pdump.c')
headers = files('rte_pdump.h')
deps += ['ethdev']
--
2.7.4
^ permalink raw reply [flat|nested] 32+ messages in thread* [dpdk-dev] [PATCH 11/13] table: fix library version in meson build
2018-03-20 11:26 [dpdk-dev] [PATCH 00/13] build: fix library version in meson build Andrew Rybchenko
` (9 preceding siblings ...)
2018-03-20 11:26 ` [dpdk-dev] [PATCH 10/13] pdump: " Andrew Rybchenko
@ 2018-03-20 11:26 ` Andrew Rybchenko
2018-03-23 21:42 ` Bruce Richardson
2018-03-20 11:26 ` [dpdk-dev] [PATCH 12/13] ethdev: " Andrew Rybchenko
` (2 subsequent siblings)
13 siblings, 1 reply; 32+ messages in thread
From: Andrew Rybchenko @ 2018-03-20 11:26 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson, stable
Fixes: 5b9656b157d3 ("lib: build with meson")
Cc: stable@dpdk.org
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
lib/librte_table/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_table/meson.build b/lib/librte_table/meson.build
index 13e797b..0944bef 100644
--- a/lib/librte_table/meson.build
+++ b/lib/librte_table/meson.build
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017 Intel Corporation
-version = 2
+version = 3
sources = files('rte_table_lpm.c', 'rte_table_lpm_ipv6.c',
'rte_table_hash_cuckoo.c', 'rte_table_hash_key8.c',
'rte_table_hash_key16.c', 'rte_table_hash_key32.c',
--
2.7.4
^ permalink raw reply [flat|nested] 32+ messages in thread* [dpdk-dev] [PATCH 12/13] ethdev: fix library version in meson build
2018-03-20 11:26 [dpdk-dev] [PATCH 00/13] build: fix library version in meson build Andrew Rybchenko
` (10 preceding siblings ...)
2018-03-20 11:26 ` [dpdk-dev] [PATCH 11/13] table: " Andrew Rybchenko
@ 2018-03-20 11:26 ` Andrew Rybchenko
2018-03-23 21:46 ` Bruce Richardson
2018-03-20 11:26 ` [dpdk-dev] [PATCH 13/13] meter: " Andrew Rybchenko
2018-03-23 21:50 ` [dpdk-dev] [PATCH 00/13] build: " Bruce Richardson
13 siblings, 1 reply; 32+ messages in thread
From: Andrew Rybchenko @ 2018-03-20 11:26 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson
Fixes: 701ac75666b9 ("ethdev: remove versioning of ethdev filter control function")
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
lib/librte_ether/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_ether/meson.build b/lib/librte_ether/meson.build
index 7fed860..12bdb6b 100644
--- a/lib/librte_ether/meson.build
+++ b/lib/librte_ether/meson.build
@@ -2,7 +2,7 @@
# Copyright(c) 2017 Intel Corporation
name = 'ethdev'
-version = 8
+version = 9
allow_experimental_apis = true
sources = files('ethdev_profile.c',
'rte_ethdev.c',
--
2.7.4
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: [dpdk-dev] [PATCH 12/13] ethdev: fix library version in meson build
2018-03-20 11:26 ` [dpdk-dev] [PATCH 12/13] ethdev: " Andrew Rybchenko
@ 2018-03-23 21:46 ` Bruce Richardson
2018-04-05 17:33 ` Ferruh Yigit
0 siblings, 1 reply; 32+ messages in thread
From: Bruce Richardson @ 2018-03-23 21:46 UTC (permalink / raw)
To: Andrew Rybchenko; +Cc: dev
On Tue, Mar 20, 2018 at 11:26:26AM +0000, Andrew Rybchenko wrote:
> Fixes: 701ac75666b9 ("ethdev: remove versioning of ethdev filter control function")
>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> lib/librte_ether/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_ether/meson.build b/lib/librte_ether/meson.build
> index 7fed860..12bdb6b 100644
> --- a/lib/librte_ether/meson.build
> +++ b/lib/librte_ether/meson.build
> @@ -2,7 +2,7 @@
> # Copyright(c) 2017 Intel Corporation
>
> name = 'ethdev'
> -version = 8
> +version = 9
My copy of latest head in git shows this as still being 8. However, I see
it's down as 9 in next-net. Therefore I think we need to put this patch
into next-net, perhaps merging with the appropriate patch there which
updates the Makefile.
Ferruh, perhaps you could look at this one?
/Bruce
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: [dpdk-dev] [PATCH 12/13] ethdev: fix library version in meson build
2018-03-23 21:46 ` Bruce Richardson
@ 2018-04-05 17:33 ` Ferruh Yigit
0 siblings, 0 replies; 32+ messages in thread
From: Ferruh Yigit @ 2018-04-05 17:33 UTC (permalink / raw)
To: Bruce Richardson, Andrew Rybchenko; +Cc: dev
On 3/23/2018 9:46 PM, Bruce Richardson wrote:
> On Tue, Mar 20, 2018 at 11:26:26AM +0000, Andrew Rybchenko wrote:
>> Fixes: 701ac75666b9 ("ethdev: remove versioning of ethdev filter control function")
>>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>> ---
>> lib/librte_ether/meson.build | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/librte_ether/meson.build b/lib/librte_ether/meson.build
>> index 7fed860..12bdb6b 100644
>> --- a/lib/librte_ether/meson.build
>> +++ b/lib/librte_ether/meson.build
>> @@ -2,7 +2,7 @@
>> # Copyright(c) 2017 Intel Corporation
>>
>> name = 'ethdev'
>> -version = 8
>> +version = 9
>
> My copy of latest head in git shows this as still being 8. However, I see
> it's down as 9 in next-net. Therefore I think we need to put this patch
> into next-net, perhaps merging with the appropriate patch there which
> updates the Makefile.
>
> Ferruh, perhaps you could look at this one?
Applied to dpdk-next-net/master, thanks.
(Not able to squash because next-net pulled from main tree and the original
commit is now part of main tree)
^ permalink raw reply [flat|nested] 32+ messages in thread
* [dpdk-dev] [PATCH 13/13] meter: fix library version in meson build
2018-03-20 11:26 [dpdk-dev] [PATCH 00/13] build: fix library version in meson build Andrew Rybchenko
` (11 preceding siblings ...)
2018-03-20 11:26 ` [dpdk-dev] [PATCH 12/13] ethdev: " Andrew Rybchenko
@ 2018-03-20 11:26 ` Andrew Rybchenko
2018-03-23 21:48 ` Bruce Richardson
2018-03-23 21:50 ` [dpdk-dev] [PATCH 00/13] build: " Bruce Richardson
13 siblings, 1 reply; 32+ messages in thread
From: Andrew Rybchenko @ 2018-03-20 11:26 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson
Fixes: c06ddf9698e0 ("meter: add configuration profile")
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
lib/librte_meter/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_meter/meson.build b/lib/librte_meter/meson.build
index 646fd4d..947bc19 100644
--- a/lib/librte_meter/meson.build
+++ b/lib/librte_meter/meson.build
@@ -1,5 +1,6 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017 Intel Corporation
+version = 2
sources = files('rte_meter.c')
headers = files('rte_meter.h')
--
2.7.4
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: [dpdk-dev] [PATCH 00/13] build: fix library version in meson build
2018-03-20 11:26 [dpdk-dev] [PATCH 00/13] build: fix library version in meson build Andrew Rybchenko
` (12 preceding siblings ...)
2018-03-20 11:26 ` [dpdk-dev] [PATCH 13/13] meter: " Andrew Rybchenko
@ 2018-03-23 21:50 ` Bruce Richardson
2018-03-27 22:08 ` Thomas Monjalon
13 siblings, 1 reply; 32+ messages in thread
From: Bruce Richardson @ 2018-03-23 21:50 UTC (permalink / raw)
To: Andrew Rybchenko, thomas, ferruh.yigit; +Cc: dev
On Tue, Mar 20, 2018 at 11:26:14AM +0000, Andrew Rybchenko wrote:
> Library version is specified in two places: Makefile and meson.build.
> It is out-of-sync in a number of cases.
>
> Andrew Rybchenko (13):
> net/bonding: fix library version in meson build
> net/i40e: fix library version in meson build
> net/ixgbe: fix library version in meson build
> net/null: fix library version in meson build
> net/ring: fix library version in meson build
> bitratestats: fix library version in meson build
> cryptodev: fix library version in meson build
> eventdev: fix library version in meson build
> mempool: fix library version in meson build
> pdump: fix library version in meson build
> table: fix library version in meson build
> ethdev: fix library version in meson build
> meter: fix library version in meson build
>
Hi Thomas,
these are all trivial fixes, so I think they should go into the main tree
directly rather than going via next-build. Can you apply them, please -
apart from patch 12, which should go to Ferruh's tree, I think?
Regards,
/Bruce
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: [dpdk-dev] [PATCH 00/13] build: fix library version in meson build
2018-03-23 21:50 ` [dpdk-dev] [PATCH 00/13] build: " Bruce Richardson
@ 2018-03-27 22:08 ` Thomas Monjalon
0 siblings, 0 replies; 32+ messages in thread
From: Thomas Monjalon @ 2018-03-27 22:08 UTC (permalink / raw)
To: Andrew Rybchenko; +Cc: dev, Bruce Richardson, ferruh.yigit
23/03/2018 22:50, Bruce Richardson:
> On Tue, Mar 20, 2018 at 11:26:14AM +0000, Andrew Rybchenko wrote:
> > Library version is specified in two places: Makefile and meson.build.
> > It is out-of-sync in a number of cases.
> >
> > Andrew Rybchenko (13):
> > net/bonding: fix library version in meson build
> > net/i40e: fix library version in meson build
> > net/ixgbe: fix library version in meson build
> > net/null: fix library version in meson build
> > net/ring: fix library version in meson build
> > bitratestats: fix library version in meson build
> > cryptodev: fix library version in meson build
> > eventdev: fix library version in meson build
> > mempool: fix library version in meson build
> > pdump: fix library version in meson build
> > table: fix library version in meson build
> > ethdev: fix library version in meson build
> > meter: fix library version in meson build
> >
>
> Hi Thomas,
>
> these are all trivial fixes, so I think they should go into the main tree
> directly rather than going via next-build. Can you apply them, please -
> apart from patch 12, which should go to Ferruh's tree, I think?
Applied, except patch 12 (ethdev), thanks
^ permalink raw reply [flat|nested] 32+ messages in thread