From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 53F842965 for ; Thu, 29 Mar 2018 14:52:58 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Mar 2018 05:52:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,376,1517904000"; d="scan'208";a="43223306" Received: from fanzhan2-mobl.ger.corp.intel.com (HELO ubuntu.ger.corp.intel.com) ([10.252.23.170]) by orsmga001.jf.intel.com with ESMTP; 29 Mar 2018 05:52:56 -0700 From: Fan Zhang To: dev@dpdk.org Cc: maxime.coquelin@redhat.com, jianjay.zhou@huawei.com, jianfeng.tan@intel.com Date: Thu, 29 Mar 2018 07:52:47 -0500 Message-Id: <1522327975-28769-1-git-send-email-roy.fan.zhang@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <20180326095114.11605-1-roy.fan.zhang@intel.com> References: <20180326095114.11605-1-roy.fan.zhang@intel.com> Subject: [dpdk-dev] [PATCH v4 0/8] vhost: intdroduce vhost user crypto backend X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2018 12:52:59 -0000 This patchset adds crypto backend suppport to vhost library including a proof-of-concept sample application. The implementation follows the virtio-crypto specification and have been tested with qemu 2.11.50 (with several patches applied, detailed later) with Fedora 24 running in the frontend. The vhost_crypto library acts as a "bridge" method that translate the virtio-crypto crypto requests to DPDK crypto operations, so it is purely software implementation. However it does require the user to provide the DPDK Cryptodev ID so it knows how to handle the virtio-crypto session creation and deletion mesages. Currently the implementation supports AES-CBC-128 and HMAC-SHA1 cipher only/chaining modes and does not support sessionless mode yet. The guest can use standard virtio-crypto driver to set up session and sends encryption/decryption requests to backend. The vhost-crypto sample application provided in this patchset will do the actual crypto work. The following steps are involved to enable vhost-crypto support. In the host: 1. Download the qemu source code. 2. Recompile your qemu with vhost-crypto option enabled. 3. Apply this patchset to latest DPDK code and recompile DPDK. 4. Compile and run vhost-crypto sample application. ./examples/vhost_crypto/build/vhost-crypto -l 11,12 -w 0000:86:01.0 \ --socket-mem 2048,2048 Where 0000:86:01.0 is the QAT PCI address. You may use AES-NI-MB if it is not available. The sample application requires 2 lcores: 1 master and 1 worker. The application will create a UNIX socket file /tmp/vhost_crypto1.socket. 5. Start your qemu application. Here is my command: qemu/x86_64-softmmu/qemu-system-x86_64 -machine accel=kvm -cpu host \ -smp 2 -m 1G -hda ~/path-to-your/image.qcow \ -object memory-backend-file,id=mem,size=1G,mem-path=/dev/hugepages,share=on \ -mem-prealloc -numa node,memdev=mem -chardev \ socket,id=charcrypto0,path=/tmp/vhost_crypto1.socket \ -object cryptodev-vhost-user,id=cryptodev0,chardev=charcrypto0 \ -device virtio-crypto-pci,id=crypto0,cryptodev=cryptodev0 6. Once guest is booted. The Linux virtio_crypto kernel module is loaded by default. You shall see the following logs in your demsg: [ 17.611044] virtio_crypto: loading out-of-tree module taints kernel. [ 17.611083] virtio_crypto: module verification failed: signature and/or ... [ 17.611723] virtio_crypto virtio0: max_queues: 1, max_cipher_key_len: ... [ 17.612156] virtio_crypto virtio0: will run requests pump with realtime ... [ 18.376100] virtio_crypto virtio0: Accelerator is ready The virtio_crypto driver in the guest is now up and running. 7. The rest steps can be as same as the Testing section in https://wiki.qemu.org/Features/VirtioCrypto 8. It is possible to use DPDK Virtio Crypto PMD (https://dpdk.org/dev/patchwork/patch/36471/) in the guest to work with this patchset to achieve optimal performance. v4: - Changed external vhost backend ops register API. - Fixed a bug. v3: - Changed external vhost backend private data and message handling - Added experimental tag to rte_vhost_crypto_set_zero_copy() v2: - Moved vhost_crypto_data_req data from crypto op to source mbuf. - Removed ZERO-COPY flag from config option and make it run-timely changeable. - Guest-polling mode possible. - Simplified vring descriptor access procedure. - Work with both LKCF and DPDK Virtio-Crypto PMD guest drivers. Fan Zhang (8): lib/librte_vhost: add external backend support lib/librte_vhost: add virtio-crypto user message structure lib/librte_vhost: add session message handler lib/librte_vhost: add request handler lib/librte_vhost: add public function implementation lib/librte_vhost: update makefile examples/vhost_crypto: add vhost crypto sample application doc: update for vhost crypto support doc/guides/prog_guide/vhost_lib.rst | 21 + doc/guides/rel_notes/release_18_05.rst | 10 + doc/guides/sample_app_ug/index.rst | 1 + doc/guides/sample_app_ug/vhost_crypto.rst | 84 ++ examples/vhost_crypto/Makefile | 32 + examples/vhost_crypto/main.c | 541 ++++++++++++ examples/vhost_crypto/meson.build | 14 + lib/librte_vhost/Makefile | 6 +- lib/librte_vhost/meson.build | 8 +- lib/librte_vhost/rte_vhost.h | 64 +- lib/librte_vhost/rte_vhost_crypto.h | 125 +++ lib/librte_vhost/rte_vhost_version.map | 11 + lib/librte_vhost/vhost.c | 17 +- lib/librte_vhost/vhost.h | 8 +- lib/librte_vhost/vhost_crypto.c | 1285 +++++++++++++++++++++++++++++ lib/librte_vhost/vhost_user.c | 33 +- lib/librte_vhost/vhost_user.h | 36 +- 17 files changed, 2281 insertions(+), 15 deletions(-) create mode 100644 doc/guides/sample_app_ug/vhost_crypto.rst create mode 100644 examples/vhost_crypto/Makefile create mode 100644 examples/vhost_crypto/main.c create mode 100644 examples/vhost_crypto/meson.build create mode 100644 lib/librte_vhost/rte_vhost_crypto.h create mode 100644 lib/librte_vhost/vhost_crypto.c -- 2.7.4