From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 446B62C27 for ; Thu, 13 Apr 2017 08:53:39 +0200 (CEST) Received: by mail-wm0-f54.google.com with SMTP id u2so39446229wmu.0 for ; Wed, 12 Apr 2017 23:53:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=agEI3fntivgFxLQQzRTIoPFjGLoYcBki9KH49M8B4AM=; b=dLHxCi4/3GsiMz4qsNuq80JVsQ0Gl0PI5Y8zzKty47fleozjloEjtglD+bRtnQjjwr KWvMKOcC5yhIQEus47gEcGk/M8EnnLaMjW75nNsSln49CVOumLxeA6FzGIFzpApRXN73 C79s5V/zxD/lnt323D449mRF+cV7DbuoWZvvynjKyrKzD71yvG7gysKsO8GUBn/zZf8O pRW4lcQnrZdFyf2TtJaP/+xbyg0rxOqoY2kt206VTuZwSIJVzWkMv4myvnZ+36u7zDRj q6wBATeU2L9pkbYEkeqUvY3GLABf+NZJGv01Kc5dghH8CruvtrRZSWAwO1153E1grAsg Zahg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=agEI3fntivgFxLQQzRTIoPFjGLoYcBki9KH49M8B4AM=; b=WLmkwOAvITEVcM8uK605tP76Q5bgjYHqoN64SnoX3aBunxO5pVQ8pXHLi08FRowOJC hxkiIaiEKq9cz95Lk4aWPhlp7UAvbHCcTgKWjOD6MjH/cVyX14nir2hC/0OL8E2TVIj0 M6zknp3ZujY3C3hYWx2sOhC33ZveKGIdAVbIsPBJnHKIP79qWN1KeJ9H7yUviDXYDvIN Wdl7CB+7R0EMAqrjxSYRaYOIZCg8GP7hAO9kRC3JpEnOCTbJ8kb9GnuWpN8Esuu3eLu9 QAEJcL6KHgC6/phk59EAkt68IPj99h+7t3ooQjJm/LD9AQ+6/MntzEbjQ30jpyXdxs8U cLsQ== X-Gm-Message-State: AN3rC/5IpPSuh0ECfDzAUzYccZjJMCERCuZeQmsJytASQvE4/OR+2KJ/ BsoZG6rzB8d6Iaz7 X-Received: by 10.28.16.149 with SMTP id 143mr1607447wmq.42.1492066419009; Wed, 12 Apr 2017 23:53:39 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id 201sm9332361wmr.5.2017.04.12.23.53.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Apr 2017 23:53:38 -0700 (PDT) From: Thomas Monjalon To: Shreyansh Jain Cc: Olivier MATZ , "Richardson, Bruce" , john miller , dev@dpdk.org Date: Thu, 13 Apr 2017 08:53:37 +0200 Message-ID: <15226233.lg7mjYJUEo@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <357262EF-AA7B-4064-963E-FF130E4607E6@atomicrules.com> <20170412215520.44c485a2@neon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] error in testpmd when CONFIG_RTE_BUILD_SHARED_LIB=y X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Apr 2017 06:53:39 -0000 2017-04-13 12:11, Shreyansh Jain: > On Thursday 13 April 2017 01:25 AM, Olivier MATZ wrote: > > Hi, > > > > On Wed, 12 Apr 2017 14:31:56 +0200 > > Thomas Monjalon wrote: > > > >> 2017-04-12 11:31, Richardson, Bruce: > >>> > > [...] > > >> > >> I think the default mempool could be linked. > >> I don't know how easy it is to transform > >> CONFIG_RTE_MBUF_DEFAULT_MEMPOOL_OPS="ring_mp_mc" > >> into > >> -lrte_mempool_ring > >> > >> Anyone for a patch? > > > > This is the default mempool for the mbufs, selected when using the > > function rte_pktmbuf_pool_create(). > > > > For non-mbuf mempools, the default is to use the ring handler (see > > in rte_mempool_create()). > > > > So if we want option 2-, it looks that moving this line in rte.app.mk > > above, outside the if (shared build), would do the job: > > > > _LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_RING) += -lrte_mempool_ring > > > > I think both 2- and 3- are acceptable. People using the shared library > > mode should already provide all the .so in a known location, so that > > they are loaded by default. This is needed for the PMDs for instance. > > > > I can send the patch; > before that, should this fact, that ring is included by default, is to > be documented somewhere? Yes good idea. Instead of "included", you could say "linked" without the need for -d option. But actually, the mempool drivers are not documented. We should totally update this section: http://dpdk.org/doc/guides/prog_guide/mempool_lib.html#mempool-handlers So it should be another patch.