From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mta.qwilt.com (mta.qwilt.com [52.9.191.255]) by dpdk.org (Postfix) with ESMTP id 389971C0F2 for ; Wed, 4 Apr 2018 13:27:46 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mta.qwilt.com (Postfix) with ESMTP id 6E9BF8069DB; Wed, 4 Apr 2018 11:27:45 +0000 (UTC) X-Virus-Scanned: amavisd-new at qwilt.com Received: from mta.qwilt.com ([127.0.0.1]) by localhost (mta.qwilt.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jV6qdHN6A964; Wed, 4 Apr 2018 11:27:45 +0000 (UTC) Received: from rd01.it.qwilt.com.qwilt.com (80.179.204.39.cable.012.net.il [80.179.204.39]) by mta.qwilt.com (Postfix) with ESMTPSA id AF50E806587; Wed, 4 Apr 2018 11:27:42 +0000 (UTC) From: Arnon Warshavsky To: thomas@monjalon.net, anatoly.burakov@intel.com, wenzhuo.lu@intel.com, declan.doherty@intel.com, jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com, ferruh.yigit@intel.com Cc: dev@dpdk.org, arnon@qwilt.com Date: Wed, 4 Apr 2018 14:27:24 +0300 Message-Id: <1522841257-11826-1-git-send-email-arnon@qwilt.com> X-Mailer: git-send-email 1.8.3.1 Subject: [dpdk-dev] eal: replace calls to rte_panic and refrain from new instances X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Apr 2018 11:27:46 -0000 The purpose of this patch series is to cleanup the library code from paths that end up aborting the process, and move to checking error values, in order to allow the running process perform an orderly teardown or other mitigation of the event. This patch modifies the majority of rte_panic calls under lib and drivers, and replaces them with a log message and an error return code according to context, that can be propagated up the call stack. - Focus was given to the dpdk initialization path - Some of the panic calls within drivers were left in place where the call is from within an interrupt or calls that are on the data path,where there is no simple applicative route to propagate the error to temination. These should be handled by the driver maintainers. - In order to avoid breaking ABI where panic was called from public void functions, a panic state variable was introduced so that it can be queried after calling these void functions. This tool place for a single function call. - local void functions with no api were changed to retrun a value where needed - No change took place in example and test files - No change took place for debug assertions calling panic - A new function was added to devtools/checkpatches.sh in order to prevent new additions of calls to rte_panic under lib and drivers. Keep calm and don't panic. Arnon Warshavsky (13): crypto: replace rte_panic instances in crypto driver bond: replace rte_panic instances in bonding driver e1000: replace rte_panic instances in e1000 driver ixgbe: replace rte_panic instances in ixgbe driver eal: replace rte_panic instances in eventdev kni: replace rte_panic instances in kni e1000: replace rte_panic instances in e1000 driver eal: replace rte_panic instances in hugepage_info eal: replace rte_panic instances in common_memzone eal: replace rte_panic instances in interrupts thread eal: replace rte_panic instances in ethdev eal: replace rte_panic instances in init sequence devtools: prevent new instances of rte_panic and rte_exit devtools/checkpatches.sh | 94 ++++++++++++++++- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +- drivers/crypto/dpaa_sec/dpaa_sec.c | 8 +- drivers/net/bonding/rte_eth_bond_8023ad.c | 30 ++++-- drivers/net/bonding/rte_eth_bond_8023ad_private.h | 2 +- drivers/net/bonding/rte_eth_bond_api.c | 20 ++-- drivers/net/bonding/rte_eth_bond_pmd.c | 10 +- drivers/net/bonding/rte_eth_bond_private.h | 2 +- drivers/net/e1000/e1000_ethdev.h | 2 +- drivers/net/e1000/igb_ethdev.c | 3 +- drivers/net/e1000/igb_pf.c | 15 +-- drivers/net/ixgbe/ixgbe_ethdev.c | 3 +- drivers/net/ixgbe/ixgbe_ethdev.h | 2 +- drivers/net/ixgbe/ixgbe_pf.c | 13 ++- lib/librte_eal/bsdapp/eal/eal.c | 87 +++++++++++----- lib/librte_eal/bsdapp/eal/eal_thread.c | 65 +++++++++--- lib/librte_eal/common/eal_common_launch.c | 21 ++++ lib/librte_eal/common/eal_common_memzone.c | 5 +- lib/librte_eal/common/include/rte_debug.h | 12 +++ lib/librte_eal/common/rte_malloc.c | 7 +- lib/librte_eal/linuxapp/eal/eal.c | 121 +++++++++++++++------- lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 21 ++-- lib/librte_eal/linuxapp/eal/eal_interrupts.c | 27 +++-- lib/librte_eal/linuxapp/eal/eal_thread.c | 65 +++++++++--- lib/librte_ether/rte_ethdev.c | 36 +++++-- lib/librte_eventdev/rte_eventdev_pmd_pci.h | 8 +- lib/librte_eventdev/rte_eventdev_pmd_vdev.h | 8 +- lib/librte_kni/rte_kni.c | 18 ++-- lib/librte_kni/rte_kni_fifo.h | 11 +- 29 files changed, 540 insertions(+), 184 deletions(-) -- 1.8.3.1