From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mta.qwilt.com (mta.qwilt.com [52.9.191.255]) by dpdk.org (Postfix) with ESMTP id 8FD4A1C8F6 for ; Thu, 5 Apr 2018 00:01:52 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mta.qwilt.com (Postfix) with ESMTP id 0B5998069DA; Wed, 4 Apr 2018 22:01:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at qwilt.com Received: from mta.qwilt.com ([127.0.0.1]) by localhost (mta.qwilt.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UCBnD2lL2Wtz; Wed, 4 Apr 2018 22:01:51 +0000 (UTC) Received: from rd01.it.qwilt.com.qwilt.com (80.179.204.39.cable.012.net.il [80.179.204.39]) by mta.qwilt.com (Postfix) with ESMTPSA id 6E05B806587; Wed, 4 Apr 2018 22:01:49 +0000 (UTC) From: Arnon Warshavsky To: thomas@monjalon.net, anatoly.burakov@intel.com, wenzhuo.lu@intel.com, declan.doherty@intel.com, jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com, ferruh.yigit@intel.com Cc: dev@dpdk.org, arnon@qwilt.com Date: Thu, 5 Apr 2018 01:01:34 +0300 Message-Id: <1522879294-8803-3-git-send-email-arnon@qwilt.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1522879294-8803-1-git-send-email-arnon@qwilt.com> References: <1522879294-8803-1-git-send-email-arnon@qwilt.com> Subject: [dpdk-dev] [PATCH v2 01/13] crypto: replace rte_panic instances in crypto driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Apr 2018 22:01:52 -0000 replace panic calls with log and return value. -- v2: - reformat error message to include literal string in a single line Signed-off-by: Arnon Warshavsky --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +++++--- drivers/crypto/dpaa_sec/dpaa_sec.c | 8 +++++--- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c index 784b96d..9e0ca7f 100644 --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c @@ -2861,9 +2861,11 @@ struct rte_security_ops dpaa2_sec_security_ops = { RTE_CACHE_LINE_SIZE, rte_socket_id()); - if (cryptodev->data->dev_private == NULL) - rte_panic("Cannot allocate memzone for private " - "device data"); + if (cryptodev->data->dev_private == NULL) { + RTE_LOG(ERR, PMD, "%s() Cannot allocate memzone for private device data", + __func__); + return -1; + } } dpaa2_dev->cryptodev = cryptodev; diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c index c5191ce..793891a 100644 --- a/drivers/crypto/dpaa_sec/dpaa_sec.c +++ b/drivers/crypto/dpaa_sec/dpaa_sec.c @@ -2374,9 +2374,11 @@ struct rte_security_ops dpaa_sec_security_ops = { RTE_CACHE_LINE_SIZE, rte_socket_id()); - if (cryptodev->data->dev_private == NULL) - rte_panic("Cannot allocate memzone for private " - "device data"); + if (cryptodev->data->dev_private == NULL) { + RTE_LOG(ERR, PMD, "%s() Cannot allocate memzone for private device data", + __func__); + return -1; + } } dpaa_dev->crypto_dev = cryptodev; -- 1.8.3.1