From: Vipin Varghese <vipin.varghese@intel.com>
To: dev@dpdk.org, harry.van.haaren@intel.com
Cc: jerin.jacob@caviumnetworks.com,
Vipin Varghese <vipin.varghese@intel.com>
Subject: [dpdk-dev] [PATCH v3] event/sw: code refractor to reduce the fetch stall
Date: Thu, 5 Apr 2018 11:26:30 +0530 [thread overview]
Message-ID: <1522907790-484-1-git-send-email-vipin.varghese@intel.com> (raw)
In-Reply-To: <1522927443-13796-1-git-send-email-vipin.varghese@intel.com>
With rearranging the code to prefetch the contents before
loop check increases performance from single and multistage
atomic pipeline.
Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
---
Changes in V3:
- fix compilation for initial element - Vipin
- fix the time and date for email sent - Vipin
Changes in V2:
- compilation fix for const flowid - Harry
- Removal of sw_refill_pp_buf logic - Harry
---
drivers/event/sw/sw_evdev_scheduler.c | 19 ++++++++++++++-----
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/drivers/event/sw/sw_evdev_scheduler.c b/drivers/event/sw/sw_evdev_scheduler.c
index e3a41e0..5eb3157 100644
--- a/drivers/event/sw/sw_evdev_scheduler.c
+++ b/drivers/event/sw/sw_evdev_scheduler.c
@@ -44,12 +44,13 @@
uint32_t qid_id = qid->id;
iq_dequeue_burst(sw, &qid->iq[iq_num], qes, count);
- for (i = 0; i < count; i++) {
- const struct rte_event *qe = &qes[i];
- const uint16_t flow_id = SW_HASH_FLOWID(qes[i].flow_id);
- struct sw_fid_t *fid = &qid->fids[flow_id];
- int cq = fid->cq;
+ const struct rte_event *qe = &qes[0];
+ uint16_t flow_id = SW_HASH_FLOWID(qes[0].flow_id);
+ struct sw_fid_t *fid = &qid->fids[flow_id];
+ int cq = fid->cq;
+
+ for (i = 0; i < count; i++) {
if (cq < 0) {
uint32_t cq_idx = qid->cq_next_tx++;
if (qid->cq_next_tx == qid->cq_num_mapped_cqs)
@@ -101,6 +102,14 @@
&sw->cq_ring_space[cq]);
p->cq_buf_count = 0;
}
+
+ if (likely(i+1 < count)) {
+ qe = (qes + i + 1);
+ flow_id = SW_HASH_FLOWID(qes[i + 1].flow_id);
+ fid = &qid->fids[flow_id];
+ cq = fid->cq;
+ }
+
}
iq_put_back(sw, &qid->iq[iq_num], blocked_qes, nb_blocked);
--
1.9.1
next prev parent reply other threads:[~2018-04-05 5:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 19:34 [dpdk-dev] [PATCH 1/2] " Vipin Varghese
2018-03-01 19:35 ` [dpdk-dev] [PATCH 2/2] event/sw: code refractor for sw_refill_pp_buf Vipin Varghese
2018-04-03 12:50 ` Van Haaren, Harry
2018-04-04 11:51 ` Varghese, Vipin
2018-04-04 12:26 ` Van Haaren, Harry
2018-04-02 8:06 ` [dpdk-dev] [PATCH 1/2] event/sw: code refractor to reduce the fetch stall Jerin Jacob
2018-04-03 12:47 ` Van Haaren, Harry
2018-04-05 11:24 ` [dpdk-dev] [PATCH v2] " Vipin Varghese
2018-04-05 5:56 ` Vipin Varghese [this message]
2018-04-05 8:53 ` [dpdk-dev] [PATCH v3] " Jerin Jacob
2018-04-13 16:19 ` Van Haaren, Harry
2018-04-14 5:28 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1522907790-484-1-git-send-email-vipin.varghese@intel.com \
--to=vipin.varghese@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).