From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0064.outbound.protection.outlook.com [104.47.0.64]) by dpdk.org (Postfix) with ESMTP id E3D7D1C660 for ; Thu, 5 Apr 2018 10:56:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=1fjCNwh3z8miiHGcJq6t0NO4OZV4XDY1oYhGawSEc1M=; b=TfGYkJZo+UyacO64TebIA+2GVZ+jvhzjAg0dNBPWnYZgHBYeBkB8ogp34AhpyfG0HGyYoA9ccRKIp8r+fGq3N1f0hVlTonIHKpn25INbuZoSI1s+k9/Wr8+yge9m25D/pn6E1BrPc5OhXuJc8XBo82p4isD5QusyXUCv3QXMSIk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; Received: from bf-netperf1.ap.freescale.net (14.142.187.166) by DB3PR04MB0762.eurprd04.prod.outlook.com (2a01:111:e400:9440::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.631.10; Thu, 5 Apr 2018 08:56:18 +0000 From: Hemant Agrawal To: ferruh.yigit@intel.com Cc: dev@dpdk.org, shreyansh.jain@nxp.com Date: Thu, 5 Apr 2018 14:24:18 +0530 Message-Id: <1522918464-4586-2-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1522918464-4586-1-git-send-email-hemant.agrawal@nxp.com> References: <1522918464-4586-1-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: MA1PR0101CA0043.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:22::29) To DB3PR04MB0762.eurprd04.prod.outlook.com (2a01:111:e400:9440::25) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 0a0b348d-d74f-44e7-62f9-08d59ad31945 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DB3PR04MB0762; X-Microsoft-Exchange-Diagnostics: 1; DB3PR04MB0762; 3:m8HVuyZhEreRjt+13a52TEIc4zPMKcDhe5gO1PKRaaGEqm40n2eec+nW/Zyk8o53RaEE4FaxsuyPljuWj3OnnblMTPd/zcG2wBNwypS9OyZYNDzhsK+lUDTGrySUHdmwi9ARd/Ol2G6k6TnnwPgivuv1NP93QcWnudYLAqcVvx9HD0IAd2iKuW9bFROBKd4QAA6dcAi6OJ90JFjj5XP4gNSn+eIiNwRRs889FMBZIXtBvYc12UjRxQgjfA+k2Osi; 25:PID2jMZtXIrCTXoAmrNmDbvCPfkvESDZofWeVBqOB3kWTFwRhYnCKL1Bj67hVSI9DGHDxAunxt5AW8omkp8a3B+pkG8s/AHIKG4kQ/B8aNgmjOjwtgZsk3f0b/ukry4q18vSjWIN1EU4EP1/XDoZsjZEwrciHy6jEZ+1pV9guJowO4sGFcprrcUfx5kNRVoWhr5xlyLRql8WX0o1s+jlBFxt3FCcXUh0nuS4jJ7eKcs2cS+rCoa3bNP9hlAkRNUhpN5mINDxMJivG1YTh1Q8IbfV1yHCE2hO/tutNFM8DhdoJYOrpux3zytkpOGrxT02jak1wWxlxylfJjre6sNf+Q==; 31:XxZyHwyJAYrYRzEj8YZHILMboqh+G88Jw44NuSpHhHXKk8KzO7jb5RmydR5TeeA0iaNUrIXm7o1dnw/aaSAqwwp/kqm4ckCsEvoJs8frZw+Yqme/V1wQddrBTIboe+t8azUj03MTTzwJVoqAzXoFIGJbFULO7XbHBBLUqe5xxuxb0BXQBMH5X9Wxw2hgSYdaK2oswdB2oKzwncLI1UqeHEe/Bvfqbar5xLMAP7LfSs0= X-MS-TrafficTypeDiagnostic: DB3PR04MB0762: X-Microsoft-Exchange-Diagnostics: 1; DB3PR04MB0762; 20:o+qxQQJbfRwFnIkbeX9n4JJDdrBGjDuXR75dfgx83UdwYOQ/uc8scwBB7uiVUZ0JObOjeBQsaDNpltVgDEatpQawtggpKF7JnmcFq2Kfb7Blg8iq4+8bksGpacobsgDDAjW1Y9fpAIVI+ItYywo0tP4oM5AdT7gJYNGUywou18Aq5oiFqWbTjC1+X5Tvbv0KX97jsZYkJ4em31sCRLSDltI4G6/bBb3kXybgkDFjXJfyj81wd5vCialKwCONeS6HFWnRBdeplResJQWYz3aQ8kzEJVlc6DlwbGXt1RowbbgdZbi9RvvlZroNW8elpfDksf4fiKQdX4Ce5jsPNQ4GE6mnA4bUKfmXNZqnlLAHvZpkzN6FzxAYoHavqZMH49wlFSaMY7OLKvk2sTFcc8XRX27K9lI0P9jM8KEhzDya26G43wwdSkxWr+p+yaq9+x0FSs8vFxtwYzDuRCb4Lpj3ETfrprPobO3V4A7UJj8F6aTYAD7MWxG6Ui60KwY6zITV; 4:SN7+58kB4+ONLGJtVrTLO1Qv9FlVD0FD36cNzjNP+2wlmt2wb05vZZSuDD5oKOrTi3lJDGjpkAZcgak+lVA2xkU57B7eFtVJdwqCrw8Z+N14tVvjxx4OanGU5L9bzx+psWgCQTyT95l7VEqCQgZIbomxmEDtUkJyCTT0BSK/9isMK6W42avrcRUT72aTe6wHlZxRA2MLePeGG83MaNQZb1/6nTnsNs0h4Z2QYhYOvvUXxuNgAkwA1w+dFwPJEep/VJishWcZJitJyG2tlKWO8FzghRD1WavU/dbrpYN9aKP5Rkvc1YLzC9IkCUYtNR79JsTUPtYvschJwbza/gNRu2ghujy5JukiJL9FYrRPi+3R9AuHzBPxurhLyqEeXS41 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(227817650892897)(275809806118684); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231221)(944501327)(52105095)(93006095)(93001095)(10201501046)(6055026)(6041310)(20161123558120)(20161123564045)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:DB3PR04MB0762; BCL:0; PCL:0; RULEID:; SRVR:DB3PR04MB0762; X-Forefront-PRVS: 06339BAE63 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(366004)(376002)(346002)(39860400002)(39380400002)(189003)(199004)(76176011)(81166006)(53936002)(2361001)(2351001)(6916009)(25786009)(7736002)(476003)(50226002)(86362001)(81156014)(486006)(97736004)(105586002)(26005)(6512007)(52116002)(3846002)(11346002)(8936002)(446003)(16526019)(106356001)(51416003)(8676002)(386003)(48376002)(6486002)(47776003)(66066001)(68736007)(5660300001)(956004)(55236004)(478600001)(36756003)(6506007)(2906002)(2616005)(5009440100003)(59450400001)(305945005)(4326008)(6116002)(50466002)(186003)(316002)(16586007)(110426004); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR04MB0762; H:bf-netperf1.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB3PR04MB0762; 23:7QBBgFAYmj0c/eo6GaPJbr4QYK689qMpTUXF9GZ57?= =?us-ascii?Q?FXEz1HfPLBvT5I27OoeHqEvKaP2WM5esYWO42j45uaACrK5RgzXMfMnD65Nd?= =?us-ascii?Q?ERdgr9vIo+oj+bs3fxLlnINCjGB5Hjh9OB1AtCmgiYhFS2R7mL/OmvhMHr4K?= =?us-ascii?Q?ZGFk+sScJ8XL6Jv8PoRwtwvp49EiHI3Z/cf/viEoyg6x2rFfEynP+1B2lsuF?= =?us-ascii?Q?A7flFfi7oKi+vV0qHxOY6LSzbASspCchE40+3+RiRatDccZgoToF3Hh8eTkw?= =?us-ascii?Q?+rurMie8gn9LGUscOxF0PAR1pJckeJtVHnhzMeJdfMhxY+nhoFX/Ib9aEp8M?= =?us-ascii?Q?JlFb7qocoim4KjbDaVRSh+4bBN9QnheOOUt2RCgSAP0022uC7TNy0F5YOwO0?= =?us-ascii?Q?KUiX8kbFiTMXoi+bBwn+u+nq77G1wLlNJjHO7K34FnVEQm5noJcYLGtkodhT?= =?us-ascii?Q?WOax2fDfHnD/5Wy042WHsLk0hbR8UkF8zT0wE1PN1S5o1jW7I07vQKDLpwuI?= =?us-ascii?Q?eSkQc2FXJb5CCvpexPRYuaH7UZphPvzP0HzU5Q9xCwBxlskcdHHo5lFJrSY/?= =?us-ascii?Q?NHlCyfrWrmm/IuGGOlB1IW0RW2oHazMjYlvKUfTCPmQkQrgS/X9//fki0l24?= =?us-ascii?Q?MFakHpD5vMTp08CVDbKFSq6LLuYEDGWgyx8JPZql7HTCx4OCIkcvyWRKaCVV?= =?us-ascii?Q?zPMZE/cEsbhYS/q9suNv//WlJSMss8HJifmvMhMwGrsT/L+KAJx0yKw8O3P3?= =?us-ascii?Q?fav64oSJpHG4sZN1uSpHg0F3YJt42fZLRx9AkpLTSz0l4N8dmaGgKsCqrL4F?= =?us-ascii?Q?YpchksoAPn7P3W9E24PhaD6vNfbuOUHgs3Mqfb9kA0jdrS6UzNfw3Yfnp0xS?= =?us-ascii?Q?XOccvfDhV7RI5h4xv2ragkHCA1MTev6y3RgGc6BkjkhBz3yysjSO8mA+ert9?= =?us-ascii?Q?97wNaazCgj5dMkNTj4YDLPdLIl+RzP35ukR/8DJUvMh/gU8qcdzGI199fSJm?= =?us-ascii?Q?vQ2VUG9DJcJz0JmavMI+nYzQ66LSjm8SlHvNiZhjckk8in+iWC5yXNIFNEQc?= =?us-ascii?Q?7zzI9eRS4+7h6bfWtk3St4GsLP41NA1iemdPBRsS2f+z2xG+2u/9ch5H+AK0?= =?us-ascii?Q?0LK/hlrQ/1y7JFqBxj/bCqjK4r8GR6jg8AV1QTSoXziR5LfUt/bz8nDm1hJ8?= =?us-ascii?Q?C8QT7EDqH2B+82VoB95YZFBBtNA5+xmfCSZxMumGfFlFPSslcYRQw/2D+uIU?= =?us-ascii?Q?nQnwLu6hhuRQvruSr8FITho2DA4nX47gk8wOTy2Bu3RBethDkBfm42r5q7XM?= =?us-ascii?B?dz09?= X-Microsoft-Antispam-Message-Info: rPMXWr3EnreBbAoSxx5ffC0MSP+y5Ga0Z1EvCXv9hrND/eHE7eke5n7Ah+5j77KTeltm8UnsfiJVatuuWtokyJp/cfLULuG/h/CLb1Y7tQcWzDeGwDoyi4X+UhI0St1wlkrN6himGCQVcIRWjZZ4EIuL4C61jiiiJPFRd3G2cCl3c0hue2rBwF8lFpt+fmkP X-Microsoft-Exchange-Diagnostics: 1; DB3PR04MB0762; 6:FBJQFSGfaraLf7WEhZzTqbcjbgMQl5d4Pth2/Bm9kUb/3BaYgGmhY7WgHTTspMxcdhlw6Jlhognsekb63Dw98DPmXElh8E40EOThuMK0PyhZb4AiNB+lRoq1MkXCnOf2xFM6JNB5LD6WAyK2E2Kr/hV6iuBxW7111CO9zGtOPkdEgPxRIUd8zk9Aop1CIPk/QCUlpxadxDkivM57E86zfyZGLW3EBftcjDyPlYYFt5hQ9BZx103RIsLKI81hcqGgvNFmN6vrGjFrRhjokSLxHVSVS4YDTlh4nRKtm58YkTfj+vpCsm4neR07S3Dkgd1p1GjzKhkHRfl5gW5ClK5YZjQWKLK/xrFzH/tSaWQ+N30XZVT4FT+kzBrz1GC+ZLdsdMe80P17I0UeXGAGw6YNdb7W4cSR/JXCKzB/JoAYt9VD3oTctpqp95KdnZ1jmFajziqlhzgZkpsZ3r+0ZcazfQ==; 5:jdl/vIED/KDQUyL7wMKhcEa/w3X1eGFQGf/eYoUJnYHdkOxDQ7+JKfbXZsYOYOgxJ4N5bN7V4ntrn6IRPaJUxmtbpypVKwnOrr20i15c/bVy3whYVyfpEtzfhAecnPDwxTKakTIlKhw2dTuPXbVm48YgmOL1UIP1QzBlaJOFW/M=; 24:eSvcvCYpJgqOJEs/Lt3G5SxDq/V+sPbKXXiJlfIpHm1W9sPtiwQDUaVzy7qRDDDIruhwmRZgWcTWKReCeF708yQ8gZXq7RcacST2wIVWmUI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB3PR04MB0762; 7:FnyMl30E9pOrQbdK7w8wMW+4sNEe+Bn7BszyOqUmZ3i0BPrAfC2G6k5kTwHqrxdjJrislIItYMSonj3byoxDpShSRgbZpEatTgI8m6B46+7hpLHPG8GdCsQrYj4+DkcQTYwj++kzubKi73f1ySO47Qg4VBlqZkHeC4JoF3QGCB2rDETutHqeyRzIGjrNzYIucJ8LdvCMR89Rbb2h9uEFP86uQ6vBpoiDv/NHKFMTU5/jNlX5q0c0pf8mIcHEt+WC X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2018 08:56:18.6172 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0a0b348d-d74f-44e7-62f9-08d59ad31945 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR04MB0762 Subject: [dpdk-dev] [PATCH 2/8] bus/dpaa: fix the unchecked return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Apr 2018 08:56:21 -0000 From: Sunil Kumar Kori Fixes: 5d944582d028 ("bus/dpaa: check portal presence in the caller function") Coverity issue: 268323 Cc: stable@dpdk.org Signed-off-by: Sunil Kumar Kori Acked-by: Hemant Agrawal --- drivers/bus/dpaa/dpaa_bus.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c index 3535da5..ffc90a7 100644 --- a/drivers/bus/dpaa/dpaa_bus.c +++ b/drivers/bus/dpaa/dpaa_bus.c @@ -308,9 +308,15 @@ rte_dpaa_portal_fq_init(void *arg, struct qman_fq *fq) /* Affine above created portal with channel*/ u32 sdqcr; struct qman_portal *qp; + int ret; - if (unlikely(!RTE_PER_LCORE(dpaa_io))) - rte_dpaa_portal_init(arg); + if (unlikely(!RTE_PER_LCORE(dpaa_io))) { + ret = rte_dpaa_portal_init(arg); + if (ret < 0) { + DPAA_BUS_LOG(ERR, "portal initialization failure"); + return ret; + } + } /* Initialise qman specific portals */ qp = fsl_qman_portal_create(); -- 2.7.4