From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0061.outbound.protection.outlook.com [104.47.1.61]) by dpdk.org (Postfix) with ESMTP id 1DB131B7BE; Mon, 9 Apr 2018 12:25:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=1fjCNwh3z8miiHGcJq6t0NO4OZV4XDY1oYhGawSEc1M=; b=X51ycSn4CTFHDF4dSgll63uCZ1M5fz8OEe/Frp2TcxRzh14l/2Cx1ZnqL7zXgSYbh1DVreCgus20LJf5BQgd7u1Ao5q0uIDVnScWq6I5/JAEFonP1WqYOs0ZUdbXBL2zbKWIV+00YW29UweRlvJ2OIPZRuRsmcar8G6Dz+JVyRM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; Received: from bf-netperf1.ap.freescale.net (14.142.187.166) by AM2PR04MB0756.eurprd04.prod.outlook.com (2a01:111:e400:8411::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.653.12; Mon, 9 Apr 2018 10:25:49 +0000 From: Hemant Agrawal To: dev@dpdk.org Cc: ferruh.yigit@intel.com, Sunil Kumar Kori , stable@dpdk.org Date: Mon, 9 Apr 2018 15:52:45 +0530 Message-Id: <1523269371-28799-2-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1523269371-28799-1-git-send-email-hemant.agrawal@nxp.com> References: <1522918464-4586-1-git-send-email-hemant.agrawal@nxp.com> <1523269371-28799-1-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: PN1PR0101CA0067.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:d::29) To AM2PR04MB0756.eurprd04.prod.outlook.com (2a01:111:e400:8411::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 2b8a80f8-8b6c-4d31-c424-08d59e044476 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM2PR04MB0756; X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0756; 3:znILechAeRl8ggs/DRFL5LJTccn2ZWCfbm8Eavgu5BzDH3VCM9+KixF5XgvKwStf3ax2+7bQuZqfWKiW6a0hyPJjnrly3aBo/jtFAOy02C9cbs3MrS++x5l9khLPNRs+OJ7mwxkjTkBgYi0arL0xKAJ/VJbftYKUHehwGbUmsv23CfvJMmWnwPwI7cAL0yRq2VZM9DSLw3UjbdH7U5gsAH07bZEy/prpgFHOgSeCSf/RXVFuNorSlX5B5BuCtyhU; 25:b5s3uEn5VtDaI5hqOe+ymXTH88K6/l/C9tUoKJ5UvaVoxn0yDg/vKngz38dLd32LS9NV54sDGSTzkNpoF4HpScq83MOXi3QcL3X96J6A5qN3s/gKxe+zQnnZuD2D5klRMc8KNyJFFUqHo3VxKiAelbbPuSbbm6I4gu5Ba5wEd8Mm4ih+IP4sk6NdHlmp3kJW01nrwLsiHxXtc4oNu5GElfEZamir19+B8zKAyREC+OpntGCG6LwC8S6HWbafDdNFUKULbuQb5v3T+TZ7/hOGEzt8jvVLt1QPwKCJ52zEbZGbuavm1s5sTUOZfD5Z+BHttlmzLk35wj8eBKiiEN3A3Q==; 31:LfuGbDfC9elHsBj46eDkvY8fjeQnfXXjFPOvhIGz/XRqEkwhG/4XMdk+XJyRpwm7RDp3ak0qpX55IExn2sAg+r2BbNg99CQrIF7VyM0yvt+lg9taKkL0VT9BI7q83xFAqrZ6Xj0PkX4RNYn2R8TjreyfRPIqZgY4juLFKMT9PPULMrRp0evM6zmL7ZYM4EWefw5pIf6mxJ1t2kbs+6+YpYTu3E2STVILjdPFyzhWjNw= X-MS-TrafficTypeDiagnostic: AM2PR04MB0756: X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0756; 20:UE8QOcu60sYvtd9bUiuMgBNg3m0CUqEoMJDl0zKjlUp0Lf+Tp7thSWD6etbGYjuT/bsqXfQTeHDHncCXL00QTlT0Mrrburd2jJvsGk/2kYbB/9DDe+HACCi9EYav1zFyn3C87mzGfIJd0ezdC+QkAdeDKlxt24A6bYXv2c+TwC3wxTzopr+vZT5OLa69g4586DaFjmvIfCl98rn+awf8NNrhPBEdirMce3Fzjq6ye7rtv+L3D7da8rrfEdLlJ6TTnWNb60xRiiRmi1yalWWlxpyoax/jiOZVx4RVrNLE8pbQDMJ+f7LFbNJwYsuSWFexpypkvRmCUuOSn+DS/TC8Jg9I3oXWL1+kExWMYjG39EiMA0XLgLKPkd8eRTciYhnqbwSXD2NR3Y9Bh+w9UVuaFBTaHuoXQkNn1zKYZFcsuBOx5fwlB73j6Xa0Msg7ntntF8GGuaOt5ipec6PSfP2eIFuBL1iguREKzTA4oPStBMeGDyUiFPVnZ3Ou9MSJUyCC; 4:RU3HjTtvi24JMsHkvZFsmOyrSK3vQyhJjDuTPQDuGbzrk+nYCeJ2/FUAd9PY/LpwSa6ld0JqRcPR7YYXfMih8u+FwR228ijmWHazv4tyf9rldaVh8aBK8xqZ8aNsduDFRz0KUe9Gfkib8jooXzKnMGDdzcqv3eYWouEyEU+Zhio/fkFbWwkgy6ZI79q6XMoVIb7apnqRtH8ORJlPKLa3Tcn+b5wWvLmfrAmAqRMTHrG7lFBHiyslTQ+KL4IrCJsGkZY7hlsp7dsPvb1ExE03zR+QLw8JJZD0sHe2GVgT76pC0RvDbPMoPvuDx823JjRKMONLXHRK1egMSOaOY9FKJlei2STsxzzZw4G0VR9HkMxz0WdKTmP2o8Z5czCAu96N X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(227817650892897)(275809806118684); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231221)(944501327)(52105095)(6055026)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(20161123558120)(20161123562045)(6072148)(201708071742011); SRVR:AM2PR04MB0756; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0756; X-Forefront-PRVS: 0637FCE711 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(346002)(39380400002)(39860400002)(396003)(366004)(199004)(189003)(36756003)(48376002)(50466002)(8936002)(6486002)(6916009)(81156014)(50226002)(6666003)(81166006)(8676002)(106356001)(68736007)(316002)(16526019)(3846002)(16586007)(2351001)(2361001)(47776003)(2616005)(26005)(6506007)(386003)(59450400001)(55236004)(66066001)(6116002)(305945005)(97736004)(76176011)(7736002)(956004)(52116002)(51416003)(476003)(486006)(53936002)(186003)(2906002)(86362001)(4326008)(6512007)(25786009)(446003)(5660300001)(478600001)(105586002)(5009440100003)(11346002)(110426004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0756; H:bf-netperf1.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM2PR04MB0756; 23:uh1oWYsYFF/4tL1nNJUfd7WZ9DbqTYOEI7g8zvOtz?= =?us-ascii?Q?5EZTFghcIQWlv6k80+hRtWLcnJ9coKxJxTTQasL2KvcBrqnEUYHDTQIWHRPC?= =?us-ascii?Q?SqbB6VIS+iplEDOSMVYaKGoUFatk0yv0H3ENCRaRLVvjIdMYl1AVASso9nx2?= =?us-ascii?Q?B+4ua0zM6aJrvmRiBlUBl7rn2vZRswHEgdbYq2PU5lZ4QwZjKC9dhGxV+Ef6?= =?us-ascii?Q?+f7y0rffws8trikShx5g4XylckrTAehKGm74L+HZwKuapYj982h5dj9F8RXS?= =?us-ascii?Q?kXPqdph1Zxw7pkgzKF6OquNpB4vveFi4dKSf/MM/sQHmv2zWGu8sQt+FSKVi?= =?us-ascii?Q?+4bo+LIjvGfWyzLnHRhudoxmdQAGLT9MtBMS/bMY4LhNnBFuEMN7dHbtOLQu?= =?us-ascii?Q?FCsFTyO5X95bAUWEibej6kGTZzs+H07aAfySoeMLF2S312O0nvDodTJ1iD8m?= =?us-ascii?Q?6XCEDkfvgXzFEbu1k60Pol6uM9QM9hyugVtilB2q8wdelnA9a50+fcEwD7w9?= =?us-ascii?Q?gxEi0h3tj0HYSBKTwFh7hdNIdx/cCHdEgz0/xlStzGTn8/ljBGOTmKSU3G9C?= =?us-ascii?Q?zLSO2ARMI83VpdhM56Q8lFFWtfoRVySueiK06WBWCCVnndWDcM/JGWObQ9ha?= =?us-ascii?Q?uaQfrSGoRjHymtpaeu27NdQhUxRPSX3K+1m3gdnyuB/e4auhaLh7iIZvQ45p?= =?us-ascii?Q?HWf39Kak0EgJcKudxpFm7jChuf3M4guULhedz5r8ITVVdGQBA57WarP4Ghvp?= =?us-ascii?Q?LA8725ia3YI080S0Kp/s42GDtguDxBFg8iEb3JX2XWzy9tAJk9yk7/xOoZ3S?= =?us-ascii?Q?4jx/m4LS6MFhFZNnhBu5TgP5X1g+/Ad3klqvmzs7b1t1FW+c5WAx2vEPaB8e?= =?us-ascii?Q?nQpFSKdr21lT0jEqLMUpXo1gL9XcXYQPHJRgkxUV9sFnt7VyNqNXVMI94jNp?= =?us-ascii?Q?12k+wVE0ERSyMkvUzn5lDWSQR/aI+kjrqXsqQPcT4oYG0xlCictxre+JaKxK?= =?us-ascii?Q?ABxRYdKn1bENyn52OvwV4aCAOAfs4ogdkj9eujDqvkSZBlzlGuqCUz+VHnfo?= =?us-ascii?Q?3vnZL08ths1gXf+R96kvIScK4RKZoT62WUQIZci4ZrJeMLD49fd5i5GCMEuS?= =?us-ascii?Q?nxeBxiU/K0NXow1HCKoB4HGOuISQgED0b91XSTAYDU/ae3iMrfjLbX2PPxYx?= =?us-ascii?Q?cLKKoaPwZJw+d4xycz4ymzk7hdA7GHeP7vn6/bZnpIckAto6ZW6zAaYwtCId?= =?us-ascii?Q?EE6xCh9UwJ3ZmAazGrrccMOkdkqaX7XDcmlE7s/aUXN3xdqDIJmWA+N3ddCE?= =?us-ascii?Q?5CFnOEYa9ncsQicQeq7n0o=3D?= X-Microsoft-Antispam-Message-Info: +12PmWS8Uth2ZdPNFGELg5vPendmSlL4DCmJ3iyKwDHjC7S1QvpNaFUGAZNl51xhS0JscRbfg5gp9vYI5sEEJ/OKk4a0iUSZHhDujafzHIiewvtenaMrhBi+RXWbXXFWWOTCLMZsJzI41BZlp+XVGUS6HMFkZTTlZdOC5XRD7UN/umCdnAkOxQnBQVDf/xtg X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0756; 6:cj2IB7lU8SG9XKbYxhJZluKNAcR8IPlnbJHO5WxJM1OT9KG88XKiJ2yk9TOfT5kK2FGT24QP7TfJyc4hxfIssv8cEWRn/osUg313D7M7NZzOdJSVxf6ByL1xloscpcgT3FlfPaCb1ubyKA/+xDDuuF+YVrZ3gb4beyQwcWXi17Je5gpxMXRPg0m8eahVGZUKvx0BIHcGKgsGD6neg7wHNAnQlaNZQQNo66qbjY2U2sYa+HxZcsBzJH7vCijEGZt95krJKn0mDv2Gw3c5CwvO2ejZmJKZqptZaiPwbOBb0ljJq5ezT4lH5Tg1G5gsd4oRt1DIOIDknxNdV/msay0ej/jm4AKwl7Xuv/MdVOgXxyLkc6ocR65oywG6UR6C+BsHUBGNkoSR3qpswwtJCAAxKaEsFeIVbXtz3uDmcA/XL3rYwXyX+Pj4gwJevaRYZl+YLTaWZXjanWUNyh/8AakCtg==; 5:n+nGSFHHr/opZweJu1QkXmP1yDdatMDmI3JchGptWtASUb6T0h89BZ8qmQs6afLllYpCt+eljr58+2V1+9HTY1BhZH1nJHgiwbI7FjbWbq7Uj5Rt9eB0ea/in7goYg48ESSct/xAmK/dmhxgdG8p7plMy9Pn33+7h2KQEeB4z64=; 24:RcSjsb9NIt3PTrW04HJ8grF6yXOylWpMzMEQg1YW5UliC2OpEIP2t2k8AFkmrdbD1Ze3TCMwP6TcRtbMDyQj2PWEInsEjJ0ZDAfrie7ADDs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0756; 7:jOSW1MBbOHOe9YWUzHK2f62el2q5CTwnLoG8JMnvD0OgHwc4dC+Dnczzc7VZawiR/3zmPjRrn0gux5bmldfiRRYV6kQhWfZapU7oJ2GULEcxydrUEgEmqy4zW6fr7xG0XE09EIZCqf4XY5GDf3r9sZeQB6GCIkeqy+i1Q68FqQW4TmbJ37F2zoadC3uPWr98HxgTs1BliPDcYGm+XblGJwdlffU9xGPRi+ImgW12akDGPPQN4FZIcb1hkkLqrPx9 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2018 10:25:49.9266 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2b8a80f8-8b6c-4d31-c424-08d59e044476 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0756 Subject: [dpdk-dev] [PATCH v2 2/8] bus/dpaa: fix the unchecked return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Apr 2018 10:25:53 -0000 From: Sunil Kumar Kori Fixes: 5d944582d028 ("bus/dpaa: check portal presence in the caller function") Coverity issue: 268323 Cc: stable@dpdk.org Signed-off-by: Sunil Kumar Kori Acked-by: Hemant Agrawal --- drivers/bus/dpaa/dpaa_bus.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c index 3535da5..ffc90a7 100644 --- a/drivers/bus/dpaa/dpaa_bus.c +++ b/drivers/bus/dpaa/dpaa_bus.c @@ -308,9 +308,15 @@ rte_dpaa_portal_fq_init(void *arg, struct qman_fq *fq) /* Affine above created portal with channel*/ u32 sdqcr; struct qman_portal *qp; + int ret; - if (unlikely(!RTE_PER_LCORE(dpaa_io))) - rte_dpaa_portal_init(arg); + if (unlikely(!RTE_PER_LCORE(dpaa_io))) { + ret = rte_dpaa_portal_init(arg); + if (ret < 0) { + DPAA_BUS_LOG(ERR, "portal initialization failure"); + return ret; + } + } /* Initialise qman specific portals */ qp = fsl_qman_portal_create(); -- 2.7.4