From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 7124E29B6 for ; Mon, 21 Mar 2016 09:38:45 +0100 (CET) Received: by mail-wm0-f54.google.com with SMTP id l68so112213089wml.1 for ; Mon, 21 Mar 2016 01:38:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=vYHOSMMCTxcOFuFrvZ//gKCfZEZzgZDekrwXuyJXWgE=; b=yLNieQOQf2qZc3S/pzVZWLbrbe+Y0tUljJuQxMa7i2IgcW48zyAlCIvIyzE9/yGnRP 0fzWGHuginvtAkhMdVZgtYQaYSEyxY3FmNNcMH4Rpgc10Lr/hB7O9hBao1Oeuqqn4mXk UqzRT8Rk2el566Mvv1u+eLQvlQno8DWkyuJTe+1cXLTrvDuBAySirX9rIwrRCKNLiQTt h5fo4s++JCEOZlT9UIdLrn0QvwarZXpKGzkqlCxKmPBE3pKdLuZDUQmFRgVUaklC3awb +f9WuaDaiF35dAHCrp4IOY1N/ph3NEKCATlSZBmkMFqB1+DLk3uMcA2jY6cEpcFqwpE7 Ih+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=vYHOSMMCTxcOFuFrvZ//gKCfZEZzgZDekrwXuyJXWgE=; b=hSXKW++vtS6IRzZBbLy7Cci7LH3A8KtByw81I43EIf2h4apRH/1Rts2ihMtfF/2yOB JSllAJfSyxsWFJ7cQn5+jjHjvlY/Yd0ZV5+VJvlspMV8jWjzPS5EDa1oWht6KGMA76no w7rqlC4FEINIUBoRSClCmt6lIT18RY+EYrh+/QZSNiTGvH/yPxg4iwGF4Qtyb+Y3fHPg zQ9A5rSl3U0eLJxxnNBfYbGjSosZp3wVvSqVS2ddWl7DEBpFko/SobxIKNo9Stti4M7u M3yrFQw4K5nuK2tFG7KsNTRgpcjzYXZAgZYqzwgaBgubELnh1qkUksV4Fca7wPlvt3jt T87g== X-Gm-Message-State: AD7BkJLQrIssj3Axa2vhC+dhJioMdii/meMdBroyjefF6YjTQa/IvqUl1554AyjG+M52AOhz X-Received: by 10.194.187.240 with SMTP id fv16mr32971952wjc.53.1458549525263; Mon, 21 Mar 2016 01:38:45 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id b1sm24196961wjy.0.2016.03.21.01.38.43 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 21 Mar 2016 01:38:44 -0700 (PDT) From: Thomas Monjalon To: Tetsuya Mukawa Cc: dev@dpdk.org, bruce.richardson@intel.com, ann.zhuangyanying@huawei.com Date: Mon, 21 Mar 2016 09:37:07 +0100 Message-ID: <1523315.o3rXJh0SOG@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1458539108-15686-2-git-send-email-mukawa@igel.co.jp> References: <1458539108-15686-1-git-send-email-mukawa@igel.co.jp> <1458539108-15686-2-git-send-email-mukawa@igel.co.jp> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v13 1/2] ethdev: Add a new event type to notify a queue state changed event X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2016 08:38:45 -0000 2016-03-21 14:45, Tetsuya Mukawa: > This event will be occured when some queues are enabled or disabled. > So far, only vhost PMD supports the event, and it indicates some queues > are enabled or disabled by virtio-net device. Such an event is needed > because virtio-net device may not enable all queues vhost PMD prepare. > > Because only vhost PMD uses the event so far, it isn't an actual hardware > interrupt but a simple software event. [...] > > + RTE_ETH_EVENT_QUEUE_STATE_CHANGE, > + /**< queue state changed interrupt */ Is the shorter RTE_ETH_EVENT_QUEUE_STATE descriptive enough? What about this comment? /**< queue state event (enabled/disabled) */