From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BD96A0588; Thu, 16 Apr 2020 22:00:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A9B171DE28; Thu, 16 Apr 2020 22:00:32 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 7BE611DDD0 for ; Thu, 16 Apr 2020 22:00:31 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id DBF3E580517; Thu, 16 Apr 2020 16:00:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 16 Apr 2020 16:00:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=aCEQluslyM7h4OY0P3FQ97zXtwtGCDNYYDjNWsvYDAU=; b=GSl+yL+fYi86 r4PSaF8yopmhe0iHaxFzU31grH3rAR0dojteWXgusF/LG1O0/NRAw0j92icf3Kqf JhkuwGtCfJYsZwn+HuTrDCXd3SlLLl04bgDcQeleZJK8ThdXv8VIg62ymwzRc02v rkoLftqoUMkNwOigVdIEGYdNMgTp2/g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=aCEQluslyM7h4OY0P3FQ97zXtwtGCDNYYDjNWsvYD AU=; b=QLLPCOUgjGrZEfoL5ac0cM1ThLcmWUva9BVVCF4oLgPUWu1yUEQzbeneB UrMxb3qK6jVpNiyq42QXpfxBO8RB1ficqKdFomx4dHfw+ssixqNIMSYty3TLh6nD AuTudM4Iv4rJ3vt/lqs3gUjIw20NO/PN1qbXa+7NiIgiPe1YfRiuCf1zZHnGMbDG CIPeZLD06ttVIcKzVu0SHfkfhBnMSxfcqynQA1pSvQD4fblBKjhnlrfjhdIdhDaY Jg5x0dY3zkIV5RDd+ugwBa66tVh1ZOlBelkA1Vn6VRWuq5+kcomZ1ICCqxQaEe9P dr1SZTioAfzsk5jNL6Wx/+VT4/VPQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrfeehgddugeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpeguphgukhdrohhrghdpthhrrghvihhsqdgtihdrtghomhenucfkphepjeej rddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2B979306005B; Thu, 16 Apr 2020 16:00:27 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: Matan Azrad , Raslan Darawsheh , Ophir Munk , David Marchand , "dev@dpdk.org" , Olga Shern , Asaf Penso , "Kinsella, Ray" , Neil Horman , Kevin Laatz , hemant.agrawal@nxp.com, Haiyue Wang , Sunil Kumar Kori Date: Thu, 16 Apr 2020 22:00:25 +0200 Message-ID: <15233448.O6BkTfRZtg@thomas> In-Reply-To: <54f82543-e53e-98dd-bcc8-cb3669933fa5@intel.com> References: <20200329223222.7553-1-ophirmu@mellanox.com> <54f82543-e53e-98dd-bcc8-cb3669933fa5@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1] common/mlx5: remove devx depndency on ibv and dv X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/04/2020 19:35, Ferruh Yigit: > On 4/9/2020 8:24 AM, David Marchand wrote: > > On Wed, Apr 8, 2020 at 7:12 PM Ferruh Yigit wrote: > >> On 4/1/2020 10:59 AM, Raslan Darawsheh wrote: > >>> From: Ophir Munk > >>>> > >>>> File mlx5_devx_cmds.c should contain pure DevX calls. It must be OS > >>>> agnostic and not include any references to ibv or dv structs (defined in > >>>> ibverbs and rdma-core linux libraries). This commit replaces all ibv and > >>>> dv references with 'void *'. Specifically, the following struct were > >>>> replaced: > >>>> 1. struct ibv_context * > >>>> 2. struct ibv_qp * > >>>> 3. struct mlx5dv_devx_cmd_comp * > >>>> > >>>> Signed-off-by: Ophir Munk > >>> > >>> Patch applied to next-net-mlx, > >>> > >> > >> Hi David, > >> > >> This patch is failing in the travis for ABI checks [1], since mlx has APIs now > >> [2], are they public APIs or internal ones, and are they part of the ABI policy, > >> can you please check this? > > > > - What I see on patchwork and test-report ml for this patch: > > http://patchwork.dpdk.org/patch/67367/ > > > > Ophir proposed a patch on 03/30. > > > > The robot reported an issue on 03/30, and I suppose Ophir got a report. > > https://mails.dpdk.org/archives/test-report/2020-March/122623.html > > https://travis-ci.com/github/ovsrobot/dpdk/jobs/308057800#L2337 > > > > Matan acked the patch on 03/31. > > > > Rasland merged the patch on 04/01. > > > > I understand that the abi checks are not perfect, and people need help > > with the new abi checks. > > Prove me wrong, but here, I get the feeling that it was just ignored > > by 3 people in a row. > > > > - On the question if these should be public API or internal, that is > > not for me to reply/investigate. > > This is a question for Mellanox. > > > > Hi Matan, Raslan, Ophir, > > First can you please clarify if these APIs are internal or public? As most of common drivers, some functions are exported to be used by some PMDs. So they are not part of the API/ABI and should be skipped by ABI checks. > And later if the ABI break issue is not clarified I may need to drop these > patches. Right now they fail in travis! Yes, it fails and could it be avoided with some libabigail config. But the real solution is to mark internal symbols, and we are waiting for rte_internal patchset to be completed and merged. Ferruh, please let's not bloat libabigail config, and reject any patch failing ABI checks. As a consequence, this patch must be dropped until it uses rte_internal. Thanks