* [dpdk-dev] [PATCH] devtools: improve kernel script execution check
@ 2018-04-18 12:21 Juhamatti Kuusisaari
2018-04-18 13:30 ` Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: Juhamatti Kuusisaari @ 2018-04-18 12:21 UTC (permalink / raw)
To: thomas; +Cc: dev, Juhamatti Kuusisaari
Handle properly a case where DPDK_PATCH_PATH is set
to point to a directory.
Signed-off-by: Juhamatti Kuusisaari <juhamatti.kuusisaari@coriant.com>
---
devtools/checkpatches.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 7676a6b..2bb5458 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -75,7 +75,7 @@ while getopts hn:qv ARG ; do
done
shift $(($OPTIND - 1))
-if [ ! -x "$DPDK_CHECKPATCH_PATH" ] ; then
+if [ ! -f "$DPDK_CHECKPATCH_PATH" ] || [ ! -x "$DPDK_CHECKPATCH_PATH" ] ; then
print_usage >&2
echo
echo 'Cannot execute DPDK_CHECKPATCH_PATH' >&2
--
2.8.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] devtools: improve kernel script execution check
2018-04-18 12:21 [dpdk-dev] [PATCH] devtools: improve kernel script execution check Juhamatti Kuusisaari
@ 2018-04-18 13:30 ` Ferruh Yigit
2018-04-18 14:06 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2018-04-18 13:30 UTC (permalink / raw)
To: Juhamatti Kuusisaari, thomas; +Cc: dev
On 4/18/2018 1:21 PM, Juhamatti Kuusisaari wrote:
> Handle properly a case where DPDK_PATCH_PATH is set
> to point to a directory.
>
> Signed-off-by: Juhamatti Kuusisaari <juhamatti.kuusisaari@coriant.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] devtools: improve kernel script execution check
2018-04-18 13:30 ` Ferruh Yigit
@ 2018-04-18 14:06 ` Thomas Monjalon
2018-04-18 14:09 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2018-04-18 14:06 UTC (permalink / raw)
To: Juhamatti Kuusisaari; +Cc: Ferruh Yigit, dev
18/04/2018 15:30, Ferruh Yigit:
> On 4/18/2018 1:21 PM, Juhamatti Kuusisaari wrote:
> > Handle properly a case where DPDK_PATCH_PATH is set
> > to point to a directory.
> >
> > Signed-off-by: Juhamatti Kuusisaari <juhamatti.kuusisaari@coriant.com>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Funny bug, I didn't thought that "test -x" is positive for directories.
It makes sense.
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] devtools: improve kernel script execution check
2018-04-18 14:06 ` Thomas Monjalon
@ 2018-04-18 14:09 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2018-04-18 14:09 UTC (permalink / raw)
To: Juhamatti Kuusisaari; +Cc: dev, Ferruh Yigit
18/04/2018 16:06, Thomas Monjalon:
> 18/04/2018 15:30, Ferruh Yigit:
> > On 4/18/2018 1:21 PM, Juhamatti Kuusisaari wrote:
> > > Handle properly a case where DPDK_PATCH_PATH is set
> > > to point to a directory.
> > >
> > > Signed-off-by: Juhamatti Kuusisaari <juhamatti.kuusisaari@coriant.com>
> >
> > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Funny bug, I didn't thought that "test -x" is positive for directories.
> It makes sense.
>
> Applied, thanks
No, sorry, not applied yet.
Please, could you send a v2 fixing devtools/get-maintainer.sh too?
Thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-04-18 14:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-18 12:21 [dpdk-dev] [PATCH] devtools: improve kernel script execution check Juhamatti Kuusisaari
2018-04-18 13:30 ` Ferruh Yigit
2018-04-18 14:06 ` Thomas Monjalon
2018-04-18 14:09 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).