From: Reshma Pattan <reshma.pattan@intel.com>
To: dev@dpdk.org
Cc: jasvinder.singh@intel.com, Reshma Pattan <reshma.pattan@intel.com>
Subject: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated
Date: Wed, 18 Apr 2018 17:58:10 +0100 [thread overview]
Message-ID: <1524070690-12000-4-git-send-email-reshma.pattan@intel.com> (raw)
In-Reply-To: <1524070690-12000-1-git-send-email-reshma.pattan@intel.com>
Copying source string of length equal to sizeof(profile->name)
will not append the NULL in destination.
Using strlcpy in place of strncpy fixes this issue as
strlcpy guarantees NULL termination.
Coverity issue: 272580
Fixes: 719374345c ("examples/ip_pipeline: add action profile objects")
CC: jasvinder.singh@intel.com
Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
---
examples/ip_pipeline/action.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/examples/ip_pipeline/action.c b/examples/ip_pipeline/action.c
index 77a04fe19..d2cd7286c 100644
--- a/examples/ip_pipeline/action.c
+++ b/examples/ip_pipeline/action.c
@@ -6,6 +6,8 @@
#include <stdlib.h>
#include <string.h>
+#include <rte_string_fns.h>
+
#include "action.h"
#include "hash_func.h"
@@ -345,7 +347,7 @@ table_action_profile_create(const char *name,
}
/* Node fill in */
- strncpy(profile->name, name, sizeof(profile->name));
+ strlcpy(profile->name, name, sizeof(profile->name));
memcpy(&profile->params, params, sizeof(*params));
profile->ap = ap;
--
2.14.3
next prev parent reply other threads:[~2018-04-18 16:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 16:58 [dpdk-dev] [PATCH] examples/ip_pipeline: fixes uninitialized scalar variable Reshma Pattan
2018-04-18 16:58 ` [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated Reshma Pattan
2018-04-19 8:36 ` Singh, Jasvinder
2018-04-18 16:58 ` [dpdk-dev] [PATCH] examples/ip_pipipeline: fix resource leak Reshma Pattan
2018-04-19 8:37 ` Singh, Jasvinder
2018-04-18 16:58 ` Reshma Pattan [this message]
2018-04-19 8:35 ` [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated Singh, Jasvinder
2018-04-19 8:37 ` [dpdk-dev] [PATCH] examples/ip_pipeline: fixes uninitialized scalar variable Singh, Jasvinder
-- strict thread matches above, loose matches on Subject: below --
2018-04-19 11:03 [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated Kevin Laatz
2018-04-19 15:33 ` Singh, Jasvinder
2018-04-19 11:01 Kevin Laatz
2018-04-19 15:34 ` Singh, Jasvinder
2018-04-17 13:28 Jasvinder Singh
2018-04-17 15:01 ` Bruce Richardson
2018-04-17 16:33 ` Singh, Jasvinder
2018-04-17 13:17 Jasvinder Singh
2018-04-17 14:59 ` Bruce Richardson
2018-04-16 16:57 Jasvinder Singh
2018-04-16 11:02 Fan Zhang
2018-04-16 13:17 ` Bruce Richardson
2018-05-08 14:28 ` Dumitrescu, Cristian
2018-05-08 19:51 ` Bruce Richardson
2018-05-09 9:26 ` Dumitrescu, Cristian
2018-04-16 10:26 Fan Zhang
2018-05-08 14:27 ` Dumitrescu, Cristian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1524070690-12000-4-git-send-email-reshma.pattan@intel.com \
--to=reshma.pattan@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).